Re: [quicwg/base-drafts] Recovery uses both time and packet thresholds (#1974)
ianswett <notifications@github.com> Fri, 30 November 2018 22:14 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 508C713107E for <quic-issues@ietfa.amsl.com>; Fri, 30 Nov 2018 14:14:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8NcdqZ4j-of7 for <quic-issues@ietfa.amsl.com>; Fri, 30 Nov 2018 14:14:32 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 65C6113107F for <quic-issues@ietf.org>; Fri, 30 Nov 2018 14:14:32 -0800 (PST)
Date: Fri, 30 Nov 2018 14:14:31 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543616071; bh=RuSgNuT36zqsqFNp4G2TO+iMOXUEAmAmQ5g82krrjvY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ap4KBZ8BA8LSRMPu57ZrsfsuoqFNejX6SYbNvxVcMf0wCfe2hmG5xsx3mYKCCg0Aw wonOYOqZgMDXBsxwGn1TkEmM4ZzNixWBrGJPJtQXflZYGf/RL8bCgf4joqqP3FPiTR B/nNVRkHuy4RG0LlyGVxEHdPn5emcGTEcNHePcKQ=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb3f830940280edaf01181533e91820a2d0b8643492cf000000011819784792a169ce1684c1ce@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1974/review/180471032@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1974@github.com>
References: <quicwg/base-drafts/pull/1974@github.com>
Subject: Re: [quicwg/base-drafts] Recovery uses both time and packet thresholds (#1974)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c01b6478197f_58513ff81f4d45c06591a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SqbTtG-EPssnZZpHuk625vW9GKM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Nov 2018 22:14:35 -0000
ianswett commented on this pull request. > @@ -907,14 +872,8 @@ Pseudocode for DetectLostPackets follows: DetectLostPackets(largest_acked): loss_time = 0 lost_packets = {} - delay_until_lost = infinite - if (kUsingTimeLossDetection): - delay_until_lost = - (1 + time_reordering_fraction) * - max(latest_rtt, smoothed_rtt) - else if (largest_acked.packet_number == largest_sent_packet): - // Early retransmit timer. - delay_until_lost = 9/8 * max(latest_rtt, smoothed_rtt) + delay_until_lost = (1 + time_reordering_fraction) * loss_time will only be non-0 if there are unacknowledged retransmittable packets sent prior to the largest acked packet. In that case, the loss threshold declares the unacknowledged packet lost. If there are no unacked packets less than largest acked, then the TLP would be armed, and as you said, it has a longer timeout. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1974#discussion_r238019097
- [quicwg/base-drafts] Recovery uses both time and … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … Marten Seemann
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … MikkelFJ
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … Subodh Iyengar
- Re: [quicwg/base-drafts] Recovery uses both time … janaiyengar
- Re: [quicwg/base-drafts] Recovery uses both time … janaiyengar
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … Subodh Iyengar
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … janaiyengar
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … Subodh Iyengar
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … ianswett
- Re: [quicwg/base-drafts] Recovery uses both time … janaiyengar
- Re: [quicwg/base-drafts] Recovery uses both time … janaiyengar
- Re: [quicwg/base-drafts] Recovery uses both time … janaiyengar
- Re: [quicwg/base-drafts] Recovery uses both time … janaiyengar
- Re: [quicwg/base-drafts] Recovery uses both time … MikkelFJ