Re: [quicwg/base-drafts] Recovery uses both time and packet thresholds (#1974)

[ianswett <[e-mail]>]

ianswett commented on this pull request.



> @@ -907,14 +872,8 @@ Pseudocode for DetectLostPackets follows:
 DetectLostPackets(largest_acked):
   loss_time = 0
   lost_packets = {}
-  delay_until_lost = infinite
-  if (kUsingTimeLossDetection):
-    delay_until_lost =
-      (1 + time_reordering_fraction) *
-          max(latest_rtt, smoothed_rtt)
-  else if (largest_acked.packet_number == largest_sent_packet):
-    // Early retransmit timer.
-    delay_until_lost = 9/8 * max(latest_rtt, smoothed_rtt)
+  delay_until_lost = (1 + time_reordering_fraction) *

loss_time will only be non-0 if there are unacknowledged retransmittable packets sent prior to the largest acked packet.  In that case, the loss threshold declares the unacknowledged packet lost.  If there are no unacked packets less than largest acked, then the TLP would be armed, and as you said, it has a longer timeout.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1974#discussion_r238019097