Re: [quicwg/base-drafts] Recovery uses both time and packet thresholds (#1974)

janaiyengar <notifications@github.com> Mon, 12 November 2018 11:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E0457130DF4 for <quic-issues@ietfa.amsl.com>; Mon, 12 Nov 2018 03:50:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i8Qgh2Xy5Ycl for <quic-issues@ietfa.amsl.com>; Mon, 12 Nov 2018 03:49:59 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0D049130DC9 for <quic-issues@ietf.org>; Mon, 12 Nov 2018 03:49:58 -0800 (PST)
Date: Mon, 12 Nov 2018 03:49:56 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542023396; bh=eBalG/aOafrS9hW5RyXXbkCM/3voFIaQhQgkbiz8Buw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=xMN4TC6a6lzHZ4O8Vq2AirOOyvBe3rtvRJrdHJgnhFvi277iZK5/J/zpX2gq2/5q2 wDtqkHJMluh4pfJLymjDA0+daxOs/rwxkRJfKkRpTAc2CbJc+3y5ZzUOS0LRjEMBta sfjDbo2E7wYxOYkCKP3hAD/k5JPwcBlUZJraBZX0=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab55e45f8db06f129e36505ee82617ec30ecebdee292cf0000000118012ae492a169ce1684c1ce@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1974/c437851876@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1974@github.com>
References: <quicwg/base-drafts/pull/1974@github.com>
Subject: Re: [quicwg/base-drafts] Recovery uses both time and packet thresholds (#1974)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5be968e4e2e03_22f33fef1dcd45b46603d6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wPTyA2hIUdJSxFDbAciOFPCgfjA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Nov 2018 11:50:01 -0000

FWIW, I'm in favor of this algorithmic change (remove time-based loss detection), but this change does not remove ER.  Early retransmit is exactly what the timer is used for, which gets armed if there are < 3 packets beyond the unacked packet. What we want is FR-with-packet-threshold and ER-with-time-threshold.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1974#issuecomment-437851876