Re: [quicwg/base-drafts] Consolidate connection ID negotiation section with prior text (#1888)

MikkelFJ <notifications@github.com> Fri, 19 October 2018 08:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4A952128766 for <quic-issues@ietfa.amsl.com>; Fri, 19 Oct 2018 01:36:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.064, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fw3uywhaeq33 for <quic-issues@ietfa.amsl.com>; Fri, 19 Oct 2018 01:36:42 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6B63E127AC2 for <quic-issues@ietf.org>; Fri, 19 Oct 2018 01:36:42 -0700 (PDT)
Date: Fri, 19 Oct 2018 01:36:41 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1539938201; bh=1H21dsi0HEV3bUgWIARP+PKORjiPDI3owxV5ir7Gsi4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=q+FWhsQigdePzfQpRUI4gEosO774pkGynHuDNWPOCg3uiSyj62b54gsebf5igMT3C V/dxV2xKBCjU7rJK0y+en3CYYuRCYz+YHUSqv6uazpCJBMROLt3a4AB44K7eUnAhOU tVsDJGzF51XetehI+W7Sa1HFUptnzdtP0jfdxiF4=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9be66be5bd0438f08b81d068a143d1edd715d83992cf0000000117e1599992a169ce16291e9f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1888/review/166424664@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1888@github.com>
References: <quicwg/base-drafts/pull/1888@github.com>
Subject: Re: [quicwg/base-drafts] Consolidate connection ID negotiation section with prior text (#1888)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bc9979943f8e_1abc3f82262d45b4314182"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SryaxSODuEkPc4g1Uo4t5A8iXVw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Oct 2018 08:36:44 -0000

mikkelfj commented on this pull request.



> @@ -926,6 +926,23 @@ them with other connection IDs for the same connection.  As a trivial example,
 this means the same connection ID MUST NOT be issued more than once on the same
 connection.
 
+Packets with long headers include at least two connection IDs, which are used to
+establish the connection IDs that are used for the connection when established,
+see {{negotiating-connection-ids}} for details.

Please consider rewording. The layers of establishment are confusing. Also, are the contained ID's used to establish themselves, or something else? If there are at least two, how many might that be in total, and why?

> @@ -926,6 +926,23 @@ them with other connection IDs for the same connection.  As a trivial example,
 this means the same connection ID MUST NOT be issued more than once on the same
 connection.
 
+Packets with long headers include at least two connection IDs, which are used to
+establish the connection IDs that are used for the connection when established,
+see {{negotiating-connection-ids}} for details.
+
+Packets with short headers ({{short-header}}) only include the Destination
+Connection ID and omit the explicit length.  The length of the Destination
+Connection ID field is expected to be known to endpoints.  Endpoints using a
+connection-ID based load balancer could agree with the load balancer on a fixed

connection-ID -> Connection ID

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1888#pullrequestreview-166424664