Re: [quicwg/base-drafts] Consolidate connection ID negotiation section with prior text (#1888)

janaiyengar <notifications@github.com> Tue, 23 October 2018 02:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB2A4130DEB for <quic-issues@ietfa.amsl.com>; Mon, 22 Oct 2018 19:46:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hojeuVHGVJIs for <quic-issues@ietfa.amsl.com>; Mon, 22 Oct 2018 19:46:40 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CA9571293FB for <quic-issues@ietf.org>; Mon, 22 Oct 2018 19:46:39 -0700 (PDT)
Date: Mon, 22 Oct 2018 19:46:38 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540262798; bh=HREfEfslp4HTaNS8pqRsijdiBMuovolNj9N6WbMhGYs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FGcDKgXl0tAeODjfXze+d9ZfnPa+nH0abU+0EFsfMjlZhacGcyzsedxm0FCbklsv2 jG/u8SMNBjhhFm9QF+KxYQBjgK07HSTnO6D1wzhAaVM1fddiU3SzJs2vTt/JV04Jm9 rTYAuYOYYyWiiJ++qPd08kl/FbTVN3paRtt+8Od4=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba9172aed921a772f48eff5eb6cbc08a2eea005fc92cf0000000117e64d8e92a169ce16291e9f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1888/review/167188604@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1888@github.com>
References: <quicwg/base-drafts/pull/1888@github.com>
Subject: Re: [quicwg/base-drafts] Consolidate connection ID negotiation section with prior text (#1888)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bce8b8eea35c_21bb3fa2416d45c0171817"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bVObpe388hiAQOJh_KuiRyYV1rU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2018 02:46:42 -0000

janaiyengar commented on this pull request.



> @@ -926,6 +926,23 @@ them with other connection IDs for the same connection.  As a trivial example,
 this means the same connection ID MUST NOT be issued more than once on the same
 connection.
 
+Packets with long headers include at least two connection IDs, which are used to
+establish the connection IDs that are used for the connection when established,
+see {{negotiating-connection-ids}} for details.

"used" is used twice in the sentence, which doesn't reads well. Also agree with @ianswett that it is worth spelling out the Retry case instead of alluding to it.


> @@ -926,6 +926,23 @@ them with other connection IDs for the same connection.  As a trivial example,
 this means the same connection ID MUST NOT be issued more than once on the same
 connection.
 
+Packets with long headers include at least two connection IDs, which are used to
+determine the connection IDs that are used for the connection when established,
+see {{negotiating-connection-ids}} for details.
+
+Packets with short headers ({{short-header}}) only include the Destination
+Connection ID and omit the explicit length.  The length of the Destination
+Connection ID field is expected to be known to endpoints.  Endpoints that use a
+load balancer that routes based on connection ID could agree with the load

Run on sentence ("that ... that"). I prefer the earlier construction: "Endpoints using a connection-ID based load balancer could agree with the load	balancer on a fixed or minimum length and on an encoding for connection IDs."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1888#pullrequestreview-167188604