Re: [quicwg/base-drafts] Consolidate connection ID negotiation section with prior text (#1888)

Martin Thomson <notifications@github.com> Tue, 23 October 2018 05:18 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A48DA130E89 for <quic-issues@ietfa.amsl.com>; Mon, 22 Oct 2018 22:18:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mKc1zS79B3md for <quic-issues@ietfa.amsl.com>; Mon, 22 Oct 2018 22:18:16 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B4F1130E7E for <quic-issues@ietf.org>; Mon, 22 Oct 2018 22:18:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=8kuS9Oqdr2QUnzGnaJoMjFVNeOo=; b=FxXWgOcf4lWHEI9R rIsi1jQY1Pfdztp1jb17RTqBSJ/Vo+cW6j+7flmuKF0CqEfdWkGjCxJkWljQ1lhE kerhYLiICrSH2/1LLXTb3ycH43vsBDOdNbVemUp4D7Z8oX52D6Jf6e4+RY6VK5wd dFNxNFShn+HewWFAFQqesxUgvYU=
Received: by filter0932p1las1.sendgrid.net with SMTP id filter0932p1las1-7719-5BCEAF16-16 2018-10-23 05:18:14.962601511 +0000 UTC m=+366715.503574191
Received: from github-lowworker-dcc078e.cp1-iad.github.net (unknown [192.30.252.44]) by ismtpd0008p1iad2.sendgrid.net (SG) with ESMTP id _8plRRr_QSaoLWnuMDXZqQ for <quic-issues@ietf.org>; Tue, 23 Oct 2018 05:18:14.953 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dcc078e.cp1-iad.github.net (Postfix) with ESMTP id E1A272C123F for <quic-issues@ietf.org>; Mon, 22 Oct 2018 22:18:14 -0700 (PDT)
Date: Tue, 23 Oct 2018 05:18:15 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab416dcdaec05277984e47952e5048cb1438d4d7b392cf0000000117e6711692a169ce16291e9f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1888/review/167217850@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1888@github.com>
References: <quicwg/base-drafts/pull/1888@github.com>
Subject: Re: [quicwg/base-drafts] Consolidate connection ID negotiation section with prior text (#1888)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bceaf16e0248_48193f91dd0d45b82902d0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3MviPbMUONYU2TfRq+nX97FW/rXD8KTr9PNA 1/AJI95Ufh+WbacHTPyDOfvuyqDz5V4mqoUwv3fvyKtEyIu6k3pXyLqBxAhLpsXEwOaVNIfE2xV1eN DR108iIcbnvxf9AYJoEoUYwE7I7e9iP+daieNfk6grsE8niJVkwV9Y2EdrrlObvPIc/2AOOibnBHzR k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uiW-WmE-tVsZP4VjD3bkRqle9Pc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2018 05:18:19 -0000

martinthomson commented on this pull request.



> @@ -926,6 +926,23 @@ them with other connection IDs for the same connection.  As a trivial example,
 this means the same connection ID MUST NOT be issued more than once on the same
 connection.
 
+Packets with long headers include at least two connection IDs, which are used to
+establish the connection IDs that are used for the connection when established,
+see {{negotiating-connection-ids}} for details.

Not at this point in the document; this is too soon for that.  Tweaked.

> @@ -926,6 +926,23 @@ them with other connection IDs for the same connection.  As a trivial example,
 this means the same connection ID MUST NOT be issued more than once on the same
 connection.
 
+Packets with long headers include at least two connection IDs, which are used to
+determine the connection IDs that are used for the connection when established,
+see {{negotiating-connection-ids}} for details.
+
+Packets with short headers ({{short-header}}) only include the Destination
+Connection ID and omit the explicit length.  The length of the Destination
+Connection ID field is expected to be known to endpoints.  Endpoints that use a
+load balancer that routes based on connection ID could agree with the load

It has all the problems already highlighted, plus the precedence of the "or" and "and" toward the end is unclear.  I've tweaked again.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1888#discussion_r227227604