Re: [quicwg/base-drafts] Explicit linkages for ODCID/OCID TP (#3149)

Martin Thomson <notifications@github.com> Tue, 29 October 2019 23:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AA601120137 for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 16:16:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pWOMyWogQBHb for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 16:16:54 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CC39D120119 for <quic-issues@ietf.org>; Tue, 29 Oct 2019 16:16:53 -0700 (PDT)
Date: Tue, 29 Oct 2019 16:16:52 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572391012; bh=IuJnkhG3C6I9U0Nu/JPUFkLCpFMl+QL+gF+e1jv5Pd4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DXZf2cyFaXh3S0BWKjJOkt/kZxQ61tXYvS5+TN7Ab7tTuMWK5wGMLCpPh8oQqFsYg CDXIfwRyrUydrL7UQ5pYcWkjnz5Mhy7Ry3L/TBFZCtVDP6aR30KTJs5F41jZSqX8rP r0dcfDfBzvVDOkeP0Jypy7j8amd6v7lohXX5wD54=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6565BLDI5KGR3I5ON3YX5OJEVBNHHB5BWAMQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3149/review/308889421@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3149@github.com>
References: <quicwg/base-drafts/pull/3149@github.com>
Subject: Re: [quicwg/base-drafts] Explicit linkages for ODCID/OCID TP (#3149)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db8c864e45ed_70eb3fc82a4cd95c736da"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/X8HgTcDd56oUoVUT8Wnu58575z0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 23:16:56 -0000

martinthomson approved this pull request.



> @@ -4412,9 +4412,10 @@ The following transport parameters are defined:
 original_connection_id (0x0000):
 
 : The value of the Destination Connection ID field from the first Initial packet
-  sent by the client.  This transport parameter is only sent by a server.  A
-  server MUST include the original_connection_id transport parameter if it sent
-  a Retry packet.
+  sent by the client.  This transport parameter is only sent by a server.  This
+  is the same value sent in the "Original Destination Connection ID" field of a
+  Retry packet (see {{packet-retry}}).  A server MUST include the

I might have misremembered, sorry.  In #3120, the text I was concerned about was

> If the server sends a Retry packet, it MUST include the Destination Connection ID field from the client's first Initial packet in the transport parameter.

But you didn't touch that. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3149#pullrequestreview-308889421