IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make language in ECN validation clearer (#3777)

Jana Iyengar <notifications@github.com> Tue, 23 June 2020 22:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 412673A0BFD for <quic-issues@ietfa.amsl.com>; Tue, 23 Jun 2020 15:27:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uEL1N-UkexOW for <quic-issues@ietfa.amsl.com>; Tue, 23 Jun 2020 15:27:32 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 135D03A0BFE for <quic-issues@ietf.org>; Tue, 23 Jun 2020 15:27:31 -0700 (PDT)
Received: from github-lowworker-6349a71.ac4-iad.github.net (github-lowworker-6349a71.ac4-iad.github.net [10.52.18.20]) by smtp.github.com (Postfix) with ESMTP id 2B3148C0069 for <quic-issues@ietf.org>; Tue, 23 Jun 2020 15:27:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1592951251; bh=vtxFkp0XtCVIIkFNHwH87pBhHK7dPVR91AJzZJ8QhQk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=y8taMt1pqV9Djbjhebyqt6hAtNENBFB4s9eXNyCuuTZmKo/ZyAXmJ5II2Sv6OP6Ox A1sJfgdLClb0kFeIK43NKZl48CozMj/n6qmG/21MGpFb9UdT5HHGv+PDrkzExBtTVt UX86Y4nRvaFyfSLWZPYrdU79zisDjdIbu+a9uUsQ=
Date: Tue, 23 Jun 2020 15:27:31 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYJL2KXYQRUSVHCFBF47ZRNHEVBNHHCMM6BII@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3777/review/436202859@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3777@github.com>
References: <quicwg/base-drafts/pull/3777@github.com>
Subject: Re: [quicwg/base-drafts] Make language in ECN validation clearer (#3777)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ef281d31b2d9_263f3fd14b2cd95c1452b6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YYHotMFFOwuiPsEMZn6fvylu0GQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jun 2020 22:27:33 -0000

@janaiyengar commented on this pull request.



> +counts therefore validates the counts before using them. An endpoint validates
+these counts by comparing newly received counts against those from the last

```suggestion
counts therefore validates the counts before using them. It performs this
validation by comparing newly received counts against those from the last
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3777#pullrequestreview-436202859

v2.23.0 | Report a Bug | By Email