Re: [quicwg/base-drafts] Fix stale reference and edge case in GOAWAY text (#2634)

ianswett <notifications@github.com> Thu, 18 April 2019 21:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 46CAC1200D7 for <quic-issues@ietfa.amsl.com>; Thu, 18 Apr 2019 14:27:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.383
X-Spam-Level:
X-Spam-Status: No, score=-6.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hi6YukXYJr04 for <quic-issues@ietfa.amsl.com>; Thu, 18 Apr 2019 14:27:42 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AEA7A120046 for <quic-issues@ietf.org>; Thu, 18 Apr 2019 14:27:42 -0700 (PDT)
Date: Thu, 18 Apr 2019 14:27:41 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555622861; bh=N0Cvmi2ZEc7VF6G5y1KzLwZoL1niXeQJE9UFo4Pcpso=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LgAU7LGTz14YhjtMjrkmnWHH4Hv7njOExuL02yNPKiLBcPk5V3qbKBrQqwGBErSQq QncU3JaTelQ8JCuoj8LiDiqUbRYGyYrzwlc+C0U6b2YRj2ouRcj0+CS95ZhmUJTde/ Jw0pwuDh4RR5GrXAngsd0GEoQGi4ZdYoTkwsoNVw=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5CW4ZCCM6MMSXTKKV2YYPE3EVBNHHBT3IA2I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2634/review/228514564@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2634@github.com>
References: <quicwg/base-drafts/pull/2634@github.com>
Subject: Re: [quicwg/base-drafts] Fix stale reference and edge case in GOAWAY text (#2634)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb8ebcd7a1b8_60273ff94d4cd96c5450fc"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_p7DYh_MNiknCAIl1fyq2a-1zA0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Apr 2019 21:27:44 -0000

ianswett approved this pull request.



> @@ -1318,6 +1318,10 @@ connection to become idle, or MAY initiate an immediate closure of the
 connection.  An endpoint that completes a graceful shutdown SHOULD use the
 HTTP_NO_ERROR code when closing the connection.
 
+If a client has consumed all available bidirectional stream IDs with requests,

This is true, but would the HTTP layer know this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2634#pullrequestreview-228514564