Re: [quicwg/base-drafts] Fix stale reference and edge case in GOAWAY text (#2634)

Mike Bishop <> Thu, 18 April 2019 21:41 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 3722112037E for <>; Thu, 18 Apr 2019 14:41:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id IEx4waeu2QDP for <>; Thu, 18 Apr 2019 14:41:36 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 9023C1203F4 for <>; Thu, 18 Apr 2019 14:41:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed;; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=W5vTVcqNxElwRlTekH+rp/ZawFY=; b=LkH+0ON3vlwDMW22 sykZg9YsrlKlDRtmayfz1NsLemUpj1CmeA/Z939U0XtZZ5l3pAP2awIvdzSFFDV+ JiFtmynGOORuhcIuvwvDRiv5N6DxDFs4OjDAhEVqOsWL6e8Mhi1uhi7MTNlWNdUu YtUY6VXi0Jh3ZxkxPzwXJPF6NVk=
Received: by with SMTP id filter0789p1las1-17091-5CB8EF10-4 2019-04-18 21:41:36.089749831 +0000 UTC m=+852659.521661479
Received: from ( []) by (SG) with ESMTP id C_flnJttRsyO6gFIr1eBOA for <>; Thu, 18 Apr 2019 21:41:35.883 +0000 (UTC)
Date: Thu, 18 Apr 2019 21:41:36 +0000
From: Mike Bishop <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2634/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Fix stale reference and edge case in GOAWAY text (#2634)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb8ef0f7fd33_36df3fdbfcacd95c3416a4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1ma6SSRS/s1JhaEGoAgdElu4go9ZKuPVv+ID 26bbWSFAj4lG8dkc4joJ0HaWzTnjSuGgcuwjM2i6L6RNExgWYJOFYpWL4G5g1YaV+iCNbsRw2K7iWF uK6DLmJQMfadD+qBJRS6RpyqqXjcWYcjsEcmL+q3EGBaMTzLWpoHp0OSDwmcq4sfA8/YuhXQcqfgAK A=
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Thu, 18 Apr 2019 21:41:38 -0000

MikeBishop commented on this pull request.

> @@ -1318,6 +1318,10 @@ connection to become idle, or MAY initiate an immediate closure of the
 connection.  An endpoint that completes a graceful shutdown SHOULD use the
 HTTP_NO_ERROR code when closing the connection.
+If a client has consumed all available bidirectional stream IDs with requests,

It has to be tracking the greatest stream ID it has received a request on in order to put that value in a GOAWAY frame.  So, yes.  Another implementation might be to retrieve this number and then find that it's out-of-bounds, but it amounts to the same thing.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: