Re: [quicwg/base-drafts] No longer calculate max_ack_delay in recovery (#1782)
Martin Thomson <notifications@github.com> Fri, 21 September 2018 23:36 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D575C128BAC for <quic-issues@ietfa.amsl.com>; Fri, 21 Sep 2018 16:36:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kd6Y1mCuk1nT for <quic-issues@ietfa.amsl.com>; Fri, 21 Sep 2018 16:36:20 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F12F0130E41 for <quic-issues@ietf.org>; Fri, 21 Sep 2018 16:36:19 -0700 (PDT)
Date: Fri, 21 Sep 2018 16:36:18 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537572978; bh=tqm1D5tTGTDaK/1uVnuG4UTvCvig+Ph7xV5r4q+39Ic=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NfryUKRqBsqvMtnWHxIyLPZL3ceR7SXoCrJEU6QIn3iDG4RmXkLTqxBizWtNvyxuF 9T3NYkKZ5yZKn6Mj9H21cVrV7bgOU3/qM5+moaKPcecomrlv4qKKsGoO/rTFSxkwQM ac93QnVMWDpNndQnLUWceeDSLWmkH81PN68Ig1mc=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5c4bc815ebe9d9b6494bb4f21941409ea5428df392cf0000000117bd427292a169ce1599c7ba@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1782/review/157886782@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1782@github.com>
References: <quicwg/base-drafts/pull/1782@github.com>
Subject: Re: [quicwg/base-drafts] No longer calculate max_ack_delay in recovery (#1782)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba580723543c_19b3ff9cb8d45b4128969"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/boT84UrfNQaKcEvLAPXjzfyekBI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Sep 2018 23:36:23 -0000
martinthomson approved this pull request. I assume that I just haven't seen the transport piece of this yet. > @@ -598,9 +598,10 @@ min_rtt: : The minimum RTT seen in the connection, ignoring ack delay. max_ack_delay: -: The maximum ack delay in an incoming ACK frame for this connection. - Excludes ack delays for non-retransmittable packets and those - that create an RTT sample less than min_rtt. +: The value from the `max_ack_delay` transport parameter, which + indicates the maximum amount of time in milliseconds the receiver the maximum amount of time by which the receiver intends to delay acknowledgments, in milliseconds -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1782#pullrequestreview-157886782
- [quicwg/base-drafts] No longer calculate max_ack_… ianswett
- Re: [quicwg/base-drafts] No longer calculate max_… ianswett
- Re: [quicwg/base-drafts] No longer calculate max_… Nick Banks
- Re: [quicwg/base-drafts] No longer calculate max_… Martin Thomson
- Re: [quicwg/base-drafts] No longer calculate max_… ianswett
- Re: [quicwg/base-drafts] No longer calculate max_… ianswett
- Re: [quicwg/base-drafts] No longer calculate max_… Martin Thomson
- Re: [quicwg/base-drafts] No longer calculate max_… ianswett
- Re: [quicwg/base-drafts] No longer calculate max_… MikkelFJ