Re: [quicwg/base-drafts] Editorial fixes to ECN text (#2189)

Martin Thomson <notifications@github.com> Tue, 18 December 2018 04:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E29A9130E43 for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 20:02:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.459
X-Spam-Level:
X-Spam-Status: No, score=-9.459 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7c08z3BlsccM for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 20:02:41 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE5F0130E3C for <quic-issues@ietf.org>; Mon, 17 Dec 2018 20:02:40 -0800 (PST)
Date: Mon, 17 Dec 2018 20:02:39 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545105759; bh=NS+V//wEvvRZSWFoQL2rZ38MlTErmcWxt/ZyYgvNx30=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bKmGkUpIRf8UcMcGyzirb5hk7bvxLv5jpqQFNwYE4eCd5+avydCV8u2zjRyNXRORx MO86DtpJVehyJHbi60qnfSbKFCbWKS2kjaOryeHTDEiYt4hS63+Db6IGUQihzQ9cB8 yXRox4rQpk+Ih4iBBmU7+CGj8sayv0xjLOOKBB+I=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6f7a152a28b13a47a003da7abb190bf14178c2b092cf000000011830335f92a169ce17535656@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2189/review/185899664@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2189@github.com>
References: <quicwg/base-drafts/pull/2189@github.com>
Subject: Re: [quicwg/base-drafts] Editorial fixes to ECN text (#2189)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c18715f28859_7ac03fa4f6cd45bc12031b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eiGlZUx5xz_WqtIUdBR0vOhaTi0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 04:02:43 -0000

martinthomson commented on this pull request.



> @@ -3031,33 +3031,28 @@ an ACK frame without ECN feedback, the endpoint stops setting ECT codepoints in
 subsequent IP packets, with the expectation that either the network path or the
 peer no longer supports ECN.
 
-To reduce the risk of non-standard compliant ECN markings affecting the
-operation of an endpoint, an endpoint verifies the counts it receives when it
-receives new acknowledgements:
+Network devices that corrupt or apply non-standard ECN markings might result in
+reduced throughput or other undesirable side-effects.  To reduce this risk, an
+endpoint uses the following steps to verify the counts it receives in an ACK
+frame.  Note that the counts MUST NOT be verified if the ACK frame does not

Creating any coupling between frames and packets will be annoying.  We've resisted attempts to do that in the past.

There are two conditions necessary: first that counters never decrease when put in packets with higher numbers, second: that no check is performed if the packet number is lower.  I don't think that we have the first condition either (though it is strongly implied, we don't insist upon it for other frame types).  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2189#discussion_r242400838