Re: [quicwg/base-drafts] Make the ECN requirements match the the discussion in #2156. Fixes #2156 (#2201)

Martin Thomson <notifications@github.com> Tue, 18 December 2018 04:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4C279131026 for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 20:19:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Level:
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YUeU4V49IDdH for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 20:19:11 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 41399130FF9 for <quic-issues@ietf.org>; Mon, 17 Dec 2018 20:19:11 -0800 (PST)
Date: Mon, 17 Dec 2018 20:19:10 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545106750; bh=6b42GBMn8BP2XZrYhdsW8QG4WSq0Ey66iRIAp3Fe6o8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=I43W+6LD81DxMsS+lJdCvXOnlcJuHqyBV7x+mbo8dxJsfhjTsbbm8XVQGt10Fy5jV UG4TgbqPVgsmDzyTPoBzCijxat87IYFN8TR2IaG2cvFeFuIBBGKrEQh5emsK9onHmF 4EkNxug8hybVWVQ30TvH/zttYDC0iT63NG56BR1A=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab00c68d0610888a19be31ceae3fc250ed4d94072c92cf000000011830373e92a169ce175ab940@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2201/review/185901814@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2201@github.com>
References: <quicwg/base-drafts/pull/2201@github.com>
Subject: Re: [quicwg/base-drafts] Make the ECN requirements match the the discussion in #2156. Fixes #2156 (#2201)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c18753e57e8b_611a3f89db6d45bc1444a1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/g3M9Bj5D1o-YVbPYlgr22BxMFq0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 04:19:13 -0000

martinthomson approved this pull request.



> @@ -3014,11 +3016,11 @@ the 1-RTT packet number space will be increased by two.
 
 Each endpoint independently verifies and enables use of ECN by setting the IP
 header ECN codepoint to ECN Capable Transport (ECT) for the path from it to the
-other peer. Even if ECN is not used on the path to the peer, the endpoint MUST
-provide feedback about ECN markings received (if accessible).
+other peer. Even if not setting ECN codepoints on packets it transmits, the
+endpoint MAY provide feedback about ECN markings received (if accessible).

SHOULD?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2201#pullrequestreview-185901814