IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make the ECN requirements match the the discussion in #2156. Fixes #2156 (#2201)

janaiyengar <notifications@github.com> Tue, 18 December 2018 23:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1BF58131243 for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 15:18:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.661
X-Spam-Level:
X-Spam-Status: No, score=-1.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GB_SUMOF=5, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zHKdFiorFFR5 for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 15:18:02 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5DA4D13123A for <quic-issues@ietf.org>; Tue, 18 Dec 2018 15:18:02 -0800 (PST)
Date: Tue, 18 Dec 2018 15:18:01 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545175081; bh=Fs0HXH3VFFCTxPcuvHigpcnKuatJWypiHJh580n9afU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bNAmUCtGPX4eW867KngnWshEzp8mE+5VE/pDHr5IQuT1nqC+gojA88XKFWhsu+r28 xowMi5K1pU2fe+B0qRGVkur9m1HzuDlcAjgyuSyz1GDRwFTGR4U9ehkZznX7Z5dI+r v+jq9yB8sagpAYwQVJdZgj+ekwHxKrg2mlylldWY=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd910316d4d279e02e5126f98c6cae0fb8efea0e992cf000000011831422992a169ce175ab940@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2201/review/186327581@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2201@github.com>
References: <quicwg/base-drafts/pull/2201@github.com>
Subject: Re: [quicwg/base-drafts] Make the ECN requirements match the the discussion in #2156. Fixes #2156 (#2201)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1980294fa27_63903fc4818d45c01570b3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OZE1RqZD3_GdI0nd0ltOse8SHcI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 23:18:04 -0000

janaiyengar commented on this pull request.



> @@ -4133,7 +4135,9 @@ Receivers send ACK frames (types 0x02 and 0x03) to inform senders of packets
 they have received and processed. The ACK frame contains one or more ACK Blocks.
 ACK Blocks are ranges of acknowledged packets. If the frame type is 0x03, ACK
 frames also contain the sum of QUIC packets with associated ECN marks received
-on the connection up until this point.
+on the connection up until this point. QUIC implementations MUST properly handle
+both types 0x02 and 0x03 and if they have enabled ECN for packets they send,

```suggestion
 both types 0x02 and 0x03, and if they have enabled ECN for packets they send,
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2201#pullrequestreview-186327581

v2.23.0 | Report a Bug | By Email