IETF Logo Mail Archive

Re: [quicwg/base-drafts] Reorganize ACK section (#2197)

ianswett <notifications@github.com> Tue, 18 December 2018 23:20 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5C0CF13124D for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 15:20:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.064
X-Spam-Level:
X-Spam-Status: No, score=-3.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q-tzZrp_eSmM for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 15:20:16 -0800 (PST)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D9F7D131256 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 15:20:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=xE9pGGJLuXIBTc3amds0NxS+stc=; b=iZ3BJtQwfAQIeY5h e0WCtZAJg8Z9ETERLwoV1G/zinQuEwjBZboeGxnU6GpKqKiufZDKCQ/ydPZPDUWH 0xWpfXJYsMlPvveuSRlwCBqhOnTp0gfOa9yvkGsQ4G1iZNaXVG34oqPQq0WJ/waJ hct46k6dXUI9hCnd6t3pIEIjcMw=
Received: by filter0624p1iad2.sendgrid.net with SMTP id filter0624p1iad2-31456-5C1980AC-1A 2018-12-18 23:20:12.722782636 +0000 UTC m=+104378.194525245
Received: from github-lowworker-0b1e58d.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0030p1iad2.sendgrid.net (SG) with ESMTP id QcbWmJbdS92Uo0z-8O8sAQ for <quic-issues@ietf.org>; Tue, 18 Dec 2018 23:20:12.873 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-0b1e58d.cp1-iad.github.net (Postfix) with ESMTP id C40D93E0969 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 15:20:12 -0800 (PST)
Date: Tue, 18 Dec 2018 23:20:12 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abec067d84a991f02c6809a227bd2ed4e9312b068692cf00000001183142ac92a169ce17565ed9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2197/review/186328191@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2197@github.com>
References: <quicwg/base-drafts/pull/2197@github.com>
Subject: Re: [quicwg/base-drafts] Reorganize ACK section (#2197)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1980acc2be3_6e133fd00ccd45bc181074"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0ws15+UBedRsQghtutyg8k3/NdxemqjU2vUm GvOJeCAtexwIgFavR0dbUWwYCOhT8RISu9N2K66kQQj5Bwc4ArdCCwLWBhqenfAo7ZNvMkN4hzM7a4 ya4SSkxghCnrbyN2F8KDq3i50io8P+H8l6dneSGzsCaVurqTFXQhEkz8ZpKJSu+8nGJWs9MpNTWzfR k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8QfIhT8XgnTvGLdtvg3qTc_k9To>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 23:20:20 -0000

ianswett commented on this pull request.



> @@ -2841,23 +2841,24 @@ needing acknowledgement are received.  The sender can use the receiver's
 Strategies and implications of the frequency of generating acknowledgments are
 discussed in more detail in {{QUIC-RECOVERY}}.
 
-To limit ACK Blocks to those that have not yet been received by the sender, the
-receiver SHOULD track which ACK frames have been acknowledged by its peer.  Once
-an ACK frame has been acknowledged, the packets it acknowledges SHOULD NOT be
-acknowledged again.
+To limit the ranges of acknowledged packet numbers to those that have not yet
+been received by the sender, the receiver SHOULD track which ACK frames have
+been acknowledged by its peer.  Once an ACK frame has been acknowledged, the
+packets it acknowledges SHOULD NOT be acknowledged again.

+1 to Christian's suggestion or something along those lines.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2197#discussion_r242742439

v2.23.0 | Report a Bug | By Email