Re: [quicwg/base-drafts] Reorganize ACK section (#2197)

MikkelFJ <notifications@github.com> Tue, 18 December 2018 23:52 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF2E6131218 for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 15:52:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.064
X-Spam-Level:
X-Spam-Status: No, score=-3.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h37TVGvf_viq for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 15:52:14 -0800 (PST)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E5E761311F4 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 15:52:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=T6tovtPyzX8QfxMFxYmubKerAv0=; b=JwalU91Tj6ga13kT PkVjPf6ZjjoeCVoyCoVUywc0fVf8npKm62e2Tl/HCeigtemoZqtDtxd038v6S9fM RmFDisYOYlartVSOZQ/sM+EkZBqkAUEjQwgr6l6//MECiuYTEYcVRGMO3hvNQAPf zNvvZnjd9lfRmum3PIBNslP8K+Q=
Received: by filter0479p1iad2.sendgrid.net with SMTP id filter0479p1iad2-20093-5C198829-27 2018-12-18 23:52:09.604978112 +0000 UTC m=+106261.067406477
Received: from github-lowworker-fc273f0.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0021p1iad2.sendgrid.net (SG) with ESMTP id aY2UCjXYRX64Qcu4Z4SGyQ for <quic-issues@ietf.org>; Tue, 18 Dec 2018 23:52:09.669 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-fc273f0.cp1-iad.github.net (Postfix) with ESMTP id 956CCC12E2 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 15:52:09 -0800 (PST)
Date: Tue, 18 Dec 2018 23:52:09 +0000
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9c1cb1445c02aa8717ed2a8d1ae2817bf496dfd992cf0000000118314a2992a169ce17565ed9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2197/review/186335843@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2197@github.com>
References: <quicwg/base-drafts/pull/2197@github.com>
Subject: Re: [quicwg/base-drafts] Reorganize ACK section (#2197)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c198829929c6_3ff83fb6cdcd45c4979b9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3ewb55PzP72/OcVeJV2M9bNz4Sav80PYGeJu TlB234y/VIpxyC4exfsTFwgLzS9ryRiX2UUyLotz5CTWOKOwzIks6oLMZ6mUYxKTrmQvOJEvP//Vjj cn/iMtqQeAtFxb7bgUxIEzCByDCUYM/vaHXe+joFnBm4nP5bL810aH+2hPZlbWbJaeYd4RpXrHpYG4 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zT_619U1OVeazJd3O0YcnyiRJ9M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 23:52:16 -0000

mikkelfj commented on this pull request.



> @@ -2841,23 +2841,24 @@ needing acknowledgement are received.  The sender can use the receiver's
 Strategies and implications of the frequency of generating acknowledgments are
 discussed in more detail in {{QUIC-RECOVERY}}.
 
-To limit ACK Blocks to those that have not yet been received by the sender, the
-receiver SHOULD track which ACK frames have been acknowledged by its peer.  Once
-an ACK frame has been acknowledged, the packets it acknowledges SHOULD NOT be
-acknowledged again.
+To limit the ranges of acknowledged packet numbers to those that have not yet
+been received by the sender, the receiver SHOULD track which ACK frames have
+been acknowledged by its peer.  Once an ACK frame has been acknowledged, the
+packets it acknowledges SHOULD NOT be acknowledged again.

... Once an ACK frame has been acknowledged, it is RECOMMENDED to not repeat acknowledgement of the same packets whenever this can reduce the overall size of the next ACK frame.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2197#discussion_r242748854