IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make the ECN requirements match the the discussion in #2156. Fixes #2156 (#2201)

ianswett <notifications@github.com> Tue, 18 December 2018 15:18 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3696A12894E for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 07:18:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.439
X-Spam-Level:
X-Spam-Status: No, score=-0.439 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=0.726, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5_juJXPORMsX for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 07:18:15 -0800 (PST)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EC4F5127AC2 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 07:18:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=f9+Tkizta4J4SxZ6QDoQuzcZQz8=; b=ozUDVcCkr7uqkxad oYXFmNFL9VIKC4L9+OPRUFhJeBJvhKlKO8wVPIYm2EE2QVQmFvhP/GRw0+E2SyAd 7J4kCD556GuMDU5exSdMD46ZLuJkDPC9UGeVuqMfkVERdUGx/hYsmyr7JbN14UnY rpcEwSaORMkycDBLruAmh+x/hSo=
Received: by filter1495p1mdw1.sendgrid.net with SMTP id filter1495p1mdw1-20990-5C190F35-3C 2018-12-18 15:16:05.887646567 +0000 UTC m=+413034.777094442
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) by ismtpd0010p1sjc2.sendgrid.net (SG) with ESMTP id ZohxMzbTTvyY5S1_JkY2Kw for <quic-issues@ietf.org>; Tue, 18 Dec 2018 15:16:05.804 +0000 (UTC)
Date: Tue, 18 Dec 2018 15:16:06 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab73c8288f9d6f93c7ffd674ec4c849ae743f5c65892cf000000011830d13592a169ce175ab940@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2201/review/186118275@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2201@github.com>
References: <quicwg/base-drafts/pull/2201@github.com>
Subject: Re: [quicwg/base-drafts] Make the ECN requirements match the the discussion in #2156. Fixes #2156 (#2201)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c190f352ff43_76503fb746cd45b41540b3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0icZDKfAs+7MvGOAZPA+pRNCD7KFMhqI0NyT gTwL+Fp2p4Q/+S0Bw08oE7NYDJPFZ9NkVbRQdUMOI3K3QmA8yLjyFh8xiviGUVxnxe6KaRWEdHtB4i zRZ6mr3tmZh2DRBCJLWrB77uDFCyEtjRkk2/80gMdoyXke0oFxcDEIXOXlWaxufv+Zw7vylAhqGmdQ 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/gzjc23rE_HliZQgiGHqJRv_o2SE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 15:18:18 -0000

ianswett commented on this pull request.

LG, minus one MAY/SHOULD

> @@ -3014,11 +3016,11 @@ the 1-RTT packet number space will be increased by two.
 
 Each endpoint independently verifies and enables use of ECN by setting the IP
 header ECN codepoint to ECN Capable Transport (ECT) for the path from it to the
-other peer. Even if ECN is not used on the path to the peer, the endpoint MUST
-provide feedback about ECN markings received (if accessible).
+other peer. Even if not setting ECN codepoints on packets it transmits, the
+endpoint MAY provide feedback about ECN markings received (if accessible).

SHOULD SGTM.

Also, can you remove the parens around if accessible?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2201#pullrequestreview-186118275

v2.23.0 | Report a Bug | By Email