Re: [quicwg/base-drafts] Migration in Security Considerations (#2427)

Mike Bishop <notifications@github.com> Thu, 07 February 2019 18:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A4814129B88 for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 10:26:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.819
X-Spam-Level:
X-Spam-Status: No, score=-4.819 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.282, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vMj8WP5HOZx0 for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 10:26:55 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 68E8012958B for <quic-issues@ietf.org>; Thu, 7 Feb 2019 10:26:54 -0800 (PST)
Date: Thu, 07 Feb 2019 10:26:53 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549564013; bh=7wn0ZrDBF7V8xmnSDDjgQVY0W6aShjURjNzy4rkXSYU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Y+KlWOYH2lqLgz/tOkroZxTssEVM4MW4HeludFyMcrCoItTfMIZFw2BhGCAMoDQYu RXjoSanW4xR3dssPecr8/pK9SngyLvGtF4fJqIBqMTSMaQtHDKdiQOqAki/MXdb3lB +AYP2ngxlAYFKXdMwrtObzsdlGCF2Li+T5Qe1WU8=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab341d665dbce7bacf6089a82537c8e73dcede4c9692cf0000000118743a6d92a169ce1842e6ac@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2427/review/201250027@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2427@github.com>
References: <quicwg/base-drafts/pull/2427@github.com>
Subject: Re: [quicwg/base-drafts] Migration in Security Considerations (#2427)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5c786d64bee_631a3fd1e32d45c0718214"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/k4tVWECEzJoOgbFz7P39bv1iLe0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 18:26:57 -0000

MikeBishop commented on this pull request.



> @@ -1463,6 +1463,13 @@ could pose a security risk to an incautious implementer.  An implementation MUST
 ensure that the length of a frame exactly matches the length of the fields it
 contains.
 
+Certain HTTP implementations use the client address for logging or

Yes, but I think I'd rather do that as a separate organization PR and keep this one focused on this issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2427#discussion_r254810977