Re: [quicwg/base-drafts] Define AreAllPacketsLost() (#3290)

Alessandro Ghedini <notifications@github.com> Tue, 14 January 2020 15:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B7E39120127 for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 07:29:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0hhNzqgDzUVo for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 07:29:01 -0800 (PST)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D686F12011A for <quic-issues@ietf.org>; Tue, 14 Jan 2020 07:29:00 -0800 (PST)
Date: Tue, 14 Jan 2020 07:29:00 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579015740; bh=prwknyVqHs1rKsuWcFb2BZMp9p3BNb3Gcy9uFJM3awc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LD/yvdxAAJ4MQlgFsdfO2H+suvpbwPaAj9kjwSNmG18IzX8j108a5r7ihDceYtlj8 nctKU/UrAiSc9MHC+eRvAXrkgIRgmUaOvb8315f46sTbiQDI3SPfmTOJVsO35wSYmx O1z2ywDKC8Moaey/HRAUgb+xOUdXXqoibrH6cFn0=
From: Alessandro Ghedini <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4NIRWQ256SE2WC5354FMILZEVBNHHB7VVU2M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3290/review/342618805@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3290@github.com>
References: <quicwg/base-drafts/pull/3290@github.com>
Subject: Re: [quicwg/base-drafts] Define AreAllPacketsLost() (#3290)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1dde3c15a23_7b873fbd268cd96c215226"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ghedo
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/oJuXZRC9oLB9I5g6iiGvLfnAHU4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jan 2020 15:29:08 -0000

ghedo commented on this pull request.



> +     all_packets_lost =
+       lost_packets.length() == (lost_packets.last().packet_number -
+                                 lost_packets.first().packet_number + 1)

Yeah, I can do that, just need to find some time :) Will close this PR in the meantime.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3290#discussion_r366404003