IETF Logo Mail Archive

Re: [quicwg/base-drafts] Update ACK generation policy (#3501)

MikkelFJ <notifications@github.com> Wed, 11 March 2020 17:23 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A3A903A0EC3 for <quic-issues@ietfa.amsl.com>; Wed, 11 Mar 2020 10:23:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.945
X-Spam-Level:
X-Spam-Status: No, score=-2.945 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-1.463, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cL9gkSk-cSQU for <quic-issues@ietfa.amsl.com>; Wed, 11 Mar 2020 10:23:46 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5855B3A0EC0 for <quic-issues@ietf.org>; Wed, 11 Mar 2020 10:23:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=j5mQ2BSE5TNB/Hp7X/8jiU5ko6WsqOC0qPo8Hm3r53Q=; b= mnMgBJ6NPSE80VN3/CFShXMshQUPSVop11K4Bn8Abwuqy1dJPOKLhHDnoMpe2O6U zPXeF7CWXyOlltgY5lDQsGEpNTaaCLucxYKCjK9q9ixsZTMOU/nRnpJieG1f0tib fPgIjCzAhjDq+DwS6I8Boums9UpWcM8ZFhy0yM4PuZA=
Received: by filter1487p1las1.sendgrid.net with SMTP id filter1487p1las1-29278-5E691E9F-21 2020-03-11 17:23:43.801575402 +0000 UTC m=+68031.572026291
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [140.82.115.5]) by ismtpd0046p1iad1.sendgrid.net (SG) with ESMTP id HWk3qH_VR-iABf06LXvB4w for <quic-issues@ietf.org>; Wed, 11 Mar 2020 17:23:43.662 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id 8256480C4E for <quic-issues@ietf.org>; Wed, 11 Mar 2020 10:23:43 -0700 (PDT)
Date: Wed, 11 Mar 2020 17:23:44 +0000
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5V5RYFP3DQDLHKVYN4OT7Z7EVBNHHCEV4TFI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3501/review/372970067@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3501@github.com>
References: <quicwg/base-drafts/pull/3501@github.com>
Subject: Re: [quicwg/base-drafts] Update ACK generation policy (#3501)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e691e9f802ad_41793f96f98cd9601372ba"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3RMLtTFJzfDQSKF36s8PtLX57rxmBn6j2dWT FgNy3inVTFn1HkcNUCef8GB/fUnbbnhfSBZgYn/ooauRWSVmaVeUNmJQAONNPubqsoonjCsmhBMLFN 80oXFKs4mbLohZ+u8qElTZ2oAYdBg+ZVJ5yrv6RY4nqVUV2Fj6whrZZiVZo+5Vjvdnj50UBVEr1G/K I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pBO5l4znxRGd_PMJ4DcEWHdER5Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2020 17:23:48 -0000

mikkelfj commented on this pull request.



>  
-An ACK frame SHOULD be generated for at least every second ack-eliciting packet.
-This recommendation is in keeping with standard practice for TCP {{?RFC5681}}.
+A QUIC receiver can generate one ACK frame for every received
+ack-eliciting packet.  TCP recommends
+that a receiver generates an ACK corresponding to every second MSS of
+received data, Section 4.2 of {{?RFC5681}}, however {{?RFC3449}} also
+notes the need for, and deployment of, methods to further
+reduce the number of TCP ACKs in networks with asymmetric paths.

I find this TCP discussion a bit confusing when trying to state a clear algorithm recommendation for QUIC. Can it be moved to a "compared to TCP" section?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3501#pullrequestreview-372970067

v2.23.0 | Report a Bug | By Email