Re: [quicwg/base-drafts] Don't specify RTT in HTTP (#3358)

Mike Bishop <notifications@github.com> Mon, 20 January 2020 19:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6A9B91207FE for <quic-issues@ietfa.amsl.com>; Mon, 20 Jan 2020 11:46:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uBuGIIG5CwYu for <quic-issues@ietfa.amsl.com>; Mon, 20 Jan 2020 11:46:41 -0800 (PST)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C28FA1200C4 for <quic-issues@ietf.org>; Mon, 20 Jan 2020 11:46:40 -0800 (PST)
Date: Mon, 20 Jan 2020 11:46:39 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579549599; bh=A9zuIEHm6PyQ5mlT9QSEa+B55rcThyAjFfUgoL4DDpU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TxiRcUp3b6fKPVk0PGhHe3DFYJxB+BnngSP/ew1c6MsBQCShUZCxgFvbNBD1acnlH 4fBofhmIUTPvTFPXoz+BakKzh3htD/L+xocuRu/FOlamZYeviHDl4UJue4QjXWCa+X OENwanw7d3KnqgKyNn3t1sBnjr2rFY4+/GXyUicU=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4KJ5UCDHNOVGDB75N4GM3B7EVBNHHCBYIASU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3358/review/345505847@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3358@github.com>
References: <quicwg/base-drafts/pull/3358@github.com>
Subject: Re: [quicwg/base-drafts] Don't specify RTT in HTTP (#3358)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e26039fe3795_57893fabd0ccd95c194191"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qVE2AcynIjvKGCova5ZP2yQ8RFQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jan 2020 19:46:48 -0000

MikeBishop commented on this pull request.



> @@ -732,9 +732,10 @@ initial GOAWAY frame with the last Stream ID set to the maximum possible value
 for a client-initiated, bidirectional stream (i.e. 2^62-4 in case of QUIC
 version 1).  This GOAWAY frame signals to the client that shutdown is imminent
 and that initiating further requests is prohibited.  After allowing time for any
-in-flight requests (at least one round-trip time), the server would send another
-GOAWAY frame with an updated last Stream ID.  This ensures that a connection can
-be cleanly shut down without causing requests to fail.
+in-flight requests to reach the server, the server MAY send another GOAWAY frame
+indicating which requests it will accept before the end of the connection. This

Perhaps, but "can" is used other places through this description.  Unless we rewrite the whole thing to be can-free, I'm choosing consistency.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3358#discussion_r368704088