IETF Logo Mail Archive

Re: [quicwg/base-drafts] Adjust autotuning recommendations (#2240)

janaiyengar <notifications@github.com> Fri, 04 January 2019 04:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 433DE130F0B for <quic-issues@ietfa.amsl.com>; Thu, 3 Jan 2019 20:10:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m5HfLk9CYjRD for <quic-issues@ietfa.amsl.com>; Thu, 3 Jan 2019 20:10:28 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4E60130E3F for <quic-issues@ietf.org>; Thu, 3 Jan 2019 20:10:27 -0800 (PST)
Date: Thu, 03 Jan 2019 20:10:27 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546575027; bh=qY+mdYatOzhLD7Jp1oxlwAVqJ9huZ8QMmnOPBVWlZEQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cKM6U3AazqTJCDTDDAJWcqg2Aw3KHwKStmkLtZp4dIO4oZEEnENQW7c+pbfs+UC9L kn6JKUKqo2u7G8E1NJCJPFeqdyzOSdumpNSYo/RVAs9XfOqCbPUoAICAp5u87rZkN2 3wPyFKntdDCN1bqFHi0qKHHZxOtM0gAc6TYRMAAs=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf26360e44574e3b94ce60a95169a5083b7aaf61e92cf0000000118469eb292a169ce17718705@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2240/review/189259280@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2240@github.com>
References: <quicwg/base-drafts/pull/2240@github.com>
Subject: Re: [quicwg/base-drafts] Adjust autotuning recommendations (#2240)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c2edcb3d21_7f003ff629ad45bc3745d4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/tMVojHYHQOVQIOpFBElEUf50Jjg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2019 04:10:29 -0000

janaiyengar commented on this pull request.



>  advertised additional credit based on a round-trip time estimate and the rate at
 which the receiving application consumes data, similar to common TCP
-implementations.
+implementations.  Sending frames related to flow control only when there are
+other frames to send or when a peer is blocked ensures that flow control doesn't

Suggestion: "As an optimization, sending frames ..."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2240#discussion_r245200338

v2.23.0 | Report a Bug | By Email