Re: [quicwg/base-drafts] ack-eliciting not ACK-eliciting (#3069)

Martin Thomson <notifications@github.com> Wed, 25 September 2019 21:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F2E2712004E for <quic-issues@ietfa.amsl.com>; Wed, 25 Sep 2019 14:46:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xmm6s2_5uJ1g for <quic-issues@ietfa.amsl.com>; Wed, 25 Sep 2019 14:46:03 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 39676120018 for <quic-issues@ietf.org>; Wed, 25 Sep 2019 14:46:03 -0700 (PDT)
Date: Wed, 25 Sep 2019 14:46:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1569447962; bh=Yixfon38unqGwm4MUU0/3AIuc0kxGhBPYap7pwy0ysw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=BnnU6flMGG11onCBBbMMdPLzHF36BkdM/wF7oxF2hkTP8Z31J3ZH7s9e8v5S05iCX 3sVAhESXjIcll7S45p7BACj+ImkyC6Iex9SGgi1kuXZmKFRGIHrSGFuhMr5tesgXPE GzDTiis8Kvd0DFdk7ZHc03msNoSdtjPm2V6PiPLY=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3XZY3J56JF4EYVGNV3TECIVEVBNHHB3NCBX4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3069/review/293382727@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3069@github.com>
References: <quicwg/base-drafts/pull/3069@github.com>
Subject: Re: [quicwg/base-drafts] ack-eliciting not ACK-eliciting (#3069)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d8be01a4af6d_115b3f7e474cd95c1835c0"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/u4brD9OCKP_SljYwuatEPHk4onQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Sep 2019 21:46:05 -0000

martinthomson approved this pull request.

With a tweak.

> @@ -190,6 +190,11 @@ QUIC packet:
 : A complete processable unit of QUIC that can be encapsulated in a UDP
   datagram.  Multiple QUIC packets can be encapsulated in a single UDP datagram.
 
+Ack-eliciting Packet:
+
+: A QUIC packet that contain frames other than ACK and PADDING elicits an ACK

```suggestion
: A QUIC packet that contains frames other than ACK and PADDING. These cause a recipient
   to send an acknowledgment within the maximum ack delay.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3069#pullrequestreview-293382727