Re: [quicwg/base-drafts] OnPacketsLost for Nonretransmittable Packets (#2015)

Marten Seemann <notifications@github.com> Sat, 24 November 2018 03:55 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8924A130EE1 for <quic-issues@ietfa.amsl.com>; Fri, 23 Nov 2018 19:55:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZabwCAXNCmzJ for <quic-issues@ietfa.amsl.com>; Fri, 23 Nov 2018 19:55:33 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 06591130DDF for <quic-issues@ietf.org>; Fri, 23 Nov 2018 19:55:33 -0800 (PST)
Date: Fri, 23 Nov 2018 19:55:31 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543031731; bh=h/vys+Qn+cZKVQJwX2pteXJyf00KpnM6BXGzKBpIFp8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=AqXt97gELqgo5q+/LMw3jVH1fOTDNjOM1rBoF3nxMrms2tm6eahaRHT6HzjBk6AFN MtoT3WuuZOHBtI3BrRerk/ECCTXRlCsdTU6LWeVWzt+EGv9y5KyQk1zK8PlCbXe4FE PLRqYPNpKr4LCCMJ2YK09SHx2bbwh2aFM+KHGDHY=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab718ff20e7a52a9039c6914836d47f7b7c57becc192cf0000000118108db392a169ce16c13e3b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2015/441341563@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2015@github.com>
References: <quicwg/base-drafts/issues/2015@github.com>
Subject: Re: [quicwg/base-drafts] OnPacketsLost for Nonretransmittable Packets (#2015)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf8cbb3de737_67d33fbd29ed45c4412fb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/um3WMFgs95GXCLGDPbVpYShYjk8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Nov 2018 03:55:35 -0000

I agree with @pravb here, we should recommend that ACKs should always be piggybacked, unless there is no data sent. For me, this seemed to be the fix for #1977, otherwise you're just cheating your own congestion controller and sending more data into the network than your cwnd allows.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2015#issuecomment-441341563