Re: [quicwg/base-drafts] Replace remove() with setting to null (#2987)
MikkelFJ <notifications@github.com> Mon, 26 August 2019 06:56 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 75EEA120827 for <quic-issues@ietfa.amsl.com>; Sun, 25 Aug 2019 23:56:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 125s8ROTR3Ec for <quic-issues@ietfa.amsl.com>; Sun, 25 Aug 2019 23:56:48 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C5F46120824 for <quic-issues@ietf.org>; Sun, 25 Aug 2019 23:56:47 -0700 (PDT)
Date: Sun, 25 Aug 2019 23:56:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566802606; bh=VYCnpcTKEJUf6D5Snbfv20nknJwhw1cgEMkiwJouH0c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ryjom2DEkYG855QawHy5M923i4ItcNj3KHJFLU1XdHAtCTOZ3xC5ValUJMI5f7QZg xPPN8LKs6uN5fpgBICxouxh27+RKS1nFORZ2HrMGNhl3Fsq9fSLIitY8g2Ea8wW+fF Z4ppNuJcUv0inARPj9AEmwKygR5YPpTkWPonuRek=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4FT4IKOVVUNRFD4T53OC2S5EVBNHHBZYSIIE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2987/c524741093@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2987@github.com>
References: <quicwg/base-drafts/pull/2987@github.com>
Subject: Re: [quicwg/base-drafts] Replace remove() with setting to null (#2987)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d6382aee2459_473e3fe89f6cd960326386a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/w8RBr2nVJ6pBSaPuyEjYXJeVzz8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Aug 2019 06:56:50 -0000
It's a matter of taste, but I don't really like setting values to null when null is not defined value in a set. Removing something from a set is mathematically well defined. That Javascript happens to be weird doesn't have to affect a specification. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2987#issuecomment-524741093
- [quicwg/base-drafts] Replace remove() with settin… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… Martin Thomson
- Re: [quicwg/base-drafts] Replace remove() with se… Martin Thomson
- Re: [quicwg/base-drafts] Replace remove() with se… MikkelFJ
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… Martin Thomson
- Re: [quicwg/base-drafts] Replace remove() with se… MikkelFJ
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… Jana Iyengar
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett