IETF Logo Mail Archive

Re: nits in draft-ietf-quic-recovery-05

Jana Iyengar <jri@google.com> Mon, 11 September 2017 18:45 UTC

Return-Path: <jri@google.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 838B4132697 for <quic@ietfa.amsl.com>; Mon, 11 Sep 2017 11:45:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XQYGNyJ4LZy6 for <quic@ietfa.amsl.com>; Mon, 11 Sep 2017 11:44:59 -0700 (PDT)
Received: from mail-pg0-x22b.google.com (mail-pg0-x22b.google.com [IPv6:2607:f8b0:400e:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9712132ECF for <quic@ietf.org>; Mon, 11 Sep 2017 11:44:57 -0700 (PDT)
Received: by mail-pg0-x22b.google.com with SMTP id v66so16789783pgb.5 for <quic@ietf.org>; Mon, 11 Sep 2017 11:44:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lnFYfsq0pGr9rCZI6UrSkFjusAf0HtUZOQFmg4IQq68=; b=OwWMa5v0gwtlrsnTKt2fpPk1v6veyNPR25hR8Wn9qS+3WiVMaiFillZ//i9QZs8Qkq cB4Gb2Jwcp5uQcmREf7xWls0h4MqVX7UV8fjZ42lC5Zi8GPLvUyTewWiym/MV9SCwTKQ 18bc+NbfYUkGdBSNNOpSqF73/ESw7ghegUN1x3mi+5OUOUFaJU0dLbu4Q4hTBTJPicCH rv82QXQPp5OEZ62RZfSLyD/1itnok65jj5M7EUVa1wnvLuJpnxBIukTOnDCf5wPGRs2w HgnvLA/szy7uU7dRV8aSq9VI+jGyuL6jJjZq5qbkgUfiFZqEoJgCTaRMw12PakoPUtEx 222A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lnFYfsq0pGr9rCZI6UrSkFjusAf0HtUZOQFmg4IQq68=; b=bJ09c6fxAjPawFGgrdvctlH8cQPboMfAyBJM4PC8XWTFV3bX8MF3Oi+JrNHGDMqFCu n3XRxw7/QJgyw/bmYAnhQPK7kYHdkzA7ka5pC0/8M/VhLZ5x1p7HNtZ7V40TuaGOnUe1 5RQHOsMdI79UvhaP9k/KAG6FqkctuB5OwS9XipKx2do3ojmFqUjcrr//nsX9wBlYVHpa qPWsSjU6tQxbLE5WeExyMZZeE5ap9MZdFEndfY4OOUUNolbFw4+Wq1wY/8eqc/AK7NXO IFcuMkLHcQ+D2sjUKsuxD8Q8hdjqApOCd350rHNTZ/W/+XtcNm+r+aDMCNAvVp7SVbJk WBPQ==
X-Gm-Message-State: AHPjjUhQtCq86fj8CbAqhWd83yKNUyCgKEUF3/e5tNAnrZJzT1M6dh4h do8rR0Gx/Xdm+SGaxBOTqslE2TU+z7yP
X-Google-Smtp-Source: ADKCNb7gC2XW2ovvRHKEpa+Jm22YgPcxsJf4T25HBARadz/ByGxgiz7FneJGGydr11NA/56FekifPzFXgNBIS6RAoWc=
X-Received: by 10.84.211.39 with SMTP id b36mr2196087pli.330.1505155497019; Mon, 11 Sep 2017 11:44:57 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.100.145.144 with HTTP; Mon, 11 Sep 2017 11:44:56 -0700 (PDT)
In-Reply-To: <6E58094ECC8D8344914996DAD28F1CCD8025EC@DGGEMM506-MBX.china.huawei.com>
References: <6E58094ECC8D8344914996DAD28F1CCD8025EC@DGGEMM506-MBX.china.huawei.com>
From: Jana Iyengar <jri@google.com>
Date: Mon, 11 Sep 2017 11:44:56 -0700
Message-ID: <CAGD1bZYEaFLZ-tmOzQgDEzaQ69qVE7odQuO0SUHp7amm+pBx_A@mail.gmail.com>
Subject: Re: nits in draft-ietf-quic-recovery-05
To: Roni Even <roni.even@huawei.com>
Cc: QUIC WG <quic@ietf.org>
Content-Type: multipart/alternative; boundary="94eb2c093b26bbb3b70558ee5277"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/RZEEjW6bHBETisYVxmbJEgbvYds>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2017 18:45:01 -0000

Hi Roni,

Thanks for your careful read of the draft!

> In section 3.1 the bullet before the last one “a QUIC sender marks a
> packet as lost when a packet larger than it is acknowledged” should be
> “with higher packet number” instead of “larger”?
>
We've consistently used "larger" packet number, so I'm inclined to stick
with that, even if "higher" is slightly more correct?

In section 3.2.7.4 “if (retransmittable_packets_outstanding = 1):”   should
> be “==” instead of “=”?
>
I'll fix this.

Thanks!
- jana

v2.23.0 | Report a Bug | By Email