Re: nits in draft-ietf-quic-recovery-05

Matthew Kerwin <matthew@kerwin.net.au> Mon, 11 September 2017 21:30 UTC

Return-Path: <phluid61@gmail.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 489E9132F61 for <quic@ietfa.amsl.com>; Mon, 11 Sep 2017 14:30:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.149
X-Spam-Level:
X-Spam-Status: No, score=-2.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.199, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DjhUvmKh3MlM for <quic@ietfa.amsl.com>; Mon, 11 Sep 2017 14:30:44 -0700 (PDT)
Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C6FDB132D6A for <quic@ietf.org>; Mon, 11 Sep 2017 14:30:44 -0700 (PDT)
Received: by mail-io0-x22f.google.com with SMTP id v36so22428390ioi.1 for <quic@ietf.org>; Mon, 11 Sep 2017 14:30:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=RIeYqxvLO56x7K3xvB0+SNYj/YM9mI3DOmw0Q2QVqe4=; b=fRQlbkNll2MxDLXVS5Ypa+gimH0sQKt47Zg0MUklCs1XvL6sE0xhz1S68SwXy73IiE PWl71touftVaCCgZQ950oyCXrQ8UytqohWWoKSjNsIt/ErRyRdYNbp5N7m/9P1p6kLnC ChZ7YP5o6Gao8vz4CHGdACIXHCwUq5KsiNOkEiQCBo3A1eqj/UWo3HS9KaIKMqWvWx14 JSUdr0I3fXU5kHEmQPz6xuFPSJAAX7pswr63RU7vagDSKO5NFsSI+BaWkzk3MxeeNueT lAe40xcUdLEA/McHZOSDYvsU8ZisQH19dcbVxRMiRpCGGGUihrHuseTdiylXiCwRljy0 9Ijw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=RIeYqxvLO56x7K3xvB0+SNYj/YM9mI3DOmw0Q2QVqe4=; b=YrXFYwpG3VqMmkMhNUqWCkhUk2F9Gw9O5VIkYdPgJHvGhB5mif/V5gmu12bjBC8Eku uNHUhD/BQO9oxYstapUviCVHKhgDku7xjnkmDwZF2/J0bGEW3oRS4HRvRNeyQMwsvlb+ niHUC/ITedG5NbCqdsZWJJ/fIeZt2LRHMe8dOgW7nnkN52QBJq20/u8VYjyXCbnHTT0C yu36xLW7tRVLTwGqtJ+0hZeoUryUlUAdcu/h1YNGDTynxbU2Mm4oUnFqDQ0obLbY8A5g xCX4IiMbI7nSxYdMPLUZNM1JO5LPYvhuPHZZfS68BvUmVLHRmEyUjCw4cFZnANgJ+EMm 5Lvw==
X-Gm-Message-State: AHPjjUgvEesOuKWA3OF0m+XGPCSG71ABQkDKsEAM5YvYlyyWhSh+bzMD ZhVwwARfyqDwNLRM9WT8O9Xtnc4KDA==
X-Google-Smtp-Source: AOwi7QCrjOig+Ind6Zpp9cpyQXscoPEoY9EHwIhAW++jk/y0BSD6HniJP4Po+F4busTlQ7Pf+yQsbYn7kAdbXMovrdo=
X-Received: by 10.107.162.145 with SMTP id l139mr1767859ioe.193.1505165444231; Mon, 11 Sep 2017 14:30:44 -0700 (PDT)
MIME-Version: 1.0
Sender: phluid61@gmail.com
Received: by 10.107.138.137 with HTTP; Mon, 11 Sep 2017 14:30:43 -0700 (PDT)
Received: by 10.107.138.137 with HTTP; Mon, 11 Sep 2017 14:30:43 -0700 (PDT)
In-Reply-To: <CAGD1bZYEaFLZ-tmOzQgDEzaQ69qVE7odQuO0SUHp7amm+pBx_A@mail.gmail.com>
References: <6E58094ECC8D8344914996DAD28F1CCD8025EC@DGGEMM506-MBX.china.huawei.com> <CAGD1bZYEaFLZ-tmOzQgDEzaQ69qVE7odQuO0SUHp7amm+pBx_A@mail.gmail.com>
From: Matthew Kerwin <matthew@kerwin.net.au>
Date: Tue, 12 Sep 2017 07:30:43 +1000
X-Google-Sender-Auth: 2tDVLCjPf42yPtKYl4LbM3l0EFU
Message-ID: <CACweHNCQ6mcRGdp=yWWZKHfgN1+JOFKf+dW_5SvPnySgkmEGcA@mail.gmail.com>
Subject: Re: nits in draft-ietf-quic-recovery-05
To: Jana Iyengar <jri@google.com>
Cc: Roni Even <roni.even@huawei.com>, IETF QUIC WG <quic@ietf.org>
Content-Type: multipart/alternative; boundary="001a1140feaaa1b7700558f0a3af"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/iZVJ9eqXmXPYFqve3-cG9FNrtQM>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2017 21:30:47 -0000

On 12 Sep. 2017 04:45, "Jana Iyengar" <jri@google.com> wrote:

Hi Roni,

Thanks for your careful read of the draft!

> In section 3.1 the bullet before the last one “a QUIC sender marks a
> packet as lost when a packet larger than it is acknowledged” should be
> “with higher packet number” instead of “larger”?
>
We've consistently used "larger" packet number, so I'm inclined to stick
with that, even if "higher" is slightly more correct?


A "larger packet", and a "packet with a higher/larger/greater/whatever id"
are two different things. I think that's the contention.

Cheers
--
Matthew Kerwin