Re: [Roll] Adam Roach's No Objection on draft-ietf-roll-efficient-npdao-12: (with COMMENT)

Rahul Arvind Jadhav <rahul.jadhav@huawei.com> Thu, 27 June 2019 01:08 UTC

Return-Path: <rahul.jadhav@huawei.com>
X-Original-To: roll@ietfa.amsl.com
Delivered-To: roll@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B1A3A120094; Wed, 26 Jun 2019 18:08:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rEECVFxOiPIQ; Wed, 26 Jun 2019 18:08:02 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 51436120086; Wed, 26 Jun 2019 18:08:02 -0700 (PDT)
Received: from lhreml706-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id A450442674C60FA6F946; Thu, 27 Jun 2019 02:08:00 +0100 (IST)
Received: from lhreml703-chm.china.huawei.com (10.201.108.52) by lhreml706-cah.china.huawei.com (10.201.108.47) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 27 Jun 2019 02:08:00 +0100
Received: from lhreml703-chm.china.huawei.com (10.201.108.52) by lhreml703-chm.china.huawei.com (10.201.108.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 27 Jun 2019 02:08:00 +0100
Received: from BLREML406-HUB.china.huawei.com (10.20.4.43) by lhreml703-chm.china.huawei.com (10.201.108.52) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA_P256) id 15.1.1713.5 via Frontend Transport; Thu, 27 Jun 2019 02:08:00 +0100
Received: from BLREML503-MBX.china.huawei.com ([169.254.9.118]) by BLREML406-HUB.china.huawei.com ([10.20.4.43]) with mapi id 14.03.0439.000; Thu, 27 Jun 2019 06:37:51 +0530
From: Rahul Arvind Jadhav <rahul.jadhav@huawei.com>
To: Adam Roach <adam@nostrum.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-roll-efficient-npdao@ietf.org" <draft-ietf-roll-efficient-npdao@ietf.org>, Peter Van der Stok <consultancy@vanderstok.org>, "aretana.ietf@gmail.com" <aretana.ietf@gmail.com>, "roll-chairs@ietf.org" <roll-chairs@ietf.org>, "roll@ietf.org" <roll@ietf.org>
Thread-Topic: Adam Roach's No Objection on draft-ietf-roll-efficient-npdao-12: (with COMMENT)
Thread-Index: AQHVLHVOA4LrQdLDJku8xh1OK3O70Kaur5Dg
Date: Thu, 27 Jun 2019 01:07:51 +0000
Message-ID: <982B626E107E334DBE601D979F31785C5DF0BFD3@BLREML503-MBX.china.huawei.com>
References: <156159102176.20168.277762395154650827.idtracker@ietfa.amsl.com>
In-Reply-To: <156159102176.20168.277762395154650827.idtracker@ietfa.amsl.com>
Accept-Language: en-IN, zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.61.109.81]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/roll/EYQeYiMh-ePf9f8hvlbDS5frH9Y>
Subject: Re: [Roll] Adam Roach's No Objection on draft-ietf-roll-efficient-npdao-12: (with COMMENT)
X-BeenThere: roll@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Over Low power and Lossy networks <roll.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/roll>, <mailto:roll-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/roll/>
List-Post: <mailto:roll@ietf.org>
List-Help: <mailto:roll-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/roll>, <mailto:roll-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Jun 2019 01:08:04 -0000

Thank you Adam for the review and feedback.
Will fix both the points.

Thanks,
Rahul


----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thanks to the authors for a well-written and easy-to-follow document.
I only have two tiny editorial suggestions.

---------------------------------------------------------------------------

§1.2:

>  RPL uses NPDAO messaging in the storing mode so that the node  
> changing it routing adjacencies can invalidate the previous route.

Nit: "...changing its routing..."


---------------------------------------------------------------------------

§6.2:

>  The following bits are currently defined:

This value appears to be an enumeration rather than a bitmap, right? I think you want to replace "bits" with "values" in this sentence.