Re: [rtcweb] When are ICE candidates added to the SDP

Martin Thomson <martin.thomson@gmail.com> Tue, 13 May 2014 16:45 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: rtcweb@ietfa.amsl.com
Delivered-To: rtcweb@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EBBDA1A013F for <rtcweb@ietfa.amsl.com>; Tue, 13 May 2014 09:45:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4tNLrGJ9hoaw for <rtcweb@ietfa.amsl.com>; Tue, 13 May 2014 09:45:20 -0700 (PDT)
Received: from mail-wi0-x233.google.com (mail-wi0-x233.google.com [IPv6:2a00:1450:400c:c05::233]) by ietfa.amsl.com (Postfix) with ESMTP id 165851A008E for <rtcweb@ietf.org>; Tue, 13 May 2014 09:45:19 -0700 (PDT)
Received: by mail-wi0-f179.google.com with SMTP id bs8so956300wib.12 for <rtcweb@ietf.org>; Tue, 13 May 2014 09:45:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=x8ggPpdlJhE867ugnlc6ugmtbSdlG8ggUplNkzwn3Y4=; b=MOv+5dbu5grNbmnfCwypMwiXeECCXEIDBP6gFWlOpuhs3lAJU5r/HEga/u3x1MZUZu TW2WlChh927Mt1QAX1ov15WCAO2prsPok+5B6D0spdt7MFwre0Z/MkFQsNkrT/n4TlAW blG5vG+lefrkauh+l54NjQut0wp824dneAJ7X0SsX38OV9qb6ecHJm8O6rPjPtWwZD61 qE8LT8qNoUCbV/4XZj5lYL4p6w+YPsCL6AFaUAY6W5AjZ0ZKZCUEUUs05Epa8FPsIKxq lps2NtV3VNKJeafuAxaVL4JS1ceYAFfDD8CRXv980ZZTXL78Wlbhfw4OWa9FiymafV19 BzOg==
MIME-Version: 1.0
X-Received: by 10.194.91.175 with SMTP id cf15mr28306304wjb.5.1399999513293; Tue, 13 May 2014 09:45:13 -0700 (PDT)
Received: by 10.194.235.163 with HTTP; Tue, 13 May 2014 09:45:13 -0700 (PDT)
In-Reply-To: <CAHp8n2=rzs2+++0kr5yEakz-oUGaBRe=RGeQz54xsaQiLJjUMA@mail.gmail.com>
References: <CABcZeBNUTf42tS9FrjS9Q6Zk8LBkhpKOR1z2v8MHoeNEUf93Mw@mail.gmail.com> <56C2F665D49E0341B9DF5938005ACDF82F69E8@DEMUMBX005.nsn-intra.net> <CABcZeBO1Z0SnTUixjV09ekw-mb=YyzHjOV-b-MMUZy7sx32h6Q@mail.gmail.com> <5370D1E3.7040809@alvestrand.no> <CABcZeBNgJ_DP6XQ2L0fdrFEE-YWwuKCjq4f-X5cD6+pK3un8Hw@mail.gmail.com> <5370F349.7050006@alvestrand.no> <CABkgnnWfAYTUBrrbu=m_j0=S3uBw4Cf7PBDi3ZmAGHsUMBX1kQ@mail.gmail.com> <56C2F665D49E0341B9DF5938005ACDF82F8091@DEMUMBX005.nsn-intra.net> <CABkgnnWAkxf5jERHruSb=cU6=yhBHxMf3Y6irxekHLZN-kxcEQ@mail.gmail.com> <56C2F665D49E0341B9DF5938005ACDF82F83FD@DEMUMBX005.nsn-intra.net> <CAHp8n2=rzs2+++0kr5yEakz-oUGaBRe=RGeQz54xsaQiLJjUMA@mail.gmail.com>
Date: Tue, 13 May 2014 09:45:13 -0700
Message-ID: <CABkgnnUzLBJnRkZWS0msRHGDysfORtycz37djhRj8d9OQGrirA@mail.gmail.com>
From: Martin Thomson <martin.thomson@gmail.com>
To: Silvia Pfeiffer <silviapfeiffer1@gmail.com>
Content-Type: text/plain; charset=UTF-8
Archived-At: http://mailarchive.ietf.org/arch/msg/rtcweb/yxbNN-qoGK2xQid-qVus_h8fpjU
Cc: "rtcweb@ietf.org" <rtcweb@ietf.org>
Subject: Re: [rtcweb] When are ICE candidates added to the SDP
X-BeenThere: rtcweb@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Real-Time Communication in WEB-browsers working group list <rtcweb.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/rtcweb/>
List-Post: <mailto:rtcweb@ietf.org>
List-Help: <mailto:rtcweb-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 May 2014 16:45:22 -0000

On 13 May 2014 00:54, Silvia Pfeiffer <silviapfeiffer1@gmail.com> wrote:
>> The name "createOffer" implies that the SDP delivered as the result of
>> createOffer is the one to use as an offer in negotiation. Looking at the way
>> this mechanism has evolved, this is probably only true anymore if one is
>> prepared to send the offer immediately, and then to trickle ICE candidates.
>> To obtain an SDP to use as an offer in negotiations without trickle ICE, one
>> has to call setLocal, wait for "end of candidates" and then read
>> pc.localDescription.
>>
>> So "createOffer" in fact does not create an offer, but an initial (or
>> updated) local description that is then fed into setLocalDescription to
>> start the ICE gathering.
>>
>> Do you agree with this observation? If you do, shouldn't we rename
>> createOffer to something more generic like "createLocalDescription" or
>> similar? "createOffer" does not create the offer (at least it does not do so
>> in case of non-trickling) but the input to setLocal...
>>
>
> I agree, the name is very misleading now.

I disagree.  Though I don't find any of this particularly intuitive,
the response to createOffer is still an offer that can be used to
negotiate a session.  The fact that it cannot be used immediately with
some classes of peer is unfortunate, but it's still good for
negotiating with browsers.

So yes, this new createOffer is only good for negotiating with a peer
that supports trickle ICE.  I think that's better than what we had
previously, which is *no idea what the browser was supposed to do*, as
demonstrated by the fact that the only two implementations in
existence did the complete opposite thing.