IETF Logo Mail Archive

Re: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bgp-sr-segtypes-ext-02

Ketan Talaulikar <ketant.ietf@gmail.com> Sat, 02 March 2024 04:30 UTC

Return-Path: <ketant.ietf@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 07B24C14F686; Fri, 1 Mar 2024 20:30:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N-R6yUIhng99; Fri, 1 Mar 2024 20:30:24 -0800 (PST)
Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8F738C14F680; Fri, 1 Mar 2024 20:30:24 -0800 (PST)
Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a293f2280c7so525204766b.1; Fri, 01 Mar 2024 20:30:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709353823; x=1709958623; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=e/0NKWSPYY0MPYm2AOaIQK76lEsO2WWMb8FT7Y7B5pE=; b=l0ES3Nw1UXN9KoKS7iP0ptZcIWyMB8sPUhmnJa+v+zL4RBg8snahlHsiHOAJXVtj7I VTAUaUpHQLiaOUiMAslxkEfkoJBTcLtARBEDgdx3k/zqi7PmjTFteChXOACAS0Rs7GH/ wYAbPD1P+BD4ird59IXq38x+F8H+6043EKAPaIFQKDWS3Fz+759uHLXuxMAKyGpkOFwg NTfjM+A2TpsuXg+8mx/SfcPyKiWJVRxMtdOK1pEZdadV/EYWhBpLMDki7lZ6FJwfTO+g sLB+sxUjHJyZhgE2RleY4bRGsHLqdck4PsEHvlawjXK2JwLYeOB3qLWKXVAl/eJheRUy PHgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709353823; x=1709958623; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e/0NKWSPYY0MPYm2AOaIQK76lEsO2WWMb8FT7Y7B5pE=; b=ItQE+YiGpFZX8VSPLeLzA56cvxzjdfhX80YyKYyhorD3CRhL3qOzisWZ3e5TkwAbkS lsea4NMaRGy0t/g+H0fOb6mVoYQ9PKrDq/ArnnJyp41YuY47+LENRkfsTHe1jqPdW8QP nnXYZRAJxH6kfrpTFKTa9ysjwGxaUFyo67IT8ldUOsrZycuadcH4KBXPPbWvrGPvZAit ZjDQY2MdeIf+YxIKpI4G4wwhW3yJQQx8MjNI6W1AR9iNtL798o6VuojjX1Tzqjgg2Hpj ri+7KyOka01h+c7wtUL1L2ZO0tEu1vQOBRlSLhBkKENdYoiXqLLFToCN9+xieScbH21q +6iQ==
X-Forwarded-Encrypted: i=1; AJvYcCVNK+KHYkalAGLAulQKvmqq+Bz0oCaVC+cSalXz53Q2OR1GlRA2y0rRJnYPAk9+2KYJo5Z9siORUpb0lXcVtUfL4iAzgHFmjrddQg8R6kcX//vnQHJ+yq/JwWTCgMrwp7kdtGJBC8qC+rD1jP+s
X-Gm-Message-State: AOJu0Yzwy3GXlTIFY/FVfohC4GrTr+MdiChNeR4w4W9uruXkHNdQXCES sCUFG/js+9vGpMxaPdpA3iI7Mh6lUEQ3wskQivKKhJQmSkL9YrBisYMlD8mlt1DnaqGxOVP2kG1 +Dh+1wjLguSlH7OqoikKSdpDQSKpZPOh9
X-Google-Smtp-Source: AGHT+IHhwB/4UYkWKLh+ASokCnbGewlxW6d+5kS5VO/cgSb7VmtEGdPVov0J9ToqIfr0HDtoblstcbWXxOmAi1YJIsw=
X-Received: by 2002:a17:906:d156:b0:a43:29e1:6db8 with SMTP id br22-20020a170906d15600b00a4329e16db8mr2968966ejb.9.1709353822949; Fri, 01 Mar 2024 20:30:22 -0800 (PST)
MIME-Version: 1.0
References: <170933816446.22739.15896636640990291082@ietfa.amsl.com>
In-Reply-To: <170933816446.22739.15896636640990291082@ietfa.amsl.com>
From: Ketan Talaulikar <ketant.ietf@gmail.com>
Date: Sat, 02 Mar 2024 10:00:11 +0530
Message-ID: <CAH6gdPxDQj+cBOT=9ydvinzEXhh_9NzC8K1FSXWB2Hjo+5mvdg@mail.gmail.com>
To: Stig Venaas <stig@venaas.com>
Cc: rtg-dir@ietf.org, draft-ietf-idr-bgp-sr-segtypes-ext.all@ietf.org, idr@ietf.org
Content-Type: multipart/alternative; boundary="0000000000006998270612a5f35e"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/Gr_X5UesiHgG-9eFFy7EKkHV-uU>
Subject: Re: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bgp-sr-segtypes-ext-02
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Mar 2024 04:30:25 -0000

Hi Stig,

Thanks for your review and catching those nits. They will be addressed in
the next update of the document.

Thanks,
Ketan


On Sat, Mar 2, 2024 at 5:39 AM Stig Venaas via Datatracker <noreply@ietf.org>
wrote:

> Reviewer: Stig Venaas
> Review result: Ready
>
> I have reviewed the document and I believe it is ready.
>
> I only found one minor nit when reviewing.
>
> In section 2 it says:
>    As specified in section 2.4.4.2 of [I-D.ietf-idr-sr-policy-safi], the
>    Segment Type Sub-TLVs specified in this document are also used only
>    by the SRPM [I-D.ietf-idr-sr-policy-safi] as described in section 4
>    of [RFC9256] on the same lines as segment types A and B.  Their
>    validation is, therefore, beyond the scope of BGP.
>
> SRPM should be spelled out when first used.
> Not sure what is meant by "on the same lines", should it be "along the
> same lines"?
>
>
>
>

v2.23.0 | Report a Bug | By Email