[RTG-DIR] Rtgdir early review of draft-ietf-idr-bgp-sr-segtypes-ext-02

Stig Venaas via Datatracker <noreply@ietf.org> Sat, 02 March 2024 00:09 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: rtg-dir@ietf.org
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 772B2C14F749; Fri, 1 Mar 2024 16:09:24 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Stig Venaas via Datatracker <noreply@ietf.org>
To: rtg-dir@ietf.org
Cc: draft-ietf-idr-bgp-sr-segtypes-ext.all@ietf.org, idr@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.6.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170933816446.22739.15896636640990291082@ietfa.amsl.com>
Reply-To: Stig Venaas <stig@venaas.com>
Date: Fri, 01 Mar 2024 16:09:24 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/Hunx3XVVUkfoGfI8_GXuapzU6es>
Subject: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bgp-sr-segtypes-ext-02
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Mar 2024 00:09:24 -0000

Reviewer: Stig Venaas
Review result: Ready

I have reviewed the document and I believe it is ready.

I only found one minor nit when reviewing.

In section 2 it says:
   As specified in section of [I-D.ietf-idr-sr-policy-safi], the
   Segment Type Sub-TLVs specified in this document are also used only
   by the SRPM [I-D.ietf-idr-sr-policy-safi] as described in section 4
   of [RFC9256] on the same lines as segment types A and B.  Their
   validation is, therefore, beyond the scope of BGP.

SRPM should be spelled out when first used.
Not sure what is meant by "on the same lines", should it be "along the same lines"?