Re: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bgp-sr-segtypes-ext-02
Ketan Talaulikar <ketant.ietf@gmail.com> Mon, 04 March 2024 11:51 UTC
Return-Path: <ketant.ietf@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E60C3C15154D; Mon, 4 Mar 2024 03:51:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bziT9h6_PAfI; Mon, 4 Mar 2024 03:51:14 -0800 (PST)
Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EFE2BC14F5E8; Mon, 4 Mar 2024 03:51:13 -0800 (PST)
Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a4417fa396fso549361566b.1; Mon, 04 Mar 2024 03:51:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709553072; x=1710157872; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QppIIU3LBXNVN1LBjzIOyQGoxFG1H7AqzSM/niSRu7k=; b=e0b6tiMPTUVCPB5rBQJRP6SAll8oZsC8x9xZOtka23vYXqG95P1+mjFx/w3VOe2jB7 f1p6fpxjYCaFRKORpUm/L21MX0vw81NbAQQ4FGr5TT4xuGOwhFubuV5aeu+z29ucaeLg 8x6XVEQCxKdTdJuYQPCh6phqT1jrLCBszdqlVHgtm7ouEV0mWr1YXgSPCMHv10Ls1zN/ X+ko980xuV0KYa6kiA2zuOl7Zyo5//pokAjdy0DzR+7zYikIqI0JwBL1g0aoD55580pL uF3K/7xHWAJJAwtY/3JrQ/DM5JSAyOZvCR+ArjriKhS3nFQtA5zmSSG2CEZ01ZTxiH3m fdDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709553072; x=1710157872; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QppIIU3LBXNVN1LBjzIOyQGoxFG1H7AqzSM/niSRu7k=; b=h4DX5jPJLLtu1FoIZ4XHYp4dTHwpa38xHsVd0loG9SCPjfMjaEv4VapIM5eXP7Oz9r Dhvy/4v21ycIuLMfwT/hh0o427DYzaJcdkiKjRSH64LK18tOg9VoP9cI26OI8iyZyJQf W2VvnzeFjVnvT+9f6yIPv/K60nZ4gtAGG6rCAsqdE/Md8NHXq/QMc5Y9Gs2DGN+VMC9p fth5Orc/HUZfePaRQ/BEbF6pNZJxc/jnzk+IisB0ELX1m+4Jt3h2oKhG9gpoW3VOyvfm MCOiSM/gCqxAUPNOfG/OQDkLUbPZk5BhjUQkc9Kzg4/oSqmjGoq1kZTYdhV36+Z3piRE 4vNg==
X-Forwarded-Encrypted: i=1; AJvYcCVB6p/Ndd4AZ71w9LALnbkR3GHLTEztrzU/aKipi9+OZtblDvyB9PkLibWJfGFGdeo5194V7Qj/uVssZhHZ+f4SKUIiZkPRjHmTf9C/P/vIlEp6g/0bjH/hv16v2sjgGD99c/LYrWGGOaA7h1Sg
X-Gm-Message-State: AOJu0Yxb9N3abq3a/62293xq7iVKS0a4ty3hL8CogU6hb6Z7NIVJbdeH mHsam3BF3hNNe7XlfCRtk4GOdcENlO12dFeasnWH8AjusdPmaRqRvSzSIHD2F4fvkNSeZ0/k7QQ QoQhSzEjfMtSb7HgybToW7gMsqF1QalA9rwg=
X-Google-Smtp-Source: AGHT+IFyLJF1N+ZZCMXJySOLYQ1VwzZzqFrHaE3wawp965RiNcz/egWtROQ9JucuFcoXOi0Q86lENzvRoAHdrviB6OU=
X-Received: by 2002:a17:906:ca46:b0:a3e:8223:289a with SMTP id jx6-20020a170906ca4600b00a3e8223289amr5865163ejb.31.1709553071559; Mon, 04 Mar 2024 03:51:11 -0800 (PST)
MIME-Version: 1.0
References: <170933816446.22739.15896636640990291082@ietfa.amsl.com> <CAH6gdPxDQj+cBOT=9ydvinzEXhh_9NzC8K1FSXWB2Hjo+5mvdg@mail.gmail.com>
In-Reply-To: <CAH6gdPxDQj+cBOT=9ydvinzEXhh_9NzC8K1FSXWB2Hjo+5mvdg@mail.gmail.com>
From: Ketan Talaulikar <ketant.ietf@gmail.com>
Date: Mon, 04 Mar 2024 17:20:59 +0530
Message-ID: <CAH6gdPxwtCTFC=GZ0-q-XHxZF86A2tHrBtSdL_3g4nZEovj8Bw@mail.gmail.com>
To: Stig Venaas <stig@venaas.com>
Cc: rtg-dir@ietf.org, draft-ietf-idr-bgp-sr-segtypes-ext.all@ietf.org, idr@ietf.org
Content-Type: multipart/alternative; boundary="0000000000008e18f00612d45784"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/RmIRkmvojGGEApHjPhrq1dFwvns>
Subject: Re: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bgp-sr-segtypes-ext-02
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Mar 2024 11:51:15 -0000
Hi Stig, An update has been posted that includes the changes discussed below: https://datatracker.ietf.org/doc/html/draft-ietf-idr-bgp-sr-segtypes-ext-03 Thanks, Ketan On Sat, Mar 2, 2024 at 10:00 AM Ketan Talaulikar <ketant.ietf@gmail.com> wrote: > Hi Stig, > > Thanks for your review and catching those nits. They will be addressed in > the next update of the document. > > Thanks, > Ketan > > > On Sat, Mar 2, 2024 at 5:39 AM Stig Venaas via Datatracker < > noreply@ietf.org> wrote: > >> Reviewer: Stig Venaas >> Review result: Ready >> >> I have reviewed the document and I believe it is ready. >> >> I only found one minor nit when reviewing. >> >> In section 2 it says: >> As specified in section 2.4.4.2 of [I-D.ietf-idr-sr-policy-safi], the >> Segment Type Sub-TLVs specified in this document are also used only >> by the SRPM [I-D.ietf-idr-sr-policy-safi] as described in section 4 >> of [RFC9256] on the same lines as segment types A and B. Their >> validation is, therefore, beyond the scope of BGP. >> >> SRPM should be spelled out when first used. >> Not sure what is meant by "on the same lines", should it be "along the >> same lines"? >> >> >> >>
- [RTG-DIR] Rtgdir early review of draft-ietf-idr-b… Stig Venaas via Datatracker
- Re: [RTG-DIR] Rtgdir early review of draft-ietf-i… Ketan Talaulikar
- Re: [RTG-DIR] Rtgdir early review of draft-ietf-i… Ketan Talaulikar