Re: [RTG-DIR] RtgDir review: draft-ietf-trill-rbridge-bfd-05.txt

"John G. Scudder" <jgs@juniper.net> Mon, 11 June 2012 21:04 UTC

Return-Path: <jgs@juniper.net>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EFBBA21F8582 for <rtg-dir@ietfa.amsl.com>; Mon, 11 Jun 2012 14:04:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.599
X-Spam-Level:
X-Spam-Status: No, score=-6.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tW2stALdkryc for <rtg-dir@ietfa.amsl.com>; Mon, 11 Jun 2012 14:04:29 -0700 (PDT)
Received: from exprod7og105.obsmtp.com (exprod7og105.obsmtp.com [64.18.2.163]) by ietfa.amsl.com (Postfix) with ESMTP id 76D2021F8573 for <rtg-dir@ietf.org>; Mon, 11 Jun 2012 14:04:28 -0700 (PDT)
Received: from P-EMHUB01-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by exprod7ob105.postini.com ([64.18.6.12]) with SMTP ID DSNKT9ZdWIWOc6cP/GxIV9pdTDJiHOhKT05X@postini.com; Mon, 11 Jun 2012 14:04:29 PDT
Received: from [172.16.13.202] (172.16.13.202) by P-EMHUB01-HQ.jnpr.net (172.24.192.33) with Microsoft SMTP Server id 8.3.213.0; Mon, 11 Jun 2012 14:02:46 -0700
MIME-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset="iso-8859-1"
From: "John G. Scudder" <jgs@juniper.net>
In-Reply-To: <CAF4+nEHDK=4r_sy1cXM+v=J5ZAuPU3PmghySKC0nqKJ9PDE9kA@mail.gmail.com>
Date: Mon, 11 Jun 2012 17:02:45 -0400
Content-Transfer-Encoding: quoted-printable
Message-ID: <EBAB16DD-DFCF-4D43-B14F-531B857BB8F2@juniper.net>
References: <6DB11511-5B76-49B3-824B-193824728011@juniper.net> <CAF4+nEHDK=4r_sy1cXM+v=J5ZAuPU3PmghySKC0nqKJ9PDE9kA@mail.gmail.com>
To: Donald Eastlake <d3e3e3@gmail.com>
X-Mailer: Apple Mail (2.1278)
Cc: Vishwas Manral <vishwas.ietf@gmail.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-trill-rbridge-bfd.all@tools.ietf.org" <draft-ietf-trill-rbridge-bfd.all@tools.ietf.org>, "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>
Subject: Re: [RTG-DIR] RtgDir review: draft-ietf-trill-rbridge-bfd-05.txt
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/rtg-dir>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2012 21:04:30 -0000

Hi Donald,

Comments below only where I had something to say other than "OK". You can take that as read otherwise.

On Jun 11, 2012, at 4:48 PM, Donald Eastlake wrote:
...
>> Minor Issues:
...
>> 4. In two places text like the following appears:
>> 
>>  Is the M-bit in the TRILL Header non-zero? If so, discard the
>>  frame.  TRILL support of multi-destination BFD Echo is beyond the
>>  scope of this document.
>> 
>> If multi-destination doesn't make sense in the context of TRILL, it
>> is fine to exclude it by enforcing that the M-bit be zero. However,
>> I normally parse "beyond the scope of this document" to mean
>> something like "we may do it in the future but haven't worked it out
>> yet". By forcing the M-bit to be zero, you're placing
>> multi-destination *in* scope, inasmuch as you are actively
>> forbidding it from being supported.
>> 
>> Presumably the sentence about "beyond the scope" was meant to
>> justify this decision. Perhaps the comment about "scope" should be
>> dropped and a different justifying sentence used. (Or the sentence
>> omitted altogether.)
> 
> Multi-destination makes sense for TRILL. It is just not yet
> standardized, as far as I know, for BFD. Perhaps the "beyond the
> scope" verbage should be removed and a note added somewhere such as
> "(Multi-destination BFD is a work in progress [...].)"

By requiring the M-bit to be zero you effectively preclude the later introduction of multi-destination, do you not?

>> 5. Presumably the Security Area reviewer may raise this, but the
>> Security Considerations section seems to be misused. My
>> understanding (confirmed by referring to RFC 3552 Section 5) is that
>> the Security Considerations section is intended to be an analysis of
>> issues that arise from the operation of the protocol defined in the
>> rest of the document, including but not limited to the security
>> features of that protocol.
>> 
>> This document's Security Considerations section instead specifies
>> how authentication is to be done, though it doesn't provide an
>> analysis of it or of any broader issues. I presume the section
>> should be retitled (e.g., to "Authentication") and a proper Security
>> Considerations section added.
>> 
>> (This would probably be a "major issue" if I were the Security Area
>> reviewer, but I'm not.)
> 
> As far as I can tell (and I'm a member of the Security Directorate),
> the Security Area considers this a non-issue. However, I've got no
> problem with moving this material to a new "Default Authentication"
> section or the like.

OK.

(As an aside, if the Security Directorate considers this a non-issue, maybe it's time to revise RFC 3552? I say this as an occasional author of Security Considerations sections and not with regard to your draft.)

--John