Re: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bgp-car-02

Ben Niven-Jenkins <ben@niven-jenkins.co.uk> Wed, 06 December 2023 16:26 UTC

Return-Path: <ben@niven-jenkins.co.uk>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8738FC14CF1F; Wed, 6 Dec 2023 08:26:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.906
X-Spam-Level:
X-Spam-Status: No, score=-6.906 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xMGFo2KOkgG9; Wed, 6 Dec 2023 08:26:36 -0800 (PST)
Received: from mx2.mythic-beasts.com (mx2.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A9D1AC14CF18; Wed, 6 Dec 2023 08:26:06 -0800 (PST)
Received: by mailhub-hex-d.mythic-beasts.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <ben@niven-jenkins.co.uk>) id 1rAuio-00Ej5A-5c; Wed, 06 Dec 2023 16:26:02 +0000
From: Ben Niven-Jenkins <ben@niven-jenkins.co.uk>
Message-Id: <3A1A6EEF-F92B-4C41-BC97-1A1F93A8993D@niven-jenkins.co.uk>
Content-Type: multipart/alternative; boundary="Apple-Mail=_CCB914A4-04D6-4F68-9919-1D2BEEBFB11B"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Date: Wed, 06 Dec 2023 16:25:52 +0000
In-Reply-To: <BY5PR11MB4273405408C5186F347655D3B0B2A@BY5PR11MB4273.namprd11.prod.outlook.com>
Cc: Susan Hares <shares@ndzh.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-idr-bgp-car.all@ietf.org" <draft-ietf-idr-bgp-car.all@ietf.org>, "idr@ietf.org" <idr@ietf.org>
To: "Dhananjaya Rao (dhrao)" <dhrao=40cisco.com@dmarc.ietf.org>
References: <169083336446.19263.6512979191896134032@ietfa.amsl.com> <3552AF3B-CFB3-4D34-9AC7-2FA3BCCD1607@niven-jenkins.co.uk> <BYAPR08MB4872D7A2EAF6867809F4ED0CB30AA@BYAPR08MB4872.namprd08.prod.outlook.com> <0511DD11-2620-42E2-93DA-D9193395608F@niven-jenkins.co.uk> <BY5PR11MB4273405408C5186F347655D3B0B2A@BY5PR11MB4273.namprd11.prod.outlook.com>
X-Mailer: Apple Mail (2.3696.120.41.1.4)
X-BlackCat-Spam-Score: 4
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/VjedzzIblorqkrhGqdVAuKrUi1A>
Subject: Re: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bgp-car-02
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2023 16:26:40 -0000

Hi Dhananjaya,

The new introduction text provides a really good overview and fully addresses my previous comment :-)

Thank you
Ben


> On 14 Nov 2023, at 18:37, Dhananjaya Rao (dhrao) <dhrao=40cisco.com@dmarc.ietf.org> wrote:
> 
> Hello Ben,
>  
> We have made a couple of updates to the CAR draft (latest is -04), as part of which we’ve also provided more context in the introduction.
> Could you please take a look when you get a chance and let us know if things are clear enough ?
> Apologies for the long delay in responding. Thank you once again for your review.
>  
> Regards,
> -Dhananjaya
>  
> From: Ben Niven-Jenkins <ben@niven-jenkins.co.uk>
> Date: Friday, August 4, 2023 at 1:48 AM
> To: Susan Hares <shares@ndzh.com>
> Cc: rtg-dir@ietf.org <rtg-dir@ietf.org>, draft-ietf-idr-bgp-car.all@ietf.org <draft-ietf-idr-bgp-car.all@ietf.org>, idr@ietf.org <idr@ietf.org>
> Subject: Re: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bgp-car-02
> 
> Hi Susan,
> 
> 
> On 1 Aug 2023, at 17:36, Susan Hares <shares@ndzh.com <mailto:shares@ndzh.com>> wrote:
>  
> Ben: 
>  
> Can you provide additional detail regarding your concerns? 
>  
> Sure. The Introduction is only 4 lines before the document starts defining terminology and the section after that (1.2 illustration) assumes pre-knowledge of what Color-Aware Routing is.
>  
> As someone without any pre-knowledge of color-aware routing or intent-aware paths it was quite difficult to form an idea in my head of what the big picture into which BGP CAR fits is.
>  
> I am suggesting including some additional introductory text that provides a bit of background and context and how BGP CAR fits into the bigger picture before the document starts getting into the gritty details of BGP CAR.
>  
> HTH
> Ben
> 
> 
>  
> You state: 
>  
> “The only suggestion I would have is to provide a short overview introducing BGP CAR and
> color aware routing before leaping into terminology and the details of the BGP
> CAR SAFI. Expanding the introduction section with an extra paragraph or two
> would be sufficient.” 
>  
> Sue Hares 
> IDR WG chair shepherd draft 
>  
> From: Ben Niven-Jenkins <ben@niven-jenkins.co.uk <mailto:ben@niven-jenkins.co.uk>> 
> Sent: Monday, July 31, 2023 4:15 PM
> To: Ben Niven-Jenkins <ben@niven-jenkins.co.uk <mailto:ben@niven-jenkins.co.uk>>
> Cc: rtg-dir@ietf.org <mailto:rtg-dir@ietf.org>; draft-ietf-idr-bgp-car.all@ietf.org <mailto:draft-ietf-idr-bgp-car.all@ietf.org>; idr@ietf.org <mailto:idr@ietf.org>
> Subject: Re: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bgp-car-02
>  
>  
>  
> 
> 
> 
> On 31 Jul 2023, at 20:56, Ben Niven-Jenkins via Datatracker <noreply@ietf.org <mailto:noreply@ietf.org>> wrote:
>  
> Reviewer: Ben Niven-Jenkins
> Review result: Has Issues
> 
> Hello
> 
> I have been selected to do a routing directorate “early” review of this draft.
> https://datatracker.ietf.org/doc/draft-ietf-mpls-rfc3107bis/ <https://datatracker.ietf.org/doc/draft-ietf-mpls-rfc3107bis/>
>  
> Of course I meant https://datatracker.ietf.org/doc/draft-ietf-idr-bgp-car/ <https://datatracker.ietf.org/doc/draft-ietf-idr-bgp-car/> :-)
>  
> Ben
> 
> 
> 
> 
> The routing directorate will, on request from the working group chair, perform
> an “early” review of a draft before it is submitted for publication to the
> IESG. The early review can be performed at any time during the draft’s lifetime
> as a working group document. The purpose of the early review depends on the
> stage that the document has reached.
> 
> For more information about the Routing Directorate, please see
> https://wiki.ietf.org/en/group/rtg/RtgDir <https://wiki.ietf.org/en/group/rtg/RtgDir>
> 
> Document: draft-ietf-idr-bgp-car-02
> Reviewer: Ben Niven-Jenkins
> Review Date: 31 July 2023
> Intended Status: Experimental
> 
> Summary:
> I have some minor concerns about this document that I think should be resolved
> before it is submitted to the IESG.
> 
> Comments:
> The document provides lots of details in the main sections and examples in the
> appendices. I think that is generally ready to be published. The only
> suggestion I would have is to provide a short overview introducing BGP CAR and
> color aware routing before leaping into terminology and the details of the BGP
> CAR SAFI. Expanding the introduction section with an extra paragraph or two
> would be sufficient.
> 
> Thanks
> Ben
>