Re: AD review of draft-ietf-rtgwg-bgp-pic-18

Yingzhen Qu <yingzhen.ietf@gmail.com> Wed, 25 October 2023 21:27 UTC

Return-Path: <yingzhen.ietf@gmail.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B830CC180DF4; Wed, 25 Oct 2023 14:27:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.104
X-Spam-Level:
X-Spam-Status: No, score=-1.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vQ8juthUNz9K; Wed, 25 Oct 2023 14:27:37 -0700 (PDT)
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D637AC180DF5; Wed, 25 Oct 2023 14:27:37 -0700 (PDT)
Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2c59a4dd14cso2525001fa.2; Wed, 25 Oct 2023 14:27:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698269255; x=1698874055; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WWDhgg+Kp2M5vbhd53ZLedXIdBuclwtlwZ7ohG5fqNg=; b=SW6TqkVk4mfLgJzcLcS1h/M9kPRYdCNbJbW2f4bPzKsWxXCGgYSpUs23dz8PnoCMj8 PgqaOcccYyUGEeYP7rs1xKjs8WrpDF0fC65Eh0Djr4b30BsbATx4X2+s51yY8j1Qq2ZW WUN3rICck8Shf9goZYjTCGViMrZF9+b0YfYHPn9odd2FR3Zyk5SzVamorHoKmD0nlIj7 A+eZeTVe/Hs0GJcemeCdEbFDETe9KTM60DR2XsAc8aVY1ilh+PR/5XuAVqcE7o0Lxt7K pO5Y20/k7tLN53UvSGbyQJ0sUgVJsmkm+3bNNAQV4m3KG89xYJlWbqqvblP3MHHhD5PL pjuQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698269255; x=1698874055; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WWDhgg+Kp2M5vbhd53ZLedXIdBuclwtlwZ7ohG5fqNg=; b=OtHiUv7ma4F0+mqJjlubGkPDZOThRRkoTImaMeneQfrTePbGob9lSnnCYYhksXi9iO lzWvdkFB3wQAoJ6lB7xIzKHdpQ75LOJdLRszxiBi2USSiTZrsX9mcBV8ezRLZdmtcmUr 3IFO4WKJNITTPjzYhP5dIt9N4tHVjB320U/ZlYKsFjMwZr8vZR4RVK/woRiHQx2ckcv8 /CP62iFhJfVkF+bVBfT+H9B8UDZi1xOURd/Pt9vJLFok+6VGYfrVi+D3Ncfj+3zFgbcr GowetSNp3s2mRYDYJGWy3Wjeiri8GiAFKwm8c9a3fZ0BKByMdP1wn1bQ0VbXZMlS/Jgz z8ew==
X-Gm-Message-State: AOJu0YxBHvrK9jFRD5sC1jYE8Od6oicTcpUqN8OKvnr2qKJsX0kFUc6R wrQFGqLKMTvy+i4il4tU7RfCGT4UFueRaeJyGLR23RwJJQ==
X-Google-Smtp-Source: AGHT+IHDD8bDGD8VGkLhUlqaMFeu0ffJ7Dh6KeyaJ/njRrQ+IaCCKu4EkYd8e9b99fywFfOgGL/lwx81Zvx+mBi10bQ=
X-Received: by 2002:a2e:a589:0:b0:2c5:1a8e:e4c9 with SMTP id m9-20020a2ea589000000b002c51a8ee4c9mr12780547ljp.31.1698269254791; Wed, 25 Oct 2023 14:27:34 -0700 (PDT)
MIME-Version: 1.0
References: <CAMMESsw1bdYc-p7TD7GtHNHa6zrO3Ms20VZX89Hza_JtWpK=Bw@mail.gmail.com> <CAMMESszTT8bRMt1UMS+OvsqePhZDJMHtOJ9sfcUs8zu19rtjsQ@mail.gmail.com> <f28a76bc-642e-faf2-94e0-6e72e85202db@gmail.com> <CAMMESsyR+wKE9sanxM73BatAU4x+rixcY3Lr+fVUfJsSibaCGA@mail.gmail.com>
In-Reply-To: <CAMMESsyR+wKE9sanxM73BatAU4x+rixcY3Lr+fVUfJsSibaCGA@mail.gmail.com>
From: Yingzhen Qu <yingzhen.ietf@gmail.com>
Date: Wed, 25 Oct 2023 14:27:23 -0700
Message-ID: <CABY-gOOsUONj8Bef75P_xSo30BPYHtTrT_iiSZNP9MtJj9vecA@mail.gmail.com>
Subject: Re: AD review of draft-ietf-rtgwg-bgp-pic-18
To: Alvaro Retana <aretana.ietf@gmail.com>
Cc: Ahmed Bashandy <abashandy.ietf@gmail.com>, draft-ietf-rtgwg-bgp-pic@ietf.org, RTGWG <rtgwg@ietf.org>, rtgwg-chairs@ietf.org
Content-Type: multipart/alternative; boundary="000000000000aa35ef0608911f17"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/5nq71v4QHW16qiOYnuw_31tS7eo>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Oct 2023 21:27:41 -0000

Hi Alvaro,

Thank you for the review. I agree with you that the terminology should stay
consistent with RFC4271. The reference format should be changed as well.

Authors,

Would you please continue to address the comments? This draft will need
another round of routing directorate review before the 2nd WGLC.

Thanks,
Yingzhen


On Tue, Oct 17, 2023 at 12:23 PM Alvaro Retana <aretana.ietf@gmail.com>
wrote:

> Hi!
>
> [I am not the AD, but the chairs asked me to look at the changes -- so
> I'm replying to this thread.]
>
>
> My main concern with this document continues to be the terminology
> (see quoted text below).  I am not satisfied with the changes -- the
> terminology is still not consistent with rfc4271 or other BGP-related
> IETF documents, regardless of what specific implementations may use.
> Adding "pic-" to the terms results, in my opinion, in more conflicts
> than before.
>
> The authors' opinion is not aligned with mine, which results in
> disconnects about the description of the processes and the content in
> general.  To quote Ahmed:
>
>     #Ahmed: that is probably the main reason of lots of disconnects.
>     The document defines terms and uses these terms according to the
>     definition in the document, not in other documents (even if these
>     other documents are RFCs). I already prefixed the confusing terms
>     in the document with something like "PIC-"
>
>
> As a WG participant, I don't think this document is ready to move
> forward, but it is not up to me to decide which approach should be
> followed.  I'll leave that up to the Chairs and the rest of the WG.
>
>
> Just one substantive comment: the references were not updated to the
> required format.  The RFC Editor requires that the OID be listed for
> all references [1].  Please update the references -- here's an example
> of what they should look like [2]:
>
>    [RFC4271]  Rekhter, Y., Ed., Li, T., Ed., and S. Hares, Ed., "A Border
>               Gateway Protocol 4 (BGP-4)", RFC 4271, DOI 10.17487/RFC4271,
>               January 2006, <https://www.rfc-editor.org/info/rfc4271>.
>
> [1] https://www.rfc-editor.org/styleguide/part2/
> [2] https://www.rfc-editor.org/refs/ref4271.txt
>
>
>
> Alvaro.
>
>
>
> On April 1, 2023 at 7:58:02 PM, Ahmed Bashandy wrote:
> ...
> > > On August 2, 2022 at 4:23:53 PM, Alvaro Retana (aretana.ietf@gmail.com
> (mailto:aretana.ietf@gmail.com)) wrote:
> ...
> > > > After reading the document, I think that it still needs work:
> > > >
> > > > (1) The terminology used is not aligned with rfc4271. Of major
> importance
> > > > is the description of the Routing Table, the Decision Process, the
> use of
> > > > best routes (not paths!), etc. I pointed out multiple occurrences
> below,
> > > > buy I need you to check the whole document for consistency.
> >
> > #Ahmed: The terms that I use in this documents are defined in the
> terminology
> > section and are widely used in many implementations. However to avoid
> > confusion, whenever applicable I prepended these terms with "PIC-" to
> make
> > them distinct from similar terms in drafts or RFCs
> ...
>