Re: AD review of draft-ietf-rtgwg-bgp-pic-18

Ahmed Bashandy <abashandy.ietf@gmail.com> Sat, 11 November 2023 16:01 UTC

Return-Path: <abashandy.ietf@gmail.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CC8DFC15106B; Sat, 11 Nov 2023 08:01:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.195
X-Spam-Level:
X-Spam-Status: No, score=-1.195 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.091, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eXrYoTO8vv_l; Sat, 11 Nov 2023 08:01:04 -0800 (PST)
Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5C147C151095; Sat, 11 Nov 2023 08:01:04 -0800 (PST)
Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9e28724ac88so479786566b.2; Sat, 11 Nov 2023 08:01:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699718463; x=1700323263; darn=ietf.org; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=CkPBe6ce+RW8K+5VaiRV4uSQE1/kA6ISqSOGKakM7FA=; b=PSAynq2gc6v+PcGavBhHUifXvtV6mzoRfADOINXBEDBBusLN8LkMNL5TkhEdxYoNbd OJgxJQ5PUTeDAhp/Y04tGILTp7yRvPJVQo96tuFR5EUBdtu9eB3pYFI3Yn73CDbfBkKd xZynaY5Znai5yf9pNFq7uLhvrNAMpfeOHwWE3nvF+wOKINK6RPMR5yK8xp/ndWOZMyPb Z5kBF3v8EBBlxb93C41eRegMzqe+gPG4z7a8uS0TeZAFN/q2qcxxeYEr+yz+kNuxQ3oN gPFD6TrpFXFZBvN3JiNWLp3JXZF3wEeBi4TMMk9TF3gFTTzK8xwi6PWa+MDooin1tpiW QLsA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699718463; x=1700323263; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CkPBe6ce+RW8K+5VaiRV4uSQE1/kA6ISqSOGKakM7FA=; b=Xw0gBqZsvnhxNXEaourA4CD5RCJXF1n/j9hgts8mlwewBRs3TRAD4iZly3Yj4igYXe rSk1Ihp94SVzHJY5xExFKVGZCXniePYcbNuGPiZniG1lUU9znjurg1hMN3uDDCkxgg7L AgwFJVi+zjHAcNtQjvV5MkuDwFQGXZUF0FnT79nYYspRarssPjsD60YTCMXYogqE+J7x TTuM+q4WqK61e5wc5vzXIwHa7Ep17RoANCZjc1+elif9MKaGE47snbBiqHuvzfmi2X5V nGIEgulYCpb9YDGIvy+mCkvjRnZj2HUiOFZG2LAIBHUpqc6Bc+zVnXWIv/drGezu6DdW LIGA==
X-Gm-Message-State: AOJu0YxiSQl00l6CEqoKZoG7ppB67g7KbHNFEc3gRoj5XFyxAPpVdxa/ PN9MbcEP2L+gPmk9PwhF4PrXIaQmp3MYbQ==
X-Google-Smtp-Source: AGHT+IHDwC9uPpFKGDeYYJvNlsMPw5GzPxIQhHk4y3O32ZGPzm5D7nBT5rXMxLHGyFfl3Ya2mv2ntg==
X-Received: by 2002:a17:906:370f:b0:9e5:d313:fee7 with SMTP id d15-20020a170906370f00b009e5d313fee7mr1362190ejc.50.1699718462342; Sat, 11 Nov 2023 08:01:02 -0800 (PST)
Received: from [192.168.48.100] (213.11-246-81.adsl-static.isp.belgacom.be. [81.246.11.213]) by smtp.gmail.com with ESMTPSA id rv27-20020a17090710db00b009e71efcce28sm1241028ejb.210.2023.11.11.08.01.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Nov 2023 08:01:01 -0800 (PST)
Content-Type: multipart/alternative; boundary="------------JRdRqILRUloP8wKT7f0BnkuN"
Message-ID: <b6fd8792-12b7-e2a2-7bbd-1d0ca91869d0@gmail.com>
Date: Sat, 11 Nov 2023 08:01:01 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1
Subject: Re: AD review of draft-ietf-rtgwg-bgp-pic-18
Content-Language: en-US
To: Yingzhen Qu <yingzhen.ietf@gmail.com>, Alvaro Retana <aretana.ietf@gmail.com>
Cc: draft-ietf-rtgwg-bgp-pic@ietf.org, RTGWG <rtgwg@ietf.org>, rtgwg-chairs@ietf.org
References: <CAMMESsw1bdYc-p7TD7GtHNHa6zrO3Ms20VZX89Hza_JtWpK=Bw@mail.gmail.com> <CAMMESszTT8bRMt1UMS+OvsqePhZDJMHtOJ9sfcUs8zu19rtjsQ@mail.gmail.com> <f28a76bc-642e-faf2-94e0-6e72e85202db@gmail.com> <CAMMESsyR+wKE9sanxM73BatAU4x+rixcY3Lr+fVUfJsSibaCGA@mail.gmail.com> <CABY-gOOsUONj8Bef75P_xSo30BPYHtTrT_iiSZNP9MtJj9vecA@mail.gmail.com>
From: Ahmed Bashandy <abashandy.ietf@gmail.com>
In-Reply-To: <CABY-gOOsUONj8Bef75P_xSo30BPYHtTrT_iiSZNP9MtJj9vecA@mail.gmail.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/FJiJ0LhfSQG9K4TIslqxlTi3sCg>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Nov 2023 16:01:08 -0000

Alvaro and Yingzhen,

First of all, it has to be understood that this draft is about FIB and 
the forwarding plane, NOT about BGP or routing. Just because it has the 
title "BGP-PIC", does NOT mean that that every term in the draft must  
be BGP-related. If BGP-PIC is not (almost) an industry standard, I would 
have changed the title.

Second, the terms that I am using are well defined in the draft, are 
different from the terms used in RFC4271, and are used differently in a 
different functional unit on a routing system (which is FIB and the 
forwarding plane). Why in your opinion I have to use terms that are 
BGP-related even though I am defining different terms that are used 
differently in a different functional unit on a router?

Third, I frankly do not understand the term "consistent". I would be 
very happy if you can provide an example of how I can modify some terms 
in this draft to become "consistent"" with RFC4271 in your opinion?


Ahmed


On 10/25/23 2:27 PM, Yingzhen Qu wrote:
> Hi Alvaro,
>
> Thank you for the review. I agree with you that the terminology should 
> stay consistent with RFC4271. The reference format should be changed 
> as well.
>
> Authors,
>
> Would you please continue to address the comments? This draft will 
> need another round of routing directorate review before the 2nd WGLC.
>
> Thanks,
> Yingzhen
>
>
> On Tue, Oct 17, 2023 at 12:23 PM Alvaro Retana 
> <aretana.ietf@gmail.com> wrote:
>
>     Hi!
>
>     [I am not the AD, but the chairs asked me to look at the changes -- so
>     I'm replying to this thread.]
>
>
>     My main concern with this document continues to be the terminology
>     (see quoted text below).  I am not satisfied with the changes -- the
>     terminology is still not consistent with rfc4271 or other BGP-related
>     IETF documents, regardless of what specific implementations may use.
>     Adding "pic-" to the terms results, in my opinion, in more conflicts
>     than before.
>
>     The authors' opinion is not aligned with mine, which results in
>     disconnects about the description of the processes and the content in
>     general.  To quote Ahmed:
>
>         #Ahmed: that is probably the main reason of lots of disconnects.
>         The document defines terms and uses these terms according to the
>         definition in the document, not in other documents (even if these
>         other documents are RFCs). I already prefixed the confusing terms
>         in the document with something like "PIC-"
>
>
>     As a WG participant, I don't think this document is ready to move
>     forward, but it is not up to me to decide which approach should be
>     followed.  I'll leave that up to the Chairs and the rest of the WG.
>
>
>     Just one substantive comment: the references were not updated to the
>     required format.  The RFC Editor requires that the OID be listed for
>     all references [1].  Please update the references -- here's an example
>     of what they should look like [2]:
>
>        [RFC4271]  Rekhter, Y., Ed., Li, T., Ed., and S. Hares, Ed., "A
>     Border
>                   Gateway Protocol 4 (BGP-4)", RFC 4271, DOI
>     10.17487/RFC4271,
>                   January 2006, <https://www.rfc-editor.org/info/rfc4271>.
>
>     [1] https://www.rfc-editor.org/styleguide/part2/
>     [2] https://www.rfc-editor.org/refs/ref4271.txt
>
>
>
>     Alvaro.
>
>
>
>     On April 1, 2023 at 7:58:02 PM, Ahmed Bashandy wrote:
>     ...
>     > > On August 2, 2022 at 4:23:53 PM, Alvaro Retana
>     (aretana.ietf@gmail.com (mailto:aretana.ietf@gmail.com)) wrote:
>     ...
>     > > > After reading the document, I think that it still needs work:
>     > > >
>     > > > (1) The terminology used is not aligned with rfc4271. Of
>     major importance
>     > > > is the description of the Routing Table, the Decision
>     Process, the use of
>     > > > best routes (not paths!), etc. I pointed out multiple
>     occurrences below,
>     > > > buy I need you to check the whole document for consistency.
>     >
>     > #Ahmed: The terms that I use in this documents are defined in
>     the terminology
>     > section and are widely used in many implementations. However to
>     avoid
>     > confusion, whenever applicable I prepended these terms with
>     "PIC-" to make
>     > them distinct from similar terms in drafts or RFCs
>     ...
>