Re: AD review of draft-ietf-rtgwg-bgp-pic-18

Alvaro Retana <aretana.ietf@gmail.com> Tue, 17 October 2023 19:23 UTC

Return-Path: <aretana.ietf@gmail.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9D5A5C170607; Tue, 17 Oct 2023 12:23:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wjsl179orr8Y; Tue, 17 Oct 2023 12:23:49 -0700 (PDT)
Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CB8D9C13739A; Tue, 17 Oct 2023 12:23:49 -0700 (PDT)
Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-692c02adeefso4452440b3a.3; Tue, 17 Oct 2023 12:23:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697570629; x=1698175429; darn=ietf.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=BN95QrT69Qb0j+ixBZUMpwZkKgiHbrbs200iC3TXDZ8=; b=EQaLAQNYBM7dACpiY006eHD1wiKdiKJPb/zv6ykyp2X+aBR2rGDA13h0jnKwjzkWbi rf9cEktKd6wY0V330U/iQXZmGKksSpXu731/o0PanGZ6i9WaqHPw1xA2tqHIY2KkD3t4 AkuXGbTyldeQ9fiu2sf1PeBk0rzZS7EhFvznbifDwMGtBhOOob6VVBTXHFkHTVjzhAuQ Yphpo/sNkz7n8NeCU4Wmw9Z8l5zQwT9nII1OIoV2M9C5EuJg+fsu5jJUskQOZ9SeHPH3 ip+E8kmSwM+L/YaDbP5+Taf6RkWMO1N1XQ5VnsiLye6iwIwGj8bM6avQAe3QAe6LXMdX I38A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697570629; x=1698175429; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BN95QrT69Qb0j+ixBZUMpwZkKgiHbrbs200iC3TXDZ8=; b=hMojGuSWOyc4IIc6awIvYtPrrZfd2KHZIlzO03DSfxNi7amJljWvZH41DV7+on0P2l SWwf8pY+ChZLSGCZnAusJ/r9BMJDSOLxKzxvTepZ4OzgDUbCLtKbTQuWk8pN1ct/VUHk L0fUA8M0datR8crrTMyz+x4msaskZWa7jI8Q0EF2QxdAr8wfe8jgt6ygsFdnPfU0ECWA vUG/tLJvrXV283+wq19cIxeetTirS2EwTVLZ68utAtuYNrYSKgyVEzHf1fruQSAE00xa 8w5o7Pib25IbOLVsd3Jc6rSk3lAQRD3SASvCJ0LK65G/OP0EuhPFzx/brV0hPGnKnYbm btRA==
X-Gm-Message-State: AOJu0YwKkfY1e9zhuJRm+0+wA/u771cfl1TSse9zLcI6+0htNiLoTtXD lkmnxFKHLZ9f2D32qD3UODvQ8qvK26UDH883qi1qWEuk
X-Google-Smtp-Source: AGHT+IHiY8klBXb/0iXrtl0bNZFDfJcey9FkhUC9V2nvWva+lHJX+LmHz5/y+cDZmr7HeQFX6ig7tfg57ju7CHb3U6k=
X-Received: by 2002:a05:6a21:3984:b0:17b:1ab9:5790 with SMTP id ad4-20020a056a21398400b0017b1ab95790mr1462933pzc.50.1697570629057; Tue, 17 Oct 2023 12:23:49 -0700 (PDT)
Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Tue, 17 Oct 2023 12:23:47 -0700
From: Alvaro Retana <aretana.ietf@gmail.com>
In-Reply-To: <f28a76bc-642e-faf2-94e0-6e72e85202db@gmail.com>
References: <CAMMESsw1bdYc-p7TD7GtHNHa6zrO3Ms20VZX89Hza_JtWpK=Bw@mail.gmail.com> <CAMMESszTT8bRMt1UMS+OvsqePhZDJMHtOJ9sfcUs8zu19rtjsQ@mail.gmail.com> <f28a76bc-642e-faf2-94e0-6e72e85202db@gmail.com>
MIME-Version: 1.0
Date: Tue, 17 Oct 2023 12:23:47 -0700
Message-ID: <CAMMESsyR+wKE9sanxM73BatAU4x+rixcY3Lr+fVUfJsSibaCGA@mail.gmail.com>
Subject: Re: AD review of draft-ietf-rtgwg-bgp-pic-18
To: Ahmed Bashandy <abashandy.ietf@gmail.com>, draft-ietf-rtgwg-bgp-pic@ietf.org
Cc: RTGWG <rtgwg@ietf.org>, rtgwg-chairs@ietf.org, Yingzhen Qu <yingzhen.ietf@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/VpEnZxSRwtl2IeMKTF5-m656Plk>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Oct 2023 19:23:53 -0000

Hi!

[I am not the AD, but the chairs asked me to look at the changes -- so
I'm replying to this thread.]


My main concern with this document continues to be the terminology
(see quoted text below).  I am not satisfied with the changes -- the
terminology is still not consistent with rfc4271 or other BGP-related
IETF documents, regardless of what specific implementations may use.
Adding "pic-" to the terms results, in my opinion, in more conflicts
than before.

The authors' opinion is not aligned with mine, which results in
disconnects about the description of the processes and the content in
general.  To quote Ahmed:

    #Ahmed: that is probably the main reason of lots of disconnects.
    The document defines terms and uses these terms according to the
    definition in the document, not in other documents (even if these
    other documents are RFCs). I already prefixed the confusing terms
    in the document with something like "PIC-"


As a WG participant, I don't think this document is ready to move
forward, but it is not up to me to decide which approach should be
followed.  I'll leave that up to the Chairs and the rest of the WG.


Just one substantive comment: the references were not updated to the
required format.  The RFC Editor requires that the OID be listed for
all references [1].  Please update the references -- here's an example
of what they should look like [2]:

   [RFC4271]  Rekhter, Y., Ed., Li, T., Ed., and S. Hares, Ed., "A Border
              Gateway Protocol 4 (BGP-4)", RFC 4271, DOI 10.17487/RFC4271,
              January 2006, <https://www.rfc-editor.org/info/rfc4271>.

[1] https://www.rfc-editor.org/styleguide/part2/
[2] https://www.rfc-editor.org/refs/ref4271.txt



Alvaro.



On April 1, 2023 at 7:58:02 PM, Ahmed Bashandy wrote:
...
> > On August 2, 2022 at 4:23:53 PM, Alvaro Retana (aretana.ietf@gmail.com (mailto:aretana.ietf@gmail.com)) wrote:
...
> > > After reading the document, I think that it still needs work:
> > >
> > > (1) The terminology used is not aligned with rfc4271. Of major importance
> > > is the description of the Routing Table, the Decision Process, the use of
> > > best routes (not paths!), etc. I pointed out multiple occurrences below,
> > > buy I need you to check the whole document for consistency.
>
> #Ahmed: The terms that I use in this documents are defined in the terminology
> section and are widely used in many implementations. However to avoid
> confusion, whenever applicable I prepended these terms with "PIC-" to make
> them distinct from similar terms in drafts or RFCs
...