Re: [sipcore] Adam Roach's Discuss on draft-ietf-sipcore-reason-q850-loc-06: (with DISCUSS and COMMENT)

Ben Campbell <ben@nostrum.com> Wed, 20 March 2019 02:26 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: sipcore@ietfa.amsl.com
Delivered-To: sipcore@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86539130EA7; Tue, 19 Mar 2019 19:26:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.679
X-Spam-Level:
X-Spam-Status: No, score=-1.679 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, HTML_MESSAGE=0.001, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rQ-CD6tZ8GFD; Tue, 19 Mar 2019 19:26:38 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0F54A130EA0; Tue, 19 Mar 2019 19:26:38 -0700 (PDT)
Received: from bens-macbook.lan (cpe-66-25-20-105.tx.res.rr.com [66.25.20.105]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id x2K2QXmX017536 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 19 Mar 2019 21:26:35 -0500 (CDT) (envelope-from ben@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1553048796; bh=GRmUO2n0HYNvz09HS5BZKNy20skyXLYvCgQ0aGjaXBI=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=vTjGbVa5wQ/MeJX+ZFiNTMW47ksO9bQTjA3F4Zyr1NwM7xBbPfF/ZZ2UdUwYmLq2m tKn6GCYMESfFtvhXknG9vPhSFk8Fk869oTBS5tjKP3nkU1Ar7gF2nNst5AnwttHTSa PfVOMfWnpP6UGYwjY7aPypmeYwyjZYFGRyAKGzpc=
X-Authentication-Warning: raven.nostrum.com: Host cpe-66-25-20-105.tx.res.rr.com [66.25.20.105] claimed to be bens-macbook.lan
From: Ben Campbell <ben@nostrum.com>
Message-Id: <DB0CB406-B31A-4D6F-A66A-CFA6A67AA622@nostrum.com>
Content-Type: multipart/signed; boundary="Apple-Mail=_E5DDFCA7-48A3-4835-9F19-E7DB836659B2"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Date: Tue, 19 Mar 2019 21:26:27 -0500
In-Reply-To: <623C7EE8-05D6-4BD6-98AA-1B5750EB522D@nostrum.com>
Cc: R.Jesske@telekom.de, iesg@ietf.org, br@brianrosen.net, draft-ietf-sipcore-reason-q850-loc@ietf.org, sipcore@ietf.org, sipcore-chairs@ietf.org
To: Adam Roach <adam@nostrum.com>
References: <155176292818.5224.17119790703710957363.idtracker@ietfa.amsl.com> <FRXPR01MB0135647633102FC4CC8E04B3F9480@FRXPR01MB0135.DEUPRD01.PROD.OUTLOOK.DE> <b192d655-4850-2f41-b993-33abb22ff145@nostrum.com> <4c7cd81c-7f4c-b893-3c55-618fe26f4836@nostrum.com> <1e95f0cf-3e09-44ac-b2e8-401dbdd38581@nostrum.com> <623C7EE8-05D6-4BD6-98AA-1B5750EB522D@nostrum.com>
X-Mailer: Apple Mail (2.3445.102.3)
Archived-At: <https://mailarchive.ietf.org/arch/msg/sipcore/qluMSn77sxQJHQULbUrxZ569x6k>
Subject: Re: [sipcore] Adam Roach's Discuss on draft-ietf-sipcore-reason-q850-loc-06: (with DISCUSS and COMMENT)
X-BeenThere: sipcore@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SIP Core Working Group <sipcore.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sipcore>, <mailto:sipcore-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sipcore/>
List-Post: <mailto:sipcore@ietf.org>
List-Help: <mailto:sipcore-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Mar 2019 02:26:41 -0000


> On Mar 19, 2019, at 9:20 PM, Ben Campbell <ben@nostrum.com> wrote:
> 
> 
> 
>> On Mar 19, 2019, at 1:43 PM, Adam Roach <adam@nostrum.com <mailto:adam@nostrum.com>> wrote:
>> 
>> On 3/15/19 1:28 PM, Adam Roach wrote:
>>> On 3/15/19 1:23 PM, Adam Roach wrote:
>>>> On 3/11/19 3:23 AM, R.Jesske@telekom.de <mailto:R.Jesske@telekom.de> wrote:
>>>>> Hi,
>>>>> Thank you for your comments. I went through the comments and here are my answers and proposals to the comments made.
>>>>> Sorry If some of you get the mail twice, since I answered in another way already.
>>>>> 
>>>>> 1.  Discuss:
>>>>> §4 ABNF
>>>>> Have incorporated the proposal.
>>>> 
>>>> 
>>>> I'm going to clear my discuss
>>>> 
>>> 
>>> Based on Paul Kyzivat's comment on the SIPCORE mailing list, I'm going to hold off and talk to Ben before I clear. Sorry for the confusion.
>>> 
>> 
>> Based on Paul's comment and on Ben's reminder that SIP fields are generally case-insensitive (both on the SIPCORE mailing list), I think the solution here is to simply remove all of the instances of "%s" in the BNF I sent. Sorry for the extra round-trip here.
>> 
> 
> Like the following? If so, I can drop this into an RFC Editor note:

Or do we also need to remove the double-quotes?

> 
> OLD:
> reason-extension =/ isup-cause-location
> isup-cause-location =  "location" EQUAL isup-location-value
> 
>    isup-location-value =
>       %s"U" /      ; for 0 0 0 0 user
>       %s"LPN" /    ; for 0 0 0 1 private network serving the local user
>       %s"LN" /     ; for 0 0 1 0 public network serving the local user
>       %s"TN" /     ; for 0 0 1 1 transit network
>       %s"RLN" /    ; for 0 1 0 0 public network serving the remote user
>       %s"RPN" /    ; for 0 1 0 1 private network serving the remote user
>       %s"LOC-6" /  ; for 0 1 1 0 spare
>       %s"INTL" /   ; for 0 1 1 1 international network
>       %s"LOC-8" /  ; for 1 0 0 0 spare
>       %s"LOC-9" /  ; for 1 0 0 1 spare
>       %s"BI" /     ; for 1 0 1 0 network beyond interworking point
>       %s"LOC-11" / ; for 1 0 1 1 spare
>       %s"LOC-12" / ; for 1 1 0 0 reserved for national use
>       %s"LOC-13" / ; for 1 1 0 1 reserved for national use
>       %s"LOC-14" / ; for 1 1 1 0 reserved for national use
>       %s"LOC-15"   ; for 1 1 1 1 reserved for national use
> 
>                        Figure 1: isup-cause-location
> NEW:
> reason-extension =/ isup-cause-location
> isup-cause-location =  "location" EQUAL isup-location-value
> 
>    isup-location-value =
>       "U" /      ; for 0 0 0 0 user
>       "LPN" /    ; for 0 0 0 1 private network serving the local user
>       "LN" /     ; for 0 0 1 0 public network serving the local user
>       "TN" /     ; for 0 0 1 1 transit network
>       "RLN" /    ; for 0 1 0 0 public network serving the remote user
>       "RPN" /    ; for 0 1 0 1 private network serving the remote user
>       "LOC-6" /  ; for 0 1 1 0 spare
>       "INTL" /   ; for 0 1 1 1 international network
>       "LOC-8" /  ; for 1 0 0 0 spare
>       "LOC-9" /  ; for 1 0 0 1 spare
>       "BI" /     ; for 1 0 1 0 network beyond interworking point
>       "LOC-11" / ; for 1 0 1 1 spare
>       "LOC-12" / ; for 1 1 0 0 reserved for national use
>       "LOC-13" / ; for 1 1 0 1 reserved for national use
>       "LOC-14" / ; for 1 1 1 0 reserved for national use
>       "LOC-15"   ; for 1 1 1 1 reserved for national use
> 
>                        Figure 1: isup-cause-location