Re: [spring] Comment on draft-alston-spring-crh-bgp-signalling-00

Andrew Alston <Andrew.Alston@liquidtelecom.com> Wed, 10 July 2019 10:26 UTC

Return-Path: <andrew.alston@liquidtelecom.com>
X-Original-To: spring@ietfa.amsl.com
Delivered-To: spring@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 70AAC1200FA for <spring@ietfa.amsl.com>; Wed, 10 Jul 2019 03:26:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.199
X-Spam-Level:
X-Spam-Status: No, score=-4.199 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AUW_agv-38sH for <spring@ietfa.amsl.com>; Wed, 10 Jul 2019 03:26:36 -0700 (PDT)
Received: from eu-smtp-delivery-182.mimecast.com (eu-smtp-delivery-182.mimecast.com [146.101.78.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 05606120099 for <spring@ietf.org>; Wed, 10 Jul 2019 03:26:35 -0700 (PDT)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-47-yuO0YGmANtyRIvSqZytd1Q-1; Wed, 10 Jul 2019 11:26:30 +0100
Received: from DBBPR03MB5415.eurprd03.prod.outlook.com (20.179.46.78) by DBBPR03MB5222.eurprd03.prod.outlook.com (10.255.78.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.19; Wed, 10 Jul 2019 10:26:28 +0000
Received: from DBBPR03MB5415.eurprd03.prod.outlook.com ([fe80::2029:6aba:b96f:8dec]) by DBBPR03MB5415.eurprd03.prod.outlook.com ([fe80::2029:6aba:b96f:8dec%4]) with mapi id 15.20.2052.020; Wed, 10 Jul 2019 10:26:28 +0000
From: Andrew Alston <Andrew.Alston@liquidtelecom.com>
To: S Moonesamy <sm+ietf@elandsys.com>, "spring@ietf.org" <spring@ietf.org>
Thread-Topic: Comment on draft-alston-spring-crh-bgp-signalling-00
Thread-Index: AQHVNv95XgJ6belB9UuET2ixxWKFDabDozbQ
Date: Wed, 10 Jul 2019 10:26:28 +0000
Message-ID: <DBBPR03MB541515B741B5A2E3CB34788BEEF00@DBBPR03MB5415.eurprd03.prod.outlook.com>
References: <6.2.5.6.2.20190710020038.100e4950@elandnews.com>
In-Reply-To: <6.2.5.6.2.20190710020038.100e4950@elandnews.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [197.155.81.57]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cf8624e1-150b-4282-ddc8-08d7052111c0
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DBBPR03MB5222;
x-ms-traffictypediagnostic: DBBPR03MB5222:
x-microsoft-antispam-prvs: <DBBPR03MB52224FCA49C23192B62C86CDEEF00@DBBPR03MB5222.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0094E3478A
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(199004)(189003)(51914003)(13464003)(14454004)(110136005)(3846002)(71190400001)(74316002)(81166006)(81156014)(8676002)(68736007)(2906002)(6116002)(8936002)(6246003)(316002)(305945005)(10916006)(99286004)(55016002)(7736002)(6506007)(478600001)(86362001)(33656002)(71200400001)(52536014)(53546011)(5660300002)(486006)(76116006)(11346002)(102836004)(26005)(25786009)(66476007)(476003)(66556008)(53936002)(76176011)(9686003)(66946007)(66446008)(446003)(64756008)(7696005)(66066001)(229853002)(186003)(256004)(2501003)(14444005)(6436002); DIR:OUT; SFP:1102; SCL:1; SRVR:DBBPR03MB5222; H:DBBPR03MB5415.eurprd03.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: LpSGccLe8XRnDvXNavDtp48Ht0MDj9NE+Mqw1u30ShsfGV5g4Rn+TUqC+nRxw688tnT88MlLUi3EClO674uxqPzXvvSgBdPT67cZtvKslpb9qFC/pQRhfzveljwYzvQFpEvYDWTooNWdu4QQ0gP7lWIMdWqVl7tkDPiCcdytHFuOsJptAF2NZwihJn+ga9M9teM85cYTgBXR5Fn53dj24DVP1Ihs6RaJiRjC6xfqbpupFg+4IyhriPZ/MmAFHvw8e0RzdYN/8GzvgEcS0zF3W5HFFJZ+KsI8mLldmyBYVcyjmY09P0W5LmXkCK82gtsCadrpo/nEft3FLlHX7VpzgzMvCOnQXLlogKuOh5Jt+dol2DeRPPVRGjN4N1l8bx5NLWq4NABdd+2qMM2xaCbbPvU9dTt4Kp95YAXdj7wp06c=
MIME-Version: 1.0
X-OriginatorOrg: liquidtelecom.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf8624e1-150b-4282-ddc8-08d7052111c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2019 10:26:28.3248 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 68792612-0f0e-46cb-b16a-fcb82fd80cb1
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Andrew.Alston@liquidtelecom.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB5222
X-MC-Unique: yuO0YGmANtyRIvSqZytd1Q-1
X-Mimecast-Spam-Score: 0
Content-Type: text/plain; charset="WINDOWS-1252"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/spring/DY1vtR5i4YvZ8zSwPcksZ0qpajU>
Subject: Re: [spring] Comment on draft-alston-spring-crh-bgp-signalling-00
X-BeenThere: spring@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Source Packet Routing in NetworkinG \(SPRING\)" <spring.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spring>, <mailto:spring-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spring/>
List-Post: <mailto:spring@ietf.org>
List-Help: <mailto:spring-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spring>, <mailto:spring-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jul 2019 10:26:39 -0000

Hi SM,

We can clarify this - the 2 and 4 come from the length in octets of a 16 bit or 32 bit unsigned integer.

Basically when reading the NLRI from the packet - think of it in code terms:

Attribute is set to two - when reading the NLRI:

Length is 2 octets - which tells you how large the NLRI is
Then you read the X octets to get the SID, following by 16 octets to get the v6 address - and repeat until (X+16)*Y = Length, as referred to above.  If that attribute isn't there, or is not set to either 2 or 4 - your ability to read the NLRI is impaired.  So yes, the update is malformed if you are carrying the SAFI and either missing that attribute or that attribute is not set to 2 or 4.

We'll look at clarifying the wording - thanks for the input.

Thanks

Andrew


-----Original Message-----
From: S Moonesamy <sm+ietf@elandsys.com> 
Sent: Wednesday, 10 July 2019 12:10
To: Andrew Alston <Andrew.Alston@liquidtelecom.com>; spring@ietf.org
Subject: Comment on draft-alston-spring-crh-bgp-signalling-00

Hi Andrew,

I took a quick look at draft-alston-spring-crh-bgp-signalling-00.  In Section 3.1, there is the following:

   "Since SIDs in the context of a compressed routing header can be
    either 16bit of 32bit, the attribute value MUST be either 2 or 4 and
    the attribute MUST be ignored if this is not the case."

Where does the 2 or 4 come from?  Is the draft trying to specify that the compressed routing header is malformed if the attribute value is not 2 or 4?

Regards,
S. Moonesamy