Re: [Stox] WGLC for draft-ietf-stox-presence-05

Philipp Hancke <fippo@goodadvice.pages.de> Thu, 17 October 2013 21:43 UTC

Return-Path: <fippo@goodadvice.pages.de>
X-Original-To: stox@ietfa.amsl.com
Delivered-To: stox@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C982011E81BD for <stox@ietfa.amsl.com>; Thu, 17 Oct 2013 14:43:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.429
X-Spam-Level:
X-Spam-Status: No, score=-1.429 tagged_above=-999 required=5 tests=[AWL=-0.300, BAYES_00=-2.599, J_CHICKENPOX_43=0.6, SARE_MLH_Stock1=0.87]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZfO-WnMbePxv for <stox@ietfa.amsl.com>; Thu, 17 Oct 2013 14:43:35 -0700 (PDT)
Received: from lo.psyced.org (lost.IN.psyced.org [188.40.42.221]) by ietfa.amsl.com (Postfix) with ESMTP id 3161111E8192 for <stox@ietf.org>; Thu, 17 Oct 2013 14:43:32 -0700 (PDT)
Received: from [192.168.0.94] (74-93-184-209-Oregon.hfc.comcastbusiness.net [74.93.184.209]) (authenticated bits=0) by lo.psyced.org (8.14.3/8.14.3/Debian-9.4) with ESMTP id r9HLhQqI013022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <stox@ietf.org>; Thu, 17 Oct 2013 23:43:30 +0200
Message-ID: <526059FD.7040201@goodadvice.pages.de>
Date: Thu, 17 Oct 2013 23:43:25 +0200
From: Philipp Hancke <fippo@goodadvice.pages.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: stox@ietf.org
References: <7228C79F-98B8-4AFE-BB7B-99ACAA269EA5@jitsi.org>
In-Reply-To: <7228C79F-98B8-4AFE-BB7B-99ACAA269EA5@jitsi.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Stox] WGLC for draft-ietf-stox-presence-05
X-BeenThere: stox@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: SIP-TO-XMPP Working Group discussion list <stox.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stox>, <mailto:stox-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/stox>
List-Post: <mailto:stox@ietf.org>
List-Help: <mailto:stox-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stox>, <mailto:stox-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Oct 2013 21:43:40 -0000

> Please review the document and bring any remaining issues, or issues whose resolution is not satisfactory, to the attention of the Working Group on this list before October 22. If after reviewing the document you find it complete and do not have any comments, please send a note to that effect as well.

LGTM, with the usual nits:

- 3.2.1 Establishing
   should probably mention what is established (a presence 
subscription), same for the rest of the section headers, also in 3.3.

- "Upon receiving the first NOTIFY with a subscription state of 
active..." -- I wanted to comment that the xmpp subscription state 
should be none+out, but it's no longer clear to me whether I am assuming 
too much intelligence in the gateway.

- after example 8, should the unsubscribed stana be sent when receiving 
an ack for that (which is not shown)? It doesn't matter much however.

- "or, if a subscription already exists in the XMPP user's roster, 
discard the subscribe request" -- I think 6121 says the server should 
send subscribed without bothering the user. Simplifies the following 
paragraph.

- "translating the NOTIFU" before example 20 is a typo obviously.