Re: [tcpm] [Technical Errata Reported] RFC8257 (6697)

tuexen@fh-muenster.de Thu, 04 November 2021 08:26 UTC

Return-Path: <tuexen@fh-muenster.de>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A119A3A0AB8; Thu, 4 Nov 2021 01:26:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.834
X-Spam-Level:
X-Spam-Status: No, score=-0.834 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.4, SPF_SOFTFAIL=0.665, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wai1oyHUiP5Q; Thu, 4 Nov 2021 01:26:26 -0700 (PDT)
Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8B6A23A0AA8; Thu, 4 Nov 2021 01:26:24 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1140:c3d:fd16:4b5a:f6b7:a84d]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id BF90B721E280B; Thu, 4 Nov 2021 09:26:15 +0100 (CET)
Content-Type: multipart/signed; boundary="Apple-Mail=_F8A86498-004C-4A4D-BB7F-01D2B4822EFC"; protocol="application/pkcs7-signature"; micalg=sha-256
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\))
From: tuexen@fh-muenster.de
In-Reply-To: <DFE6EB68-DC06-4958-88A4-FD8ADF769226@apple.com>
Date: Thu, 4 Nov 2021 09:26:14 +0100
Cc: Bob Briscoe <ietf@bobbriscoe.net>, "tcpm-chairs@ietf.org" <tcpm-chairs@ietf.org>, RFC Errata System <rfc-editor@rfc-editor.org>, dthaler@microsoft.com, Praveen Balasubramanian <pravb@microsoft.com>, lars@netapp.com, Extensions <tcpm@ietf.org>, "tsv-ads@ietf.org" <tsv-ads@ietf.org>, Neal Cardwell <ncardwell@google.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1576DC04-F095-47BB-8349-7AD040270A14@fh-muenster.de>
References: <20210928071818.BE0D7F40865@rfc-editor.org> <96ce4984-3678-9bdf-6b76-d7ba1bd42dcc@bobbriscoe.net> <CADVnQymMRzvs_4QRuSziYXfwu6ttKfak5cv5G=eBRvX8qOQKWw@mail.gmail.com> <d1514f76-fc40-fa73-c953-efcb70fe6901@bobbriscoe.net> <abd8609d-b643-2911-f082-9ce2ebe41bbd@bobbriscoe.net> <CB870F54-4E2B-43C4-9674-7D847081D96D@fh-muenster.de> <DFE6EB68-DC06-4958-88A4-FD8ADF769226@apple.com>
To: Vidhi Goel <vidhi_goel@apple.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/YZKB3t1X7hwY06wnQq1_0q-DX9w>
X-Mailman-Approved-At: Thu, 04 Nov 2021 08:34:35 -0700
Subject: Re: [tcpm] [Technical Errata Reported] RFC8257 (6697)
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Nov 2021 08:26:32 -0000

> On 4. Nov 2021, at 01:37, Vidhi Goel <vidhi_goel@apple.com> wrote:
> 
>>> The status of this erratum is 'Reported'. I think some consensus was reached on the list. What happens now? Who is meant to propose updated text for the erratum based on the discussion?
>> Hi Bob,
>> 
>> as far as I know, the WG chairs can't change erratas. That might be possible for AD, I think,
>> but I'm not sure.
> 
> I am a bit new to the errata process and would like to understand a bit more about next steps. Based on Bob’s suggestion about updated text and feedback from others, how do we proceed to make the necessary change to the RFC 8257?
> Is the only thing we can do now is somehow update the Suggestion in errata itself? When would the update me applied to the RFC?
Hi Vidhi,

an RFC can be changed when it is published. Erratas can be filed, but can't be changed by
the submitter. I think ADs can change Erratas. So if a group agrees on text changes for
an RFC, I think ADs have the power to change Erratas and therefore the text change can
go in via this method.
If you actually want to change an RFC, a bis document needs to be published.

Best regards
Michael 
> 
> 
> Thanks,
> Vidhi
> 
>> On Nov 3, 2021, at 12:02 PM, tuexen@fh-muenster.de wrote:
>> 
>>> On 3. Nov 2021, at 19:09, Bob Briscoe <ietf@bobbriscoe.net> wrote:
>>> 
>>> TCPM chairs,
>>> 
>>> The status of this erratum is 'Reported'. I think some consensus was reached on the list. What happens now? Who is meant to propose updated text for the erratum based on the discussion?
>> Hi Bob,
>> 
>> as far as I know, the WG chairs can't change erratas. That might be possible for AD, I think,
>> but I'm not sure.
>> 
>> Best regards
>> Michael
>>> 
>>> 
>>> Bob
>>> 
>>> On 01/10/2021 14:12, Bob Briscoe wrote:
>>>> Neal,
>>>> 
>>>> On 30/09/2021 16:43, Neal Cardwell wrote:
>>>>> I agree with the points made by Vidhi and Bob, and really like Bob's text.
>>>>> 
>>>>> In the suggested text there may be a typo; I believe we want s/SND.UNA/SND.NXT/.
>>>> 
>>>> [BB] Agree (and your next point about solely ECN indications).
>>>> 
>>>> I only said SND.UNA 'cos I was looking back at this earlier sentence in the RFC, and I copied the idea without engaging brain:
>>>>  o  DCTCP.WindowEnd: the TCP sequence number threshold when one
>>>>     observation window ends and another is to begin; initialized to
>>>>     SND.UNA.
>>>> 
>>>> Why does this say SND.UNA? Is this another erratum? I believe the Linux code initializes to SND.NXT in dctcp_reset(), which is called from dctcp_init():
>>>> https://elixir.bootlin.com/linux/v4.7/source/net/ipv4/tcp_dctcp.c#L78
>>>> 
>>>> BTW, step 7 correctly says SND.NXT:
>>>>  7.  Determine the end of the next observation window:
>>>> 
>>>>         DCTCP.WindowEnd = SND.NXT
>>>> 
>>>> 
>>>> 
>>>> 
>>>> Bob
>>>> 
>>>>> And probably we want to be more specific about only suppressing further ECN-based reductions (further loss-triggered reductions would be good to allow). I'm posting my suggested tweaks in blue, starting from Bob's nice green text:
>>>>> 
>>>>> SUGGESTED:
>>>>> ==========
>>>>> 
>>>>> 3.4. Congestion Window Reduction
>>>>>  Rather than always halving the congestion window as described in
>>>>>  [RFC3168]
>>>>> , on the arrival of ECN congestion feedback,
>>>>> the sender SHOULD 
>>>>>  update cwnd as follows:
>>>>> 
>>>>>     cwnd = cwnd * (1 - DCTCP.Alpha / 2)
>>>>> 
>>>>>  Just as specified in [RFC3168], DCTCP does not react to congestion
>>>>>  indications more than once for every window of data. 
>>>>> Therefore, as 
>>>>>  for RFC3168 ECN, it sets the variable for the end of congestion
>>>>>  window reduced (CWR) state to 
>>>>> SND.NXT
>>>>> and suppresses further
>>>>> 
>>>>> ECN-triggered
>>>>> reductions until this TCP sequence number is acknowledged. Periods
>>>>>  of CWR state are triggered by congestion feedback, and therefore
>>>>>  occur at times unrelated to the continuous cycle of observation
>>>>>  windows used to update DCTCP.Alpha in Section 3.3.
>>>>> 
>>>>> 
>>>>>  The setting of the CWR bit is also as per [RFC3168].  This is 
>>>>>  required for interoperation with classic ECN receivers due to 
>>>>>  potential misconfigurations.
>>>>> 
>>>>> 3.
>>>>> 5.  Handling of Congestion Window Growth...
>>>>> 
>>>>> neal
>>>>> 
>>>>> 
>>>>> On Thu, Sep 30, 2021 at 11:22 AM Bob Briscoe <in@bobbriscoe.net> wrote:
>>>>> Vidhi,
>>>>> 
>>>>> You're right. It's incorrect to have the window reduction hanging off the end of the list of steps for updating the EWMA.
>>>>> 
>>>>> To make this concrete, here's some specific additional text (in green for those with HTML mail readers). Also, rather than splitting into sub-subsections, I have suggested that Item 9. of the list in subsection 3.3 is moved out of the list, and instead forms the basis of a new subsection 3.4. entitled "Congestion Window Reduction". 
>>>>> 
>>>>> CURRENT:
>>>>> ========
>>>>>  9.  Rather than always halving the congestion window as described in
>>>>>      [RFC3168], the sender SHOULD update cwnd as follows:
>>>>> 
>>>>>         cwnd = cwnd * (1 - DCTCP.Alpha / 2)
>>>>> 
>>>>>  Just as specified in [RFC3168], DCTCP does not react to congestion
>>>>>  indications more than once for every window of data.  The setting of
>>>>>  the CWR bit is also as per [RFC3168].  This is required for
>>>>>  interoperation with classic ECN receivers due to potential
>>>>>  misconfigurations.
>>>>> 
>>>>> 
>>>>> 3.4
>>>>> .  Handling of Congestion Window Growth...
>>>>> 
>>>>> 
>>>>> SUGGESTED:
>>>>> ==========
>>>>> 
>>>>> 3.4. Congestion Window Reduction
>>>>>  Rather than always halving the congestion window as described in
>>>>>  [RFC3168]
>>>>> , on the arrival of congestion feedback,
>>>>> the sender SHOULD 
>>>>>  update cwnd as follows:
>>>>> 
>>>>>     cwnd = cwnd * (1 - DCTCP.Alpha / 2)
>>>>> 
>>>>>  Just as specified in [RFC3168], DCTCP does not react to congestion
>>>>>  indications more than once for every window of data. 
>>>>> Therefore, as 
>>>>>  for RFC3168 ECN, it sets the variable for the end of congestion
>>>>>  window reduced (CWR) state to SND.UNA and suppresses further
>>>>>  reductions until this TCP sequence number is acknowledged. Periods
>>>>>  of CWR state are triggered by congestion feedback, and therefore
>>>>>  occur at times unrelated to the continuous cycle of observation
>>>>>  windows used to update DCTCP.Alpha in Section 3.3.
>>>>> 
>>>>> 
>>>>>  The setting of the CWR bit is also as per [RFC3168].  This is 
>>>>>  required for interoperation with classic ECN receivers due to 
>>>>>  potential misconfigurations.
>>>>> 
>>>>> 
>>>>> 3.5.  Handling of Congestion Window Growth...
>>>>> 
>>>>> Then the of numbering all subsequent subsections of section 3. will increment by 0.1.
>>>>> 
>>>>> 
>>>>> 
>>>>> Bob
>>>>> 
>>>>> On 28/09/2021 08:18, RFC Errata System wrote:
>>>>>> The following errata report has been submitted for RFC8257,
>>>>>> "Data Center TCP (DCTCP): TCP Congestion Control for Data Centers".
>>>>>> 
>>>>>> --------------------------------------
>>>>>> You may review the report below and at:
>>>>>> 
>>>>>> https://www.rfc-editor.org/errata/eid6697
>>>>>> 
>>>>>> 
>>>>>> --------------------------------------
>>>>>> Type: Technical
>>>>>> Reported by: Vidhi Goel 
>>>>>> <vidhi_goel@apple.com>
>>>>>> 
>>>>>> 
>>>>>> Section: 3.3
>>>>>> 
>>>>>> Original Text
>>>>>> -------------
>>>>>> The below pseudocode follows after DCTCP.Alpha is updated on ACK processing. This is wrong as cwnd should only be reduced using DCTCP.Alpha when ECE is received. 
>>>>>> 
>>>>>> 9. Rather than always halving the congestion window as described in
>>>>>>      [RFC3168], the sender SHOULD update cwnd as follows:
>>>>>> 
>>>>>>         cwnd = cwnd * (1 - DCTCP.Alpha / 2)
>>>>>> 
>>>>>> Corrected Text
>>>>>> --------------
>>>>>> Instead, a new paragraph for Congestion Response to ECN feedback would be much clearer. First start with RFC 3168's response to ECE and then provide DCTCP's response to ECE.
>>>>>> 
>>>>>> I am thinking splitting section 3.3 into two sub-sections - 
>>>>>> 3.3.1 Computation of DCTCP.Alpha
>>>>>> 3.3.2 Congestion Response to ECE at sender
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> Notes
>>>>>> -----
>>>>>> Although RFC 8257 refers to RFC 3168 congestion window halving at step 9, but it is confusing to put it right after step 8.
>>>>>> 
>>>>>> Instructions:
>>>>>> -------------
>>>>>> This erratum is currently posted as "Reported". If necessary, please
>>>>>> use "Reply All" to discuss whether it should be verified or
>>>>>> rejected. When a decision is reached, the verifying party  
>>>>>> can log in to change the status and edit the report, if necessary. 
>>>>>> 
>>>>>> --------------------------------------
>>>>>> RFC8257 (draft-ietf-tcpm-dctcp-10)
>>>>>> --------------------------------------
>>>>>> Title               : Data Center TCP (DCTCP): TCP Congestion Control for Data Centers
>>>>>> Publication Date    : October 2017
>>>>>> Author(s)           : S. Bensley, D. Thaler, P. Balasubramanian, L. Eggert, G. Judd
>>>>>> Category            : INFORMATIONAL
>>>>>> Source              : TCP Maintenance and Minor Extensions
>>>>>> Area                : Transport
>>>>>> Stream              : IETF
>>>>>> Verifying Party     : IESG
>>>>>> 
>>>>>> _______________________________________________
>>>>>> tcpm mailing list
>>>>>> 
>>>>>> tcpm@ietf.org
>>>>>> https://www.ietf.org/mailman/listinfo/tcpm
>>>>> 
>>>>> -- 
>>>>> ________________________________________________________________
>>>>> Bob Briscoe                               
>>>>> http://bobbriscoe.net/
>>>>> _______________________________________________
>>>>> tcpm mailing list
>>>>> tcpm@ietf.org
>>>>> https://www.ietf.org/mailman/listinfo/tcpm
>>>> 
>>>> -- 
>>>> ________________________________________________________________
>>>> Bob Briscoe                               
>>>> http://bobbriscoe.net/
>>> 
>>> -- 
>>> ________________________________________________________________
>>> Bob Briscoe                               
>>> http://bobbriscoe.net/
>> 
>