IETF Logo Mail Archive

Re: [tcpm] [Gen-art] Genart last call review of draft-ietf-tcpm-alternativebackoff-ecn-09

Russ Housley <housley@vigilsec.com> Fri, 17 August 2018 18:48 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E1D06130F01 for <tcpm@ietfa.amsl.com>; Fri, 17 Aug 2018 11:48:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NfA5mpvblcGn for <tcpm@ietfa.amsl.com>; Fri, 17 Aug 2018 11:48:51 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A7DE130F21 for <tcpm@ietf.org>; Fri, 17 Aug 2018 11:48:51 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 8E282300596 for <tcpm@ietf.org>; Fri, 17 Aug 2018 14:41:28 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z4i4-q9ddec3 for <tcpm@ietf.org>; Fri, 17 Aug 2018 14:41:26 -0400 (EDT)
Received: from a860b60074bd.home (pool-71-127-50-4.washdc.fios.verizon.net [71.127.50.4]) by mail.smeinc.net (Postfix) with ESMTPSA id B1DE7300433; Fri, 17 Aug 2018 14:41:26 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <153452985801.18009.2900521078281198682@ietfa.amsl.com>
Date: Fri, 17 Aug 2018 14:41:26 -0400
Cc: tcpm@ietf.org, IETF <ietf@ietf.org>, draft-ietf-tcpm-alternativebackoff-ecn.all@ietf.org
Content-Transfer-Encoding: 7bit
Message-Id: <E4D19FE5-DB73-4220-B805-8CEAA8D7B79C@vigilsec.com>
References: <153452985801.18009.2900521078281198682@ietfa.amsl.com>
To: IETF Gen-ART <gen-art@ietf.org>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/aUeWFKjQnHDopNqIdr4vuOgkiK4>
Subject: Re: [tcpm] [Gen-art] Genart last call review of draft-ietf-tcpm-alternativebackoff-ecn-09
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Aug 2018 18:48:53 -0000

See inline.

> On Aug 17, 2018, at 2:17 PM, Russ Housley <housley@vigilsec.com> wrote:
> 
> Reviewer: Russ Housley
> Review result: Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Document: draft-ietf-tcpm-alternativebackoff-ecn-09
> Reviewer: Russ Housley
> Review Date: 2018-08-17
> IETF LC End Date: 2018-08-28
> IESG Telechat date: unknown
> 
> Summary: Ready
> 
> 
> Major Concerns:
> 
> None
> 
> 
> Minor Concerns:
> 
> Section 2: Please update the first paragraph to reference RFC 8174
> in addition to RFC 2119, as follows: 
> 
>   The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
>   "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and
>   "OPTIONAL" in this document are to be interpreted as described in BCP
>   14 [RFC2119] [RFC8174] when, and only when, they appear in all
>   capitals, as shown here.
> 
> Section 12.1: Please add a normative reference to RFC 7926.

Oops.  This should say RFC 8174.

> 
> 
> Nits:
> 
> Abstract: s/RFC3168/RFC 3168/
> 
> Section 1: s/RFC8087 [RFC8087]/[RFC8087]/
> 
> Section 1 says:
> 
>   However, currently used loss-based congestion control mechanisms
>   cannot always utilise a bottleneck link well where there are short
>   queues.
> 
> I stumbled on this sentence.  Maybe it would read better if you said
> that current mechanisms sometimes provides poor link utilization when
> queues are short.
> 
> Section 1: s/allow for short queues only/allow only for short queues/
> 
> Section 6: s/RFC3168 states/[RFC3168] states/ and
>           s/dropped packet [RFC3168]./dropped packet./
> 
> Section 6: s/the TCPM WG or IESG/the TCPM WG or the IESG/
> 
> Section 7" s/TCPM working group/TCPM Working Group/ or /TCPM WG/
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email