[tcpm] [Errata Held for Document Update] RFC8257 (6697)

RFC Errata System <rfc-editor@rfc-editor.org> Fri, 13 May 2022 21:27 UTC

Return-Path: <wwwrun@rfcpa.amsl.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8DD2EC18514B; Fri, 13 May 2022 14:27:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.646
X-Spam-Level:
X-Spam-Status: No, score=-1.646 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W1telu0s7DgX; Fri, 13 May 2022 14:27:18 -0700 (PDT)
Received: from rfcpa.amsl.com (rfc-editor.org [50.223.129.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2869EC18514A; Fri, 13 May 2022 14:27:18 -0700 (PDT)
Received: by rfcpa.amsl.com (Postfix, from userid 499) id 19D5DE5296; Fri, 13 May 2022 14:27:18 -0700 (PDT)
To: vidhi_goel@apple.com, sbens@microsoft.com, dthaler@microsoft.com, pravb@microsoft.com, lars@netapp.com, glenn.judd@morganstanley.com
From: RFC Errata System <rfc-editor@rfc-editor.org>
Cc: martin.h.duke@gmail.com, iesg@ietf.org, tcpm@ietf.org, rfc-editor@rfc-editor.org
Content-Type: text/plain; charset="UTF-8"
Message-Id: <20220513212718.19D5DE5296@rfcpa.amsl.com>
Date: Fri, 13 May 2022 14:27:18 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/pxQzlcY1CRYiwSkF1F0uddegYd8>
X-Mailman-Approved-At: Sun, 15 May 2022 14:19:08 -0700
Subject: [tcpm] [Errata Held for Document Update] RFC8257 (6697)
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 May 2022 21:27:22 -0000

The following errata report has been held for document update 
for RFC8257, "Data Center TCP (DCTCP): TCP Congestion Control for Data Centers". 

--------------------------------------
You may review the report below and at:
https://www.rfc-editor.org/errata/eid6697

--------------------------------------
Status: Held for Document Update
Type: Technical

Reported by: Vidhi Goel <vidhi_goel@apple.com>
Date Reported: 2021-09-28
Held by: Martin Duke (IESG)

Section: 3.3

Original Text
-------------
The below pseudocode follows after DCTCP.Alpha is updated on ACK processing. This is wrong as cwnd should only be reduced using DCTCP.Alpha when ECE is received. 

9. Rather than always halving the congestion window as described in
       [RFC3168], the sender SHOULD update cwnd as follows:

          cwnd = cwnd * (1 - DCTCP.Alpha / 2)

Corrected Text
--------------
Instead, a new paragraph for Congestion Response to ECN feedback would be much clearer. First start with RFC 3168's response to ECE and then provide DCTCP's response to ECE.

I am thinking splitting section 3.3 into two sub-sections - 
3.3.1 Computation of DCTCP.Alpha
3.3.2 Congestion Response to ECE at sender



Notes
-----
Although RFC 8257 refers to RFC 3168 congestion window halving at step 9, but it is confusing to put it right after step 8.

Literally interpreted, a window with no congestion marks would reduce the cwnd, which is wrong.

--------------------------------------
RFC8257 (draft-ietf-tcpm-dctcp-10)
--------------------------------------
Title               : Data Center TCP (DCTCP): TCP Congestion Control for Data Centers
Publication Date    : October 2017
Author(s)           : S. Bensley, D. Thaler, P. Balasubramanian, L. Eggert, G. Judd
Category            : INFORMATIONAL
Source              : TCP Maintenance and Minor Extensions
Area                : Transport
Stream              : IETF
Verifying Party     : IESG