Re: [Teas] AD review of draft-ietf-teas-mpls-tp-rsvpte-ext-associated-lsp
"Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com> Sun, 08 February 2015 19:03 UTC
Return-Path: <rgandhi@cisco.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 124061A1DBE; Sun, 8 Feb 2015 11:03:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6JpAnETP78mh; Sun, 8 Feb 2015 11:02:50 -0800 (PST)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E16F1A1DE1; Sun, 8 Feb 2015 11:02:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=10253; q=dns/txt; s=iport; t=1423422170; x=1424631770; h=from:to:cc:subject:date:message-id:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=iNDd8uJDdjhwoBD+dyErAyo/XKQm1zzZkSldFgr6Bp8=; b=kTxj7oOYHxpZjEthgrIVBNgefzpGH7ZU0Dtlrx4vBtEORyW1ZyedWHrk T22XkY/7cXT2J3Wi27uPhOXZ+p8LLfuCu5e+KzGKUwy7sHAkiVP1atnGl /AeRV1xldch7lkRuObtvBiGc0JV2ECoSAJF1lQaKXEXfFdGWv5u8Lpqd+ c=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: An4FAAKy11StJV2S/2dsb2JhbABcgwaBLATIZwKBD0MBAQEBAQF8hA0BAQQ6PxIBCBgeQiUBAQQOBYgtyFMBAQEBAQEBAQEBAQEBAQEBAQEaig6FCBEBJSsHAoQoBY04gWOJLIEYgwOCRoVSgn+DPiKDbm+BAgkXBB5+AQEB
X-IronPort-AV: E=Sophos;i="5.09,540,1418083200"; d="scan'208";a="394515780"
Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by rcdn-iport-4.cisco.com with ESMTP; 08 Feb 2015 19:02:49 +0000
Received: from xhc-rcd-x03.cisco.com (xhc-rcd-x03.cisco.com [173.37.183.77]) by rcdn-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id t18J2nn6027864 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 8 Feb 2015 19:02:49 GMT
Received: from xmb-aln-x07.cisco.com ([169.254.2.2]) by xhc-rcd-x03.cisco.com ([173.37.183.77]) with mapi id 14.03.0195.001; Sun, 8 Feb 2015 13:02:48 -0600
From: "Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com>
To: "adrian@olddog.co.uk" <adrian@olddog.co.uk>, "draft-ietf-teas-mpls-tp-rsvpte-ext-associated-lsp.all@ietf.org" <draft-ietf-teas-mpls-tp-rsvpte-ext-associated-lsp.all@ietf.org>
Thread-Topic: AD review of draft-ietf-teas-mpls-tp-rsvpte-ext-associated-lsp
Thread-Index: AdA2UPHrR6Yon7iGSv+fwOmNm2NwiABoSkuAAvoFzwA=
Date: Sun, 08 Feb 2015 19:02:48 +0000
Message-ID: <D0FD1C08.4F3E3%rgandhi@cisco.com>
In-Reply-To: <D0E91A3A.4D26B%rgandhi@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.3.5.130515
x-originating-ip: [10.82.208.216]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3425B5BC550FA74BA1E33F5318D9434D@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/teas/KFJ3KaLwhWX40g_PKCRZXTbCHWw>
Cc: "Alvaro Retana (aretana)" <aretana@cisco.com>, Lou Berger <lberger@labn.net>, "teas@ietf.org" <teas@ietf.org>
Subject: Re: [Teas] AD review of draft-ietf-teas-mpls-tp-rsvpte-ext-associated-lsp
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Feb 2015 19:03:01 -0000
Hi all, We have posted a new revision (01) to address the comments listed below (except the last one, <RG2>). Welcome your review comments. Many thanks, Rakesh On 2015-01-24 10:23 AM, "Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com> wrote: >Thank you Adrian for your detailed review comments. > >Please see inline .. <RG>.. > >On 2015-01-22 9:37 AM, "Adrian Farrel" <adrian@olddog.co.uk> wrote: > >>Authors, >> >>Thanks for this document which I found clear and not too long. >> >>I have done my usual AD review to try to flush out any issues that >>might otherwise show up in IETF last call or IESG review. >> >>The only largish issue I have is about error conditions. Pretty much the >>only error handling I see is in 5.3 where you have: >> >> An egress node, upon receiving a Path message containing an >> ASSOCIATION or Extended ASSOCIATION Object with Association Type set >> to "Single Sided Associated Bidirectional LSP" MUST create an LSP in >> the reverse direction or reject the Path message by sending a >> PathErr. >> >>...but you don't say what reason code to give. >> >>You need to handle some other error conditions such as... >> >>**** race conditions >>**** what if the association is triggered by both ends at the same time? >>**** what if the reverse dirn LSP has already been associated with >> something else? >> >>**** failure conditions >>**** what if not willing or able to associate? >>**** what if set-up of reverse LSP fails? >>**** what if requested REVERSE LSP parameters are not acceptable? >>**** what if the remote end point doesn't support the association >> >> mechanism defined here? how will the initiator know? > > ><RG> Please refer to another email thread to address this comment. <RG2> Updated in the new revision. > > >> >> >>I also have some smaller points as set out below. >> >>I'll put the I-D into "revised I-D needed" state while we discuss these >>points and while you produce an update. >> >>Thanks for the work, >>Adrian >> >>==== >> >>You have a different number of font-page authors and names in the >>Authors' Addresses section. >> >>Looks like Fan Yang and Weilian Jiang should be moved to a >>Contributors section. > ><RG> Fixed. ><RG> FYI, I also fixed WG from CCAMP to TEAS at the top. > >> >>--- >> >>Section 1 is OK, but it would have been better to just list the relevant >>requirements (7, 11, 12, 50) and then the additional requirement (14). >> >>Probably no need to change now, but my preference is to avoid the risk >>of introducing an error during the copying or editorial process. If you >>feel like making this change, I would be happier. > ><RG> Find it easier to read the document when this text is in the same >document. Prefer to keep it:) > > >> >>--- >> >>Because you use RBNF in section 4, you need to add a statement to >>Section 2 like: >> >> This document uses the Routing Backus-Naur Form (RBNF) to define >> message formats as defined in [RFC5511]. >> >>And then, of course, add a normative reference. > ><RG> Added. > >> >>--- >> >>I think 2.1.1 is missing an important statement about co-routing. >> >>"A pair of reverse unidirectional LSPs that are associated to form an >>associated bidirectional LSP do not necessarily follow the same path >>through the network. If they do follow the same path, they are known as >>'co-routed'." > > ><RG> Saw the email exchange with Lou. Thanks Lou. I am assuming we are >keeping the text as is. ><RG> Note that this document does not discuss anything about co-routed >LSPs. > > >> >>--- >> >>3.1 >> >> This section provides an overview and definition of the models for >> provisioning bidirectional LSPs. >> >>This is missing the word "associated" to read "associated bidirectional" > ><RG> Added. > >> >>--- >> >>Shouldn't 3.1.1 also mention the REVERSE_LSP Object. Something like... >> >> For the single sided provisioning, the Traffic Engineering (TE) >> tunnel is configured only on one endpoint. An LSP for this tunnel is >> initiated by the initiating endpoint with the (Extended) ASSOCIATION >> Object inserted in the Path message. The other endpoint then creates >> the corresponding reverse TE tunnel and signals the reverse LSP in >> response using information from the REVERSE_LSP Object if present. > ><RG> Yes, added. > >> >>--- >> >>3.1.2 >> >>Pedantry, but... >> >>OLD >> For the double sided provisioning, two unidirectional TE tunnels are >> configured independently on both endpoints. >>NEW >> For the double sided provisioning, two unidirectional TE tunnels are >> configured independently, one on each endpoint. >>END > ><RG> Added. > >> >>--- >> >>3.2 >> >> This section provides an overview of the association signaling >> methods for the bidirectional LSPs. >> >>Again, this is missing "associated" > ><RG> Added. > >> >>--- >> >>3.2.1 >> >>OLD >> LSP1 is then signaled with an (Extended) ASSOCIATION Object inserted >> in the Path message, in which the Association Type indicating single >> sided provisioning. >>NEW >> LSP1 is then signaled with an (Extended) ASSOCIATION Object inserted >> in the Path message, in which the Association Type indicating single >> sided provisioning is included. >>END > ><RG> Fixed. > >> >>--- >> >>3.2.2 >> >>OLD >> For the double sided provisioning model, both LSP1 and LSP2 are >> signaled independently with (Extended) ASSOCIATION Object inserted in >> the Path message, in which the Association Type indicating double >> sided provisioning. >>NEW >> For the double sided provisioning model, both LSP1 and LSP2 are >> signaled independently with (Extended) ASSOCIATION Object inserted in >> the Path message, in which the Association Type indicating double >> sided provisioning is included. > ><RG> Fixed. > >> >>--- >> >>3.2.2 needs to include some comment about how the two LSPs are selected >>to be associated. I think this is simply "by management action applied >>at both end points", although I wonder whether it is enough to apply the >>action at just one end point because the association object will achieve >>the desired result. >> >>Please think about this and add a note. > > ><RG> This is somewhat in Section 3.1.2. ><RG> We could add something like: >The LSPs to be selected for association are provisioned by the management >action applied at both endpoints. > > > >> >>--- >> >>Section 3.3.1 is fine as it is, but I think that it makes it look like >>the REVERSE LSP object is only used for asymmetric b/w. Perhaps... >> >>OLD >> As >> described in this document, addition of the REVERSE_LSP Object also >> allows the initiating node to control the reverse LSP by including >> other existing objects in a REVERSE_LSP Object. >>NEW >> As >> described in Section 4.4, addition of the REVERSE_LSP Object also >> allows the initiating node to control other aspects of the reverse >> LSP (such as its path) by including other subobjects in a REVERSE_LSP >> Object. >>END > ><RG> Fixed. > >> >>--- >> >>For clarity 3.4 needs to observe that multiple association objects may >>be present in the signaling of a single LSP. > ><RG> Adding following: > An LSP MAY signal multiple (Extended) ASSOCIATION Objects with different >Association Types. > > >> >>--- >> >>4.2 >> >> The new Association Types are defined as follows (values are >> temporary early allocations as per RFC7120): >> >>Delete the bit in brackets, please, so that we don't accidentally find >>it in the published RFC. Your message is already in 6.1 (which is good). > ><RG> Fixed. > >> >>--- >> >>4.4.1 >> >> Class_Num = 203 (of the form 11bbbbbb), C_Type = 1 (values are >> temporary early allocations as per RFC7120) >> >>Same thing. Please remove the bit about early allocation. >> >>(BTW, you have "of the form 11bbbbbb" twice in this section. > ><RG> Fixe both. > >> >>--- >> >>4.4.2 or 5.2 >> >>Maybe... >> >> The REVERSE_LSP object MUST NOT be included in a REVERSE_LSP object. > ><RG> Added in Section 5.2. > >> >>--- >> >>5.2 >> >> An >> egress node MUST tear down and reestablish a new reverse LSP when >> REVERSE_LSP Object is either added or removed in the received Path >> message. >> >>That's confusing! >>- Why is modification of an existing LSP not allowed? >>- Why does removal of the REVERSE_LSP object require tearing down and >> reestablishment since all that has happened is that the requirements >> for the reverse LSP have been relaxed? >>- Why does addition of the REVERSE_LSP necessarily require tear down >> and reestablishment when the existing LSP might already satisfy the >> requirements? >>- Is make-before-break used or is this assumed to be an out-of-service >> operation? If out-of-service you need to describe how that is >> achieved (e.g., using LI). > > ><RG> Understand and agree with above comments. There are various scenarios >where change may lead to in-place modification, MBB or setup and teardown >(which may depend on implementation). > ><RG> How about something like following: >An egress node MAY tear down and reestablish a new reverse LSP, or trigger >re-optimization or in-place modification when > REVERSE_LSP Object is either added or removed in the received Path > message (which may depend on the local policy). > > >> >>--- >> >>5.3 has >> >> If REVERSE_LSP Object is not present in the received Path message of >> the LSP, the egress node SHOULD use the LSP properties from the >> received LSP Path message to signal the LSP in the reverse direction >> (which may depend on the local policy). >> >>This worries me. Do you mean that in the absence of a REVERSE_LSP object >>containing an ERO, the reverse LSP MUST be co-routed with the forward >>LSP? >> > <RG2> Ack, Will address this comment. > > > > >Many thanks Adrian for the great review. > >Regards, >Rakesh > > >> >
- [Teas] AD review of draft-ietf-teas-mpls-tp-rsvpt… Adrian Farrel
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Lou Berger
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Rakesh Gandhi (rgandhi)
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Adrian Farrel
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Rakesh Gandhi (rgandhi)
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Rakesh Gandhi (rgandhi)
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Lou Berger
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Adrian Farrel
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Rakesh Gandhi (rgandhi)
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Lou Berger
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Adrian Farrel
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Rakesh Gandhi (rgandhi)
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Lou Berger
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Rakesh Gandhi (rgandhi)
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Adrian Farrel
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Adrian Farrel
- Re: [Teas] AD review of draft-ietf-teas-mpls-tp-r… Rakesh Gandhi (rgandhi)