IETF Logo Mail Archive

Re: [Tools-discuss] Standalone iddiff?

Kesara Rathnayake <kesara@staff.ietf.org> Mon, 04 March 2024 18:25 UTC

Return-Path: <kesara@staff.ietf.org>
X-Original-To: tools-discuss@ietfa.amsl.com
Delivered-To: tools-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 31654C15792A for <tools-discuss@ietfa.amsl.com>; Mon, 4 Mar 2024 10:25:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.906
X-Spam-Level:
X-Spam-Status: No, score=-6.906 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=staff-ietf-org.20230601.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4t12ovJA5hhc for <tools-discuss@ietfa.amsl.com>; Mon, 4 Mar 2024 10:25:18 -0800 (PST)
Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 53112C1519A9 for <tools-discuss@ietf.org>; Mon, 4 Mar 2024 10:25:18 -0800 (PST)
Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a2f22bfb4e6so787922666b.0 for <tools-discuss@ietf.org>; Mon, 04 Mar 2024 10:25:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=staff-ietf-org.20230601.gappssmtp.com; s=20230601; t=1709576717; x=1710181517; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Ixip82uD96dssqb7RKZcMMUtd2765YR0H+hvOSR4+DI=; b=hyyqXne+mtfN38vwR+8SE3ZKHZkMUYKh4PKu0hPyGSsAeKnWM7mWt7umgA2xCQEIJa wAd+XXebcVRcVNE11QpxeS2tQrjeufUMtNvnmAJGtg9ETXGam7jwl/PbUSvedzZ3BipW NB1Ex/BFM5HKhiaYjMqT0t2xZbI0XhAwB5ej5+nkrsxPeUwxisjMtPxgqk5xdGi5Kd/L ZnorocDJEd3Ha4+YV0bzjrjXSi4Sp8oE9oHFIgZ22QGycLSkcOCWiysTpf0iUdyhuFQF QKuGIkxp9yDt4R7O4xR4hxLLFnNCZFkiMWwmC4mXFR68848s9abuPYjQjPdc44XG1ct0 yLQA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709576717; x=1710181517; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ixip82uD96dssqb7RKZcMMUtd2765YR0H+hvOSR4+DI=; b=qVNI6jKVnRuXew6kEn/WowidsqjdwggJgzeoN65CVRGRN6E6+Rzqehc1+NpZ56eqA4 CdD4DYYTomZbH4HWaEB6c4Bc+nrtjprd4rszf5EhX2h9c5z+MVf3cIauZITt32jkjyWI miW3AOuqtgSGXHbjjyCtOmIx/4ThWtv8ae++Uvyj95evQnbYOxYoAjYRtFYzkm+Sywb5 6gMC8NGg3hatz1OCX66XYZOqIbV/3dvuaLLHXfvjRlrHQHCPgxUcf6GmJki4Wal3jrv7 UfWgkn4RVCs8kfEgJs6LaoeiT+an874NIf4svNSJsiFSSFyQYV5yZC2mdWomrDbhMyK/ wNmw==
X-Forwarded-Encrypted: i=1; AJvYcCUGgUQbnUoI6jMsEvU/lLiNE3bR4G+snzKz4AOMWpCUzPemq1SC1CqVFYBoo6MBGtpdiivWGPygVVNZ0nI4OL2CdVLR1xix
X-Gm-Message-State: AOJu0YyxaKAOtPkPJr9+PqHfElk3ugUNJQnABy9tlpro096XTBmLo0Hg 1eW6TqD7Sw6Wogvls+J3FbGG9GsThFY+suUpOxtaXRfTdb8pe4CFyqPAE3Z79eVOFH2cxtqK2pR ucdt8VM7iVJ8ZcNrE9Q0nkojOslkPGxUkOXwx8ciZ+XWdpVVsnKDxDw==
X-Google-Smtp-Source: AGHT+IF04SihculYJniG2bLwbS/3RlVZ9udk4k86oOeOnAkjCvhXZmpKIb5EV53dy2I6ebw01IzIoQwKZK4jEHWwsJo=
X-Received: by 2002:a17:906:55c6:b0:a45:6926:c821 with SMTP id z6-20020a17090655c600b00a456926c821mr1845081ejp.10.1709576716723; Mon, 04 Mar 2024 10:25:16 -0800 (PST)
MIME-Version: 1.0
References: <FEA0AADB-89C3-4B5F-9470-A6579D9A4680@proper.com> <87r0gqkkfn.wl-morrowc@ops-netman.net> <87plwakk9m.wl-morrowc@ops-netman.net>
In-Reply-To: <87plwakk9m.wl-morrowc@ops-netman.net>
From: Kesara Rathnayake <kesara@staff.ietf.org>
Date: Tue, 05 Mar 2024 07:25:05 +1300
Message-ID: <CAD2=Z85A=3jwb0vTUGyOtNC06nnWEarUFsysgwxj=ffJPQAQgg@mail.gmail.com>
To: Chris Morrow <morrowc=40ops-netman.net@dmarc.ietf.org>
Cc: Paul Hoffman <phoffman@proper.com>, Tools Team Discussion <tools-discuss@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tools-discuss/9x3Or9eQEc5qScLBRVAoXGruGxA>
Subject: Re: [Tools-discuss] Standalone iddiff?
X-BeenThere: tools-discuss@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Tools Discussion <tools-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tools-discuss>, <mailto:tools-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tools-discuss/>
List-Post: <mailto:tools-discuss@ietf.org>
List-Help: <mailto:tools-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tools-discuss>, <mailto:tools-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Mar 2024 18:25:22 -0000

On Tue, 5 Mar 2024 at 05:57, Chris Morrow
<morrowc=40ops-netman.net@dmarc.ietf.org> wrote:
<snip>
>
> Err, so... that really just shells out to run some cli tool, it ALSO has this wierdness:
>
> https://github.com/ietf-tools/author-tools/blob/eb8fbbaf9b14cf59fd34ede21b9d324d5fb322c8/at/utils/iddiff.py#L48-L56
>
> which is essentially:
>   "Do the shell command, if that times out, do it again recursively"
>   (note there are no limitations on that recursion, yikes!)
>

Hi Chris,

There's no recursion there.
There are two tools for document comparison, one is rfcdiff [1] and
the other is iddiff [2].
Author Tools use rfcdiff by default because the community prefers it.
In some cases, iddiff is very slow compared to rfcdiff.
The code you pointed to retry with rfcdiff, if the comparison tool
used was iddiff and if that times out.

[1] https://github.com/ietf-tools/rfcdiff
[2] https://github.com/ietf-tools/iddiff

Cheers,
Kesara

> ___________________________________________________________
> Tools-discuss mailing list - Tools-discuss@ietf.org - https://www.ietf.org/mailman/listinfo/tools-discuss



-- 
Kesara Rathnayake
Senior Software Development Engineer - IETF Administration LLC
kesara@staff.ietf.org

v2.23.0 | Report a Bug | By Email