Re: [Tools-discuss] Standalone iddiff?

Jennifer Richards <jennifer@staff.ietf.org> Tue, 05 March 2024 11:30 UTC

Return-Path: <jennifer@staff.ietf.org>
X-Original-To: tools-discuss@ietfa.amsl.com
Delivered-To: tools-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 413C1C14F68D for <tools-discuss@ietfa.amsl.com>; Tue, 5 Mar 2024 03:30:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.908
X-Spam-Level:
X-Spam-Status: No, score=-6.908 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=staff-ietf-org.20230601.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pq59Ly9EEeVv for <tools-discuss@ietfa.amsl.com>; Tue, 5 Mar 2024 03:30:27 -0800 (PST)
Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B86A5C14F619 for <tools-discuss@ietf.org>; Tue, 5 Mar 2024 03:30:27 -0800 (PST)
Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-6869233d472so27949496d6.2 for <tools-discuss@ietf.org>; Tue, 05 Mar 2024 03:30:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=staff-ietf-org.20230601.gappssmtp.com; s=20230601; t=1709638227; x=1710243027; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0hujZrSl3psc1QuG5TI9oUOJ2Mh95FoUvKiSIELNEao=; b=mlDJ9eSiaAsjJr4KQwd9pXpS/B/l+6+cVsmil21HTrR/BbQ2Nbp3LaDFdD+x8RBO8L uTKvvE43h5rKocj4ErBO8RAoYEk+rUajODABmTrdus/GHcWYWEspRqSitnm9PNCl3xBH Rno++vStiKRsAeEpcOYsEv76qBwiQ2tuWt2zNfKXH2zdeqxsXsM2Ac9sDg7/JymTGIRo h1RQljJoaDE1QQt5V2cK9UWI8PQhtvH9IK6owdGmmNCWKg9x8qJ0APpV8RhMQKo0qkR6 iOVPaw4I2zfXCJ3BXednGlyIZAEV699IT9Db4j/NzJtRBc2ltb9nFbx39/QaiBI7Yj5c NexA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709638227; x=1710243027; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0hujZrSl3psc1QuG5TI9oUOJ2Mh95FoUvKiSIELNEao=; b=MdMIqhcTNxhN6/yVVdLjhUMKpLqTad5Wq7DXEI6C01RS1NN4ZEvEuwRnzUTEMHCLjP rAGhclK16TdzVUa0/ke2PcO/ROlzuSQPMRzERF3RmEv4Y3jlkDzn7CpCjatXVTw3lciT g01LCV1Yo+/ZZoayb2fwZDr3z8/XQg1iQ+lGx8XE5fr6kvAml1Isa0OgWYwElrk0TxQ/ sRXZSVry1a94InHwY8TOwu5vl/EW7fQcj2t6oa34VakhzRtv/6ZGpg7Fa05EjVI/Lcuq Ixtyijr8qWc4oAzSOicEaf13eWYs5v4KhRr8/R4enPrbRVuTKrtNHzpE42UadG1Wsnpv b32g==
X-Forwarded-Encrypted: i=1; AJvYcCWhhJM6dw9m0MSBuFP5nFhgoal+K4QYetDegyzRRk6kdS6e66RxyXG4e09Ysu/tphgKVO7um2jGXZ0v4J0Krk/WA3PEs62X
X-Gm-Message-State: AOJu0YwEbMvNG4xvovTe4u4STMKM7PuVjvGbg06qtZ5gjsiNeYpxfLsk bX0mKfjOZ6o7LI0eq0X3AXYzricRwqPef/TvkuyyIyE50xV6ErynQJ4a7Nie9AsCtdbPVoaObf2 3/hXjCKsiT2+U2bRlcay87pEP1Z7lK+JRbkpdDDOQ
X-Google-Smtp-Source: AGHT+IEfMOr5++WGsGXHDMPhz33XsOSxDDOTwQP1MQ9j0QzPChE7q35t8BY497E4pACTpD9cv5BdTcfactMeoKrtIPk=
X-Received: by 2002:a0c:fa49:0:b0:690:7db7:77fb with SMTP id k9-20020a0cfa49000000b006907db777fbmr1259980qvo.30.1709638226782; Tue, 05 Mar 2024 03:30:26 -0800 (PST)
MIME-Version: 1.0
References: <FEA0AADB-89C3-4B5F-9470-A6579D9A4680@proper.com> <87r0gqkkfn.wl-morrowc@ops-netman.net> <87plwakk9m.wl-morrowc@ops-netman.net> <CAD2=Z85A=3jwb0vTUGyOtNC06nnWEarUFsysgwxj=ffJPQAQgg@mail.gmail.com> <87o7btl4q6.wl-morrowc@ops-netman.net>
In-Reply-To: <87o7btl4q6.wl-morrowc@ops-netman.net>
From: Jennifer Richards <jennifer@staff.ietf.org>
Date: Tue, 05 Mar 2024 07:30:16 -0400
Message-ID: <CAFwTvRamOgU+ye5+Bj9y51E-9V3n0A6V2JAi_jA55y5FkA9ngw@mail.gmail.com>
To: Chris Morrow <morrowc=40ops-netman.net@dmarc.ietf.org>
Cc: Kesara Rathnayake <kesara@staff.ietf.org>, Paul Hoffman <phoffman@proper.com>, Tools Team Discussion <tools-discuss@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000033c7960612e82b98"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tools-discuss/y2moJVD0YsP29pn4b-vBrq3awBg>
Subject: Re: [Tools-discuss] Standalone iddiff?
X-BeenThere: tools-discuss@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Tools Discussion <tools-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tools-discuss>, <mailto:tools-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tools-discuss/>
List-Post: <mailto:tools-discuss@ietf.org>
List-Help: <mailto:tools-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tools-discuss>, <mailto:tools-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Mar 2024 11:30:28 -0000

Hi Chris,

The termination is guaranteed because it only calls itself a second time if
diff_tool != 'rfcdiff', and then makes that call with diff_tool ==
'rfcdiff'. It won't call itself again.

Jennifer



On Mon, Mar 4, 2024, 11:47 PM Chris Morrow <morrowc=
40ops-netman.net@dmarc.ietf.org> wrote:

>
> Sure, the setup here is:
>   "Start doing diff things, if that times out try myself again with
> (possibly) rfcdiff instead"
>
> then just keep on looping like that recursing 'forever' if the rfcdiff
> tool happens to also choke
> on the input.
>
> With no protection against that (which really is just a counter to the
> function signature and a check
> against max recursion) you're sort of just betting that you never have a
> bad day with rfcdiff.
>
>