Re: [tsvwg] I-D Action: draft-ietf-tsvwg-udp-options-dplpmtud-02.txt

mohamed.boucadair@orange.com Wed, 08 December 2021 12:19 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: tsvwg@ietfa.amsl.com
Delivered-To: tsvwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A1E233A0639 for <tsvwg@ietfa.amsl.com>; Wed, 8 Dec 2021 04:19:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Oy1d3d042JIX for <tsvwg@ietfa.amsl.com>; Wed, 8 Dec 2021 04:19:33 -0800 (PST)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.70.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 427AE3A064F for <tsvwg@ietf.org>; Wed, 8 Dec 2021 04:19:33 -0800 (PST)
Received: from opfednr06.francetelecom.fr (unknown [xx.xx.xx.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by opfednr22.francetelecom.fr (ESMTP service) with ESMTPS id 4J8GSM2RmDz109j; Wed, 8 Dec 2021 13:19:31 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1638965971; bh=jiz5rUu3pLjCBJQ4/MkAZeqBKinub9CSj5nsEgNp3mo=; h=From:To:Subject:Date:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=SLa7OAll5n8xHaaJtD+gjB+f1bX6LTVP7brj8qEq7jDPvKEi/e0K8p4fAb1M98M+M S13P46SbAGHIX3rOV5Wtcfxw0u5LfptlzKNEoVXMfAZ2Myk1YuK0YOGNhphT5jhc2s AAmOZWLqemoVEoQG+6Gdtc6Ng+NTDXxGBJZG9mGgLeJZgmY7vh5+ZMKM9A6PnuseqW gUCP8kgfvLCfycZn/O78HqKGbo7puAouvb8Rr5uS5RtiVfOFlpBSm2apaeNWqVV0QG 1H5qIiwN/Qz7uKTBHM9QtHM8EsB0ME6VdU3mD1CQSFrBykummqhW1xQCFLcqBlrHu3 w2Vpw1b4Qt0fQ==
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by opfednr06.francetelecom.fr (ESMTP service) with ESMTPS id 4J8GSM1lCGzDq7Z; Wed, 8 Dec 2021 13:19:31 +0100 (CET)
From: mohamed.boucadair@orange.com
To: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
CC: "tsvwg@ietf.org" <tsvwg@ietf.org>
Thread-Topic: I-D Action: draft-ietf-tsvwg-udp-options-dplpmtud-02.txt
Thread-Index: AQHX4hMUhZH0oeDvs0qoRrP/ufNf/qwobu/g
Content-Class:
Date: Wed, 08 Dec 2021 12:19:30 +0000
Message-ID: <24268_1638965971_61B0A2D3_24268_138_1_787AE7BB302AE849A7480A190F8B933035460D95@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
References: <163785494316.17506.9044882518269944059@ietfa.amsl.com>
In-Reply-To: <163785494316.17506.9044882518269944059@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Enabled=true; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SetDate=2021-12-08T10:35:40Z; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Method=Privileged; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Name=unrestricted_parent.2; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SiteId=90c7a20a-f34b-40bf-bc48-b9253b6f5d20; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ActionId=0ea3bbc4-218b-4f67-b612-c14608112fd7; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ContentBits=0
x-originating-ip: [10.114.13.245]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsvwg/W4D3lFTt5dJkz4lGwV9s2nBwj6Q>
Subject: Re: [tsvwg] I-D Action: draft-ietf-tsvwg-udp-options-dplpmtud-02.txt
X-BeenThere: tsvwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Working Group <tsvwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsvwg/>
List-Post: <mailto:tsvwg@ietf.org>
List-Help: <mailto:tsvwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Dec 2021 12:19:38 -0000

Hi Gorry, 

Thank you for taking into account the first set of comments. Please find below some additional comments. Most of them are nits. 

* Consider updating Section 2 to indicate that the reader should be familiar with the terms defined in Sections 2 and 5 of RFC8899.
* Section 3:
(1) (nit)

OLD: An upper PL (or application ..
NEW: An upper PL (or application) ..

(2) (nit)
OLD: at multiple levels, so, when when ...
NEW: at multiple levels, so, when ...

(3) (nit)
OLD: This section describes packet formats and procedures for DPLPMTUD using UDP Options ..
NEW: This document describes packet formats and procedures for DPLPMTUD using UDP Options ..

* Section 4:  

(1) ".. as noted in bullet 2 of Section 2 in [RFC8899]": I checked that section but failed to see the relevant part to which this text refers to. 

(2) You may change "token" to "nonce" to align with the udp-options I-D 

(3) (nit) s/to reception of a previously received REQ Option/to a received REQ Option

(4) (nit) s/reception of a specific received probe/reception of a specific probe

(5) "The initial value of the four byte token field SHOULD... ": not sure why "initial" is mentioned here. I would reword this to require that each nonce value is randomly generated. 

(6) (nit) s/A probe to confirm the path can support the BASE_PLPMTU see Section 5.1.4 of [RFC8899])/A probe to confirm the path can support the BASE_PLPMTU (Section 5.1.4 of [RFC8899]).

(7) Section 4.2.4 "Sending Packet Probes that include Application Data" says the following:

   The method can be designed to only use probes that are formed of a
   UDP datagram that includes application data (which could be
   applications control information), padded to the required size and
   include a RES Option.  This implements "Probing using padding data",
   and avoids having to retransmit application data when a probe fails.

There is a disconnect between the first sentence and the second one. 

* Section 7: I would a mention about nonce guards for off-path attacks.

Thank you. 

Cheers,
Med

> -----Message d'origine-----
> De : I-D-Announce <i-d-announce-bounces@ietf.org> De la part de internet-
> drafts@ietf.org
> Envoyé : jeudi 25 novembre 2021 16:42
> À : i-d-announce@ietf.org
> Cc : tsvwg@ietf.org
> Objet : I-D Action: draft-ietf-tsvwg-udp-options-dplpmtud-02.txt
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories.
> This draft is a work item of the Transport Area Working Group WG of the
> IETF.
> 
>         Title           : Datagram PLPMTUD for UDP Options
>         Authors         : Godred Fairhurst
>                           Tom Jones
> 	Filename        : draft-ietf-tsvwg-udp-options-dplpmtud-02.txt
> 	Pages           : 11
> 	Date            : 2021-11-25
> 
> Abstract:
>    This document specifies how a UDP Options sender implements Datagram
>    Packetization Layer Path Maximum Transmission Unit Discovery
>    (DPLPMTUD) as a robust method for Path Maximum Transmission Unit
>    discovery.  This method uses the UDP Options packetization layer.  It
>    allows a datagram application to discover the largest size of
>    datagram that can be sent across a specific network path.
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-tsvwg-udp-options-dplpmtud/
> 
> There is also an htmlized version available at:
> https://datatracker.ietf.org/doc/html/draft-ietf-tsvwg-udp-options-
> dplpmtud-02
> 
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-tsvwg-udp-options-dplpmtud-02
> 
> 
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
> 
> 
> _______________________________________________
> I-D-Announce mailing list
> I-D-Announce@ietf.org
> https://www.ietf.org/mailman/listinfo/i-d-announce
> Internet-Draft directories: http://www.ietf.org/shadow.html or
> ftp://ftp.ietf.org/ietf/1shadow-sites.txt

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.