Re: [xml2rfc-dev] Please help review v3 files

"Martin Thomson" <mt@lowentropy.net> Sat, 20 July 2019 13:25 UTC

Return-Path: <mt@lowentropy.net>
X-Original-To: xml2rfc-dev@ietfa.amsl.com
Delivered-To: xml2rfc-dev@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D8736120AC4 for <xml2rfc-dev@ietfa.amsl.com>; Sat, 20 Jul 2019 06:25:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lowentropy.net header.b=raLQ7PRT; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=ipUr+zGM
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qXHf_2Ic0YPk for <xml2rfc-dev@ietfa.amsl.com>; Sat, 20 Jul 2019 06:25:31 -0700 (PDT)
Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 959F7120098 for <xml2rfc-dev@ietf.org>; Sat, 20 Jul 2019 06:25:31 -0700 (PDT)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id BC0962E19 for <xml2rfc-dev@ietf.org>; Sat, 20 Jul 2019 09:25:30 -0400 (EDT)
Received: from imap2 ([10.202.2.52]) by compute1.internal (MEProxy); Sat, 20 Jul 2019 09:25:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lowentropy.net; h=mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type:content-transfer-encoding; s=fm2; bh=TINTo BAETzhByJfrknEw7NhFO8ChHgxS5qyH655hr4c=; b=raLQ7PRTrH7MmvU0IlpE4 0km9GPpoDBtPduZDpJGs2B70Lq11McO/uzMZtT+JidTbUEJ344eWdcw5+SfYVc1f WUDdpa9YcNXu/r1ODrSbQ8aFnNRA1lA9veZyuee71oSM6vF/kYPhEdLzg+r0ssli XGy8tNhQ1V8bWodxnzbslyhB2HHrozWVW1DTdU8oI66d1vAvhY9LDB0j5m8MXQyo P1Ujh0jI0ErIy2+ACdnRMYTLD5Sv15zsGN1uQECXO1s7K80sZW2bNRdGHkRGSwLN TS/HFatp/6w1BrDy5p8IqOXXtcp8nxpFfMhvcqqa3Fk16tmTL5Jk+tBPsoPUc8fC w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=TINToBAETzhByJfrknEw7NhFO8ChHgxS5qyH655hr 4c=; b=ipUr+zGMDHeA/hrgSZFipnZO6KHa9r+ZqA0zEISk2+9A8av734pIpkU2f 7boehH65cC4oY8dbnJeYcS6lYng+rzxZkV+p3AdBSXybl/pux9kX/gKhMjxny4gn ZUgPwmH+LbkwbCcOuHAazzaRDHNFjDy7vewjSVcYOZ7tmSJwSYBbFRh5yKC8M15E 0maxnGfRMVJVXkj+D1PIT/L38AmDh/kIate4VigNoYQtpc7Xt1jmpPyZbazlIzzH M7m/6YOHHG5VqKwsp57gJvjUIxvIz8mGvbNe3yVJRikRx5YV+xNYxQqbhy0jhwnB Ny26bKnhtOQMUlsn2+jDyKuy5AJeQ==
X-ME-Sender: <xms:ShYzXf1VVWDLJJTe6pH9KnE484-PsPygAH1iJz6FasgsMVSFpoJROg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrieelgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgfgsehtqh ertderreejnecuhfhrohhmpedfofgrrhhtihhnucfvhhhomhhsohhnfdcuoehmtheslhho figvnhhtrhhophihrdhnvghtqeenucffohhmrghinheprhhftgdqvgguihhtohhrrdhorh hgpdhthihpohhgrhgrphhhhihfohhrlhgrfiihvghrshdrtghomhdpihgvthhfrdhorhhg pdhquhhitgifghdrohhrghenucfrrghrrghmpehmrghilhhfrhhomhepmhhtsehlohifvg hnthhrohhphidrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:ShYzXRLsR4vTWaM7S5fXmhlyaoDJ_OS_5uizaYqtj-2speLEiyQMkA> <xmx:ShYzXaiHbYSCmsDEfdUDO1fZaMZDO1xnpAsT6iaDrmTJ90KVMm8XUg> <xmx:ShYzXRAqZmLnwvKYwOFVDV30KLVAMb3OxrFjaPLWf3GlwZ5yls8OhQ> <xmx:ShYzXbyTeb7P6wvLLgVu1SLsuoIjsxZhPKGG0r-zo0j92_0I5jCDLg>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 247F7E02D3; Sat, 20 Jul 2019 09:25:30 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.6-736-gdfb8e44-fmstable-20190718v2
Mime-Version: 1.0
Message-Id: <8a75c18e-812b-43be-a2a3-9f767052aa75@www.fastmail.com>
In-Reply-To: <62908E23-2FC0-4ED7-84B2-E86454020206@amsl.com>
References: <62908E23-2FC0-4ED7-84B2-E86454020206@amsl.com>
Date: Sat, 20 Jul 2019 09:25:42 -0400
From: Martin Thomson <mt@lowentropy.net>
To: xml2rfc-dev@ietf.org
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/xml2rfc-dev/EVWlZsSBShomDXBzOFR3tgkQKrM>
Subject: Re: [xml2rfc-dev] Please help review v3 files
X-BeenThere: xml2rfc-dev@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussion about particulars of xml2rfc V3 design, development and code." <xml2rfc-dev.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/xml2rfc-dev>, <mailto:xml2rfc-dev-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/xml2rfc-dev/>
List-Post: <mailto:xml2rfc-dev@ietf.org>
List-Help: <mailto:xml2rfc-dev-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/xml2rfc-dev>, <mailto:xml2rfc-dev-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Jul 2019 13:25:34 -0000

I only looked at the first example.

The table of contents overlay is not great for the reasons Carsten cited.  The spacing between items there is strange.

The references are similarly strangely formatted.  I think that is just the choice of really large anchor names [I-D.ietf-blablabla] rather than using shorter symbolic names though.

I don't like the choice of font, but I concede that this is subjective.

The use of small caps for the "(EDITOR)" designation is jarring.

The weight of the paragraph anchors is enough that it is very distracting.

Line lengths are too long.  https://typographyforlawyers.com/line-length.html

There are too many different font styles in use, particularly in the front matter.  The guidance we got from a professional designer is that you need to reduce the number of variations and that each change should only alter one thing (size, italic, bold, font, etc...)

There are also a bunch of things that are likely the result of problems in the source document.

The contributors section seems to be badly formatted in HTML.

The formatting of the insets in Section 4.2.1 is odd.

The indentation in Section 4.3 is odd.

Authors have errant commas.

The ordering of the trailing sections is a little hard to understand.  There are contributors, then references, then authors.

In comparison, https://quicwg.org/base-drafts/draft-ietf-quic-transport.html has none of these problems.  It also (subjectively) looks much nicer.

On Thu, Jul 18, 2019, at 02:19, Sandy Ginoza wrote:
> Hi all,
> 
> As you know, the transition to XMLv3 is quickly approaching.  As part 
> of our preparation, the RPC is  converting some XMLv2 files to XMLv3.  
> We’re hoping some of you will take the time to review the files and 
> provide feedback regarding whether the updates are as expected and the 
> XMLv3 files are considered “good” v3 files.  
> 
> A couple of notes:
> - we focused on format only; we did not make editorial updates. 
> - the diff files compare the initial v2v3 output with the files we edited.
> 
> Please review the following files:
> 
> 1) draft-ietf-spring-segment-routing-msdc
> https://www.ietf.org/id/draft-ietf-spring-segment-routing-msdc-11.txt
> 
> https://www.rfc-editor.org/v3test/draft-ietf-spring-segment-routing-msdc-11-MS.v2v3.html
> https://www.rfc-editor.org/v3test/draft-ietf-spring-segment-routing-msdc-11-MS.v2v3.pdf
> https://www.rfc-editor.org/v3test/draft-ietf-spring-segment-routing-msdc-11-MS.v2v3.txt
> https://www.rfc-editor.org/v3test/draft-ietf-spring-segment-routing-msdc-11-MS.v2v3.xml
> 
> rfc-xmldiff:
> https://www.rfc-editor.org/v3test/draft-ietf-spring-segment-routing-msdc-11-MS.v2v3-xmldiff.html
> 
> htmlwdiff:
> file:///Volumes/rfcpa/inc-work/v3test/draft-ietf-spring-segment-routing-msdc-11-MS.v2v3-htmlwdiff.html
> 
> 
> 2) draft-ietf-isis-l2bundles
> https://www.ietf.org/id/draft-ietf-isis-l2bundles-07.txt
> 
> Please pay particular attention to lists and the use of <aside>.  We 
> experimented with list styles and used <aside> for notes.  Using 
> <aside> in this way required some changes because <aside> can’t be used 
> within lists.  
> 
> https://www.rfc-editor.org/v3test/draft-ietf-isis-l2bundles-07-SG.v2v3.html
> https://www.rfc-editor.org/v3test/draft-ietf-isis-l2bundles-07-SG.v2v3.pdf
> https://www.rfc-editor.org/v3test/draft-ietf-isis-l2bundles-07-SG.v2v3.txt
> https://www.rfc-editor.org/v3test/draft-ietf-isis-l2bundles-07-SG.v2v3.xml
> 
> rfc-xmldiff:
> https://www.rfc-editor.org/v3test/draft-ietf-isis-l2bundles-07-SG.orignal.v2v3-xmldiff.html
> 
> htmlwdiff:
> https://www.rfc-editor.org/v3test/draft-ietf-isis-l2bundles-07-SG.orignal.v2v3-htmlwdiff.html
> 
> 
> Thanks for your help!
> Sandy
> 
> _______________________________________________
> xml2rfc-dev mailing list
> xml2rfc-dev@ietf.org
> https://www.ietf.org/mailman/listinfo/xml2rfc-dev
>