Re: [yang-doctors] Yangdoctors early review of draft-ietf-opsawg-ac-lxsm-lxnm-glue-04

Martin Björklund <mbj+ietf@4668.se> Wed, 24 January 2024 15:52 UTC

Return-Path: <mbj+ietf@4668.se>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E56A0C14F6A6; Wed, 24 Jan 2024 07:52:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=4668.se header.b="TNtNAxIe"; dkim=pass (2048-bit key) header.d=messagingengine.com header.b="jBkhluyj"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zWExR8UnhVHc; Wed, 24 Jan 2024 07:52:18 -0800 (PST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 50091C14F691; Wed, 24 Jan 2024 07:52:15 -0800 (PST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 591A75C0085; Wed, 24 Jan 2024 10:52:14 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 24 Jan 2024 10:52:14 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=4668.se; h=cc:cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1706111534; x=1706197934; bh=8p/rz062Sa34SNelNME7VtnHofzAnNzuPNkSBdxJokE=; b= TNtNAxIeu/01NX4Ro7o9WTMCMaB6crvshCe1vxATN3HSvVLl/p7xbjq5+DAHAHR/ QsjGJWVzbPqaHE6QxOJVgUTpYGXOpw3D9DYKxCvkRcamw9OXFx7069ahOAnIq9ao C3Dda4TXYf/Q94nrAPmBXK2k/cG8e/R1i2WeRcI6oPSD8CI8yOQoolrwbGWp8Teb /BuV9CJIc7sXjZympWaZFEwJmhNj5S0gcznpljvJEEIYEmTmWvIcpSlZ5CtGydPB /sE72wOdsBT5QXNyHnyVuB6lAKC6JkSQluY/eY3xXXkm9Pk8WfoRSfpqQ9wlwHNC lRytfW4ozXVtPBz6rl2eag==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1706111534; x= 1706197934; bh=8p/rz062Sa34SNelNME7VtnHofzAnNzuPNkSBdxJokE=; b=j BkhluyjtPq9bvjIj3/qXej4rqzIraxIU87Akzp6e24pWjVZRVMxA5pp2Ot7XMB95 Qz0vP4f2u+xQfKv6ThMoaLtQBRtiV1EfoL7YDH5JbA0cO4dGfsJbndarOttslk7i W/hPIxjCVOcR7CXxnHDJs1l6eItdtOLgdm5JrMYLQJAG2freZvVTkEGaZWv8alg2 bKqo8vFm7dZjCNQZ5W6LT0HaJ4OEaKGixSiOkz7iZcpmGWVUK439iEntLA8k5oNQ WoDIMLLkwuxdV8QEaFFAn65vZCd7HSdpeQs5K8EcImK51nXxtXyZTaHe2EYl0Eo2 GMLcBNUCbfEgOLgt5KSuA==
X-ME-Sender: <xms:LjKxZbaBxZ0YlPRNUp4vqqPqxuK7ANKW16TrIy5DjYrWnuLgIZMRDQ> <xme:LjKxZabaX09DIlgwraCaSQ5aoqDvkt8fRGgtJbLwXcRIzrAFpgzDCQRj1vY0Lv-yc M7LXx7xVJkeFU4LcY8>
X-ME-Received: <xmr:LjKxZd-UqWZWBCm1o4oWNUzFgewrJt61z4dMjBr-JT21St5WBOy40Ic0voY0brAMml14TkzppuDuccWnh8WJ-R-s2rxQvnv7og>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeluddgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffkffvvefuhfgjfhfogggtgfesth hqredtredtudenucfhrhhomhepofgrrhhtihhnuceujhpnrhhklhhunhguuceomhgsjhdo ihgvthhfseegieeikedrshgvqeenucggtffrrghtthgvrhhnpeejuedvkeeugfekgfegte eigefgheehkeefuddvueekheejgeeuhefffeehveegtdenucffohhmrghinhepihgvthhf rdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgsjhdoihgvthhfseegieeikedrshgv
X-ME-Proxy: <xmx:LjKxZRopbPYW-dMtyTqaLnncHDrRl2HrgdiOnPB6_CQ_8tgiPc-p_A> <xmx:LjKxZWqgNsX7vaCMeykFpurzrg6jBmFKSM4lGZeKYVwl0JjblaHrOw> <xmx:LjKxZXQlAFuHgQLgmyF31cpuAAEgN7x6MEjYLLLHBr3_k1m547rCxQ> <xmx:LjKxZd2QyRtg1TACvXlY7Q0h0Yp8NVBAmZ0Gu-hUGiYoVd1XYoA_Pw>
Feedback-ID: icc614784:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Jan 2024 10:52:13 -0500 (EST)
Date: Wed, 24 Jan 2024 16:52:12 +0100
Message-Id: <20240124.165212.1330707583966794182.id@4668.se>
To: mohamed.boucadair@orange.com
Cc: yang-doctors@ietf.org, draft-ietf-opsawg-ac-lxsm-lxnm-glue.all@ietf.org, opsawg@ietf.org
From: Martin Björklund <mbj+ietf@4668.se>
In-Reply-To: <DU2PR02MB1016003E6EB0533A9BBD81164887B2@DU2PR02MB10160.eurprd02.prod.outlook.com>
References: <170610950867.34771.1207784200124930386@ietfa.amsl.com> <DU2PR02MB1016003E6EB0533A9BBD81164887B2@DU2PR02MB10160.eurprd02.prod.outlook.com>
X-Mailer: Mew version 6.8 on Emacs 27.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/nCXv-l67vMz0u8oUTd6VFmnbFGw>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-opsawg-ac-lxsm-lxnm-glue-04
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jan 2024 15:52:23 -0000

mohamed.boucadair@orange.com wrote:
> Hi Martin,
> 
> Thanks for the review.
> 
> FWIW, a new version that fixes the nit you reported and other minor pending we had is available online: 
> https://author-tools.ietf.org/iddiff?url2=draft-ietf-opsawg-ac-lxsm-lxnm-glue-05

That was quick!  However, the spelling error is still there, and I
think you introduced a new one ;-)


            was provisionned using the ACaaS module.";
                ^^^^^^^^^^^^

Thansk to Martin Björklund for the yangdoctors review.
^^^^^^



/martin






> 
> Cheers,
> Med
> 
> > -----Message d'origine-----
> > De : Martin Björklund via Datatracker <noreply@ietf.org>
> > Envoyé : mercredi 24 janvier 2024 16:18
> > À : yang-doctors@ietf.org
> > Cc : draft-ietf-opsawg-ac-lxsm-lxnm-glue.all@ietf.org; opsawg@ietf.org
> > Objet : Yangdoctors early review of draft-ietf-opsawg-ac-lxsm-lxnm-
> > glue-04
> > 
> > Reviewer: Martin Björklund
> > Review result: Ready with Nits
> > 
> > This is a very short, and from a YANG-perspective simple, module. It
> > looks good, and I also found one nit: s/provisionned/provisioned/g
> > 
> > /martin
> > 
> 
> ____________________________________________________________________________________________________________
> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
> Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
> 
> This message and its attachments may contain confidential or privileged information that may be protected by law;
> they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
> Thank you.