Re: [6tisch] Iotdir early review of draft-ietf-6tisch-enrollment-enhanced-beacon-05

"Prof. Diego Dujovne" <diego.dujovne@mail.udp.cl> Thu, 07 November 2019 11:33 UTC

Return-Path: <diego.dujovne@mail.udp.cl>
X-Original-To: 6tisch@ietfa.amsl.com
Delivered-To: 6tisch@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DBDEA120127 for <6tisch@ietfa.amsl.com>; Thu, 7 Nov 2019 03:33:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=mail-udp-cl.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QYU7jP3tOCuq for <6tisch@ietfa.amsl.com>; Thu, 7 Nov 2019 03:33:37 -0800 (PST)
Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 78D8012012C for <6tisch@ietf.org>; Thu, 7 Nov 2019 03:33:37 -0800 (PST)
Received: by mail-oi1-x236.google.com with SMTP id 22so1643973oip.7 for <6tisch@ietf.org>; Thu, 07 Nov 2019 03:33:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail-udp-cl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hHOFjWcIn22kxwiB1ANWu1EPRdxEGVRndVFo7N1ClZA=; b=mTBQC/hRM6YZWKWYl2nNfTBZi4tbz76dsaVhLfpBM+738JiWZMOPfAdGPrdIRrXslX lLhIATSF7N8Ui6LwCgkS3FxRuntJfSzsAnLyEbcXc/huKvZJvyvTdKLjosrovmVQt4N8 4k3PdETFX4OvAoVUZgG8UTawsJe9dTAib+67ukQ7LWSiez3wriZMll8lbRzNYGC4wlPZ /N9hyciP8C3OUBNLWly7WjN0AKyQkWnBhJ8MEkAWIsUF+Db+WTOoQzAERjeOHvTbTj5t 82UuUlcRcp10BhdQeMr/d2uQEaAoQmonGnBLAdP9Zsdu9zg1gyjdOwVfU6HEilAP6zMm nMog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hHOFjWcIn22kxwiB1ANWu1EPRdxEGVRndVFo7N1ClZA=; b=O7FeVLHR4N+1FHgvNpEZ3Tq9I4ZQACIUy+oB41LEuU2HKfR1WeHvG78PSgCgJTWEnC lqVvupZsZPoBOVDuPHOvxVPAxWFiaVGU2uYnpDmWBJTHTZuOBYEDBPCRix8yZ5txcD/M dl9hEVP7ok2mS30B2f7rBbO+ChEh1Bv9+LHyVPM1urpJP0dJ6Qf3y7BY+aq0eqWc6Dvg Qn+XxXTVJ3pVpvEqwRRa5LFsxZHdoizRtmDn5wCT6ClFVfKGPJt1Y3QqHDfIwcDpiZNe FO0XhCJOfyBPtAF9X70/3mRMNDOEQPB8GB/j6qfvBoIZ37Uv1RxK8p2hv+wk0q1vZ0rh 3U0g==
X-Gm-Message-State: APjAAAWvEKqTx3KT6FQ+LtZjswKdxtI3ARFJu4bAqe3ROg+TP+JJZFo1 gNpZbZwCdDN0683zjfKkcNZvpNM/EtwN3rTYCBqvbQ==
X-Google-Smtp-Source: APXvYqyMKV3S2M+JnY7AKVQcMq489GV/tWFZ5EZ/oI1Q4Kq5TAX2eTBjcXLCycQEQvClGbuCJyYfTKe16+LcRs0F4ac=
X-Received: by 2002:aca:2b09:: with SMTP id i9mr2875077oik.66.1573126416426; Thu, 07 Nov 2019 03:33:36 -0800 (PST)
MIME-Version: 1.0
References: <157193288761.11358.2170640249540995207@ietfa.amsl.com> <549DBF6D-95FD-48B3-933A-BB3D621350F1@kaloom.com>
In-Reply-To: <549DBF6D-95FD-48B3-933A-BB3D621350F1@kaloom.com>
From: "Prof. Diego Dujovne" <diego.dujovne@mail.udp.cl>
Date: Thu, 7 Nov 2019 08:33:25 -0300
Message-ID: <CAH7SZV_6yV6ajSXz3mz9Dm=k7ak4gycmZbkzeZdaA=5=MDH-vA@mail.gmail.com>
To: Suresh Krishnan <Suresh@kaloom.com>
Cc: Carles Gomez <carlesgo@entel.upc.edu>, "Iot-dir@ietf.org" <Iot-dir@ietf.org>, "6tisch@ietf.org" <6tisch@ietf.org>, "draft-ietf-6tisch-enrollment-enhanced-beacon.all@ietf.org" <draft-ietf-6tisch-enrollment-enhanced-beacon.all@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000003cfd800596c00905"
Archived-At: <https://mailarchive.ietf.org/arch/msg/6tisch/CwIqK7ZeZbsDg4OfgytN0Y_v_tc>
Subject: Re: [6tisch] Iotdir early review of draft-ietf-6tisch-enrollment-enhanced-beacon-05
X-BeenThere: 6tisch@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discuss link layer model for Deterministic IPv6 over the TSCH mode of IEEE 802.15.4e, and impacts on RPL and 6LoWPAN such as resource allocation" <6tisch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/6tisch>, <mailto:6tisch-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/6tisch/>
List-Post: <mailto:6tisch@ietf.org>
List-Help: <mailto:6tisch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/6tisch>, <mailto:6tisch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Nov 2019 11:33:41 -0000

Dear all,
             I would like to thank Carles for his prompt
and detailed review of the enrollment enhanced beacon
draft. We have taken care of all the comments and made
the corresponding changes.
             Version -06 was published on Monday, as you
may have noticed on the datatracker.
             Regards,

                                           Diego Dujovne

Le mar. 29 oct. 2019 à 00:07, Suresh Krishnan <Suresh@kaloom.com> a écrit :

> Thanks a lot Carles for your careful review and your text change
> proposals. Authors, any thoughts on these changes?
>
> Regards
> Suresh
>
> > On Oct 24, 2019, at 12:01 PM, Carles Gomez via Datatracker <
> noreply@ietf.org> wrote:
> >
> > Reviewer: Carles Gomez
> > Review result: Ready with Issues
> >
> > Thanks to the authors for writing this document.
> >
> > I did not identify technical problems. (There are comments below that do
> have a
> > technical side, but the issues might just be editorial.)
> >
> > There is a number of suggestions provided below, mostly editorial and
> about
> > presentation.
> >
> > Title
> > - "IEEE802.15.4" --> "IEEE 802.15.4"
> > - "Informational Element" --> "Information Element"
> > - "6tisch" --> "6TiSCH"
> >
> > Abstract: I'd suggest adding a comma after "In TSCH mode of IEEE STD
> 802.15.4".
> >
> > Section 1.
> > - "As further details" --> "As further detailed"
> > - Introduce the acronym "EB" the first time that "Enhanced Beacon"
> appears.
> > (Then use "EB" thereafter in the document.)
> >
> > Subsection 1.2.
> > - After "synchronization of ASN and Join Metric," perhaps you may insert
> > "carrying" and reorganize a bit the rest of the sentence. - "existance"
> -->
> > "existence" - "There are a limited number...". --> "There is a limited
> > number..." - "... by each router". Perhaps, to give more context, "by
> each
> > router in the network".
> >
> > Subsection 1.3.
> > - Title: please add ":" after "synchronization".
> > - Title: capitalize "solicitations" and "advertisements"
> > - On the first use of RS, RA, NS and NA, please use the expanded form and
> > introduce the acronym, and use the acronym thereafter. - "consuming a
> broadcast
> > aloha slot with unencrypted traffic" appears to be one of the reasons
> > mentioned, but it is a bit hidden between parenthesis. You may want to
> > reorganize the sentence to emphasize that this is actually the crucial
> point. -
> > Second bullet in the list: did you mean "RA" instead of "Router
> Soliciation" -
> > Third bullet in the list: "If it must listen for a RS as well..." Did
> you mean
> > "listen for an RA" ?
> >
> > - It might be nice to close Section 1 by adding something along the
> lines of
> > "This document defines...". However, this would not be specific to
> subsection
> > 1.3. Therefore, some reorganization of Section 1 might improve the
> document.
> >
> > Section 2.
> > - Even if there is a single figure in the whole document, it might be
> good to
> > add a figure number and a caption the format for the new IE subtype. -
> After
> > the figure, is there a particular reason why the fields of the format are
> > presented in a different order from the one in the format? - Please add
> a ":"
> > after the name of each field and its definition/description. - "this
> field
> > indicates the willingness to act as join proxy". Perhaps "the
> willingness of
> > the sender to act..."? - "Lower value indicates willing to act as a Join
> > Proxy..." Perhaps "Lower value indicates greater willingness to act
> as..." -
> > "Values range 0 (most willing)..." --> "Values range 0x00 (most
> willing)..." -
> > In the figure, one field is called "Join Proxy lower-64". In the text,
> it has a
> > different name... - "if the Proxy Address P-flag is set, then the lower
> 64-bits
> > of the Join Proxy’s Link Layer address..." Did you mean "link-local"
> instead of
> > "Link Layer? - "the layer-2 address of any IPv6 traffic to the
> originator". Did
> > you mean "the destination layer-2 address..." ? - "if the P bit is set,
> then 64
> > bits (8 bytes) of address are present." I had trouble understanding this
> > sentence. Please consider rewriting it. - "this is an variable length
> field"
> > --> "this is a variable length field".
> >
> > Section 5.
> > - "Registry IETF IE Sub-type ID." Please cite RFC 8137 here as well.
> >
>
>

-- 
DIEGO DUJOVNE
Profesor Asociado
Escuela de Informática y Telecomunicaciones
Facultad de Ingeniería - Universidad Diego Portales - Chile
www.ingenieria.udp.cl
(56 2) 676 8125