[apps-discuss] Appsdir review of XML schema in https://tools.ietf.org/html/draft-ietf-clue-data-model-schema-14

ht@inf.ed.ac.uk (Henry S. Thompson) Wed, 11 May 2016 15:55 UTC

Return-Path: <ht@inf.ed.ac.uk>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 02B4C12D142 for <apps-discuss@ietfa.amsl.com>; Wed, 11 May 2016 08:55:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.217
X-Spam-Level:
X-Spam-Status: No, score=-5.217 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.996, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4TdxQxoY2Yjs for <apps-discuss@ietfa.amsl.com>; Wed, 11 May 2016 08:55:10 -0700 (PDT)
Received: from nougat.ucs.ed.ac.uk (nougat.ucs.ed.ac.uk [129.215.13.205]) by ietfa.amsl.com (Postfix) with ESMTP id 0F7E812B008 for <apps-discuss@ietf.org>; Wed, 11 May 2016 08:55:09 -0700 (PDT)
Received: from crunchie.inf.ed.ac.uk (crunchie.inf.ed.ac.uk [129.215.33.180]) by nougat.ucs.ed.ac.uk (8.13.8/8.13.4) with ESMTP id u4BFt7ug018160; Wed, 11 May 2016 16:55:09 +0100 (BST)
Received: from troutbeck.inf.ed.ac.uk (troutbeck.inf.ed.ac.uk [129.215.25.32]) by crunchie.inf.ed.ac.uk (8.14.4/8.14.4) with ESMTP id u4BFt6GF004119; Wed, 11 May 2016 16:55:06 +0100
Received: from troutbeck.inf.ed.ac.uk (localhost [127.0.0.1]) by troutbeck.inf.ed.ac.uk (8.14.7/8.14.7) with ESMTP id u4BFt5dM012920; Wed, 11 May 2016 16:55:05 +0100
Received: (from ht@localhost) by troutbeck.inf.ed.ac.uk (8.14.7/8.14.7/Submit) id u4BFt5E0012919; Wed, 11 May 2016 16:55:05 +0100
X-Authentication-Warning: troutbeck.inf.ed.ac.uk: ht set sender to ht@inf.ed.ac.uk using -f
To: apps-discuss@ietf.org, "=?utf-8?Q?draft-name-without-version-num?= =?utf-8?Q?=E2=80=8B=2Eall?=@ietf.org cc": =?utf-8?Q?=E2=80=8Biesg?=@ietf.org
From: ht@inf.ed.ac.uk (Henry S. Thompson)
Date: Wed, 11 May 2016 16:55:05 +0100
Message-ID: <f5b1t58fv3a.fsf@troutbeck.inf.ed.ac.uk>
User-Agent: Gnus/5.1012 (Gnus v5.10.12) XEmacs/21.5-b34 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Edinburgh-Scanned: at nougat.ucs.ed.ac.uk with MIMEDefang 2.60, Sophie, Sophos Anti-Virus, Clam AntiVirus
X-Scanned-By: MIMEDefang 2.60 on 129.215.13.205
Archived-At: <http://mailarchive.ietf.org/arch/msg/apps-discuss/8zNlrJIXq-r-km_zCpeLIeY05rs>
Subject: [apps-discuss] Appsdir review of XML schema in https://tools.ietf.org/html/draft-ietf-clue-data-model-schema-14
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/apps-discuss/>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 May 2016 15:55:13 -0000

Document: draft-ietf-clue-data-model-schema
Title: An XML Schema for the CLUE data model
Reviewer: Henry S. Thompson
Review Date: 2016-05-11
IETF Last Call Date: 2016-05-23
ESG Telechat Date: 2016-06-02

I have been selected as the Applications Area Directorate reviewer for
this draft (for background on appsdir, please see
http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate).

Please resolve these comments along with any other Last Call comments
you may receive. Please wait for direction from your document shepherd
or AD before posting a new version of the draft.

Summary: The XML Schema itself which is included in this draft is
conformant to the XML Schema 1.0 spec, and is good to go, subject to a
minor correction.  There is a minor glitch in one of the XML examples,
also easily corrected.

Comments:

I tested the XML Schema document included as section 4 and it passes as
valid against the schema for schemas.  The example document in section
17 is schema-valid according to the corresponding schema.  See 'Nits'
below for a minor problem with the example document in section 18.

I briefly reviewed the schema document and it seems straightforward and
fit for its intended purpose.

Minor Issues:

Section 4, lines 13--14:

 <xs:import namespace="urn:ietf:params:xml:ns:vcard-4.0"
 schemaLocation="xcard.xsd"/>

As this stands, it's not actually usable for validation purposes,
because no xcard.xsd file is supplied.  Furthermore, there is no
Appendix A, which is alleged to provide it (see 11.29.1.2).

I note further that the xCard RFC (6351) doesn't contain an XSD-format
schema document either.  The IANA XML Registry [1] schema entry for the
urn:ietf:params:xml:ns:vcard-4.0 URN namespace _does_ however link to
such a schema document [2].  I suggest you either
  a) Edit the draft so the above lines read

 <xs:import namespace="urn:ietf:params:xml:ns:vcard-4.0"
 schemaLocation="http://www.iana.org/assignments/xml-registry/schema/vcard-4.0.xsd"/>

  (this is what I did to do the validity checks I did);

or

 b) Delete the schemaLocation attribute and add a comment identifying
    possible sources of a schema document for the vcard-4.0 namespace,
    e.g. the above iana.org URI or the contents of Appendix A (if you
    fill it in).

Nits:

Section 18, the XML example has a (copy-paste?) error, which renders
that example invalid against the schema.  The line

             <encGroupIDREF>EG0</encGroupIDREF>

appears twice inside mediaCapture VC7, once on line 204 and once on line
237.  The first occurrence should be deleted.

[1] http://www.iana.org/assignments/xml-registry/xml-registry.xhtml#schema
[2] http://www.iana.org/assignments/xml-registry/schema/vcard-4.0.xsd
-- 
       Henry S. Thompson, School of Informatics, University of Edinburgh
      10 Crichton Street, Edinburgh EH8 9AB, SCOTLAND -- (44) 131 650-4440
                Fax: (44) 131 650-4587, e-mail: ht@inf.ed.ac.uk
                       URL: http://www.ltg.ed.ac.uk/~ht/
 [mail from me _always_ has a .sig like this -- mail without it is forged spam]